Skip to contentSkip to conversation

clk: vc5: Add support for IDT VersaClock 5P49V6965

PATCH Applied Adam Ford 3 participants 6 messages Apr 4, 2020 – May 29, 2020

Subsystems (3)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/2 clk: vc5: Add support for IDT VersaClock 5P49V6965

Update IDT VersaClock 5 driver to support 5P49V6965.

drivers/clk/clk-versaclock5.c +0 -0

index 24fef51fbcb5..fa96659f8023

drivers/clk/clk-versaclock5.c +11 -0
@@ -124,6 +124,7 @@ enum vc5_model {
 	IDT_VC5_5P49V5933,
 	IDT_VC5_5P49V5935,
 	IDT_VC6_5P49V6901,
+	IDT_VC6_5P49V6965,
 };
 
 /* Structure to describe features of a particular VC5 model */
@@ -683,6 +684,7 @@ static int vc5_map_index_to_output(const enum vc5_model model,
 	case IDT_VC5_5P49V5925:
 	case IDT_VC5_5P49V5935:
 	case IDT_VC6_5P49V6901:
+	case IDT_VC6_5P49V6965:
 	default:
 		return n;
 	}
@@ -956,12 +958,20 @@ static const struct vc5_chip_info idt_5p49v6901_info = {
 	.flags = VC5_HAS_PFD_FREQ_DBL,
 };
 
+static const struct vc5_chip_info idt_5p49v6965_info = {
+	.model = IDT_VC6_5P49V6965,
+	.clk_fod_cnt = 4,
+	.clk_out_cnt = 5,
+	.flags = 0,
+};
+
 static const struct i2c_device_id vc5_id[] = {
 	{ "5p49v5923", .driver_data = IDT_VC5_5P49V5923 },
 	{ "5p49v5925", .driver_data = IDT_VC5_5P49V5925 },
 	{ "5p49v5933", .driver_data = IDT_VC5_5P49V5933 },
 	{ "5p49v5935", .driver_data = IDT_VC5_5P49V5935 },
 	{ "5p49v6901", .driver_data = IDT_VC6_5P49V6901 },
+	{ "5p49v6965", .driver_data = IDT_VC6_5P49V6965 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, vc5_id);
@@ -972,6 +982,7 @@ static const struct of_device_id clk_vc5_of_match[] = {
 	{ .compatible = "idt,5p49v5933", .data = &idt_5p49v5933_info },
 	{ .compatible = "idt,5p49v5935", .data = &idt_5p49v5935_info },
 	{ .compatible = "idt,5p49v6901", .data = &idt_5p49v6901_info },
+	{ .compatible = "idt,5p49v6965", .data = &idt_5p49v6965_info },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 dt: Add bindings for IDT VersaClock 5P49V5925

IDT VersaClock 5 5P49V6965 has 5 clock outputs, 4 fractional dividers.

Documentation/devicetree/bindings/clock/idt,versaclock5.txt +1 -0
index 05a245c9df08..bcff681a4bd0 100644
@@ -12,6 +12,7 @@ Required properties:
 		"idt,5p49v5933"
 		"idt,5p49v5935"
 		"idt,5p49v6901"
+		"idt,5p49v6965"
 - reg:		i2c device address, shall be 0x68 or 0x6a.
 - #clock-cells:	from common clock binding; shall be set to 1.
 - clocks:	from common clock binding; list of parent clock handles,
Signature · 1 line
2.25.1
maintainer Applied
#3 lore raw

Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925

In reply to Adam Ford

Quoting Adam Ford (2020-04-04 09:15:36)

Documentation/devicetree/bindings/clock/idt,versaclock5.txt

Quoted 7 lines

IDT VersaClock 5 5P49V6965 has 5 clock outputs, 4 fractional dividers.

Documentation/devicetree/bindings/clock/idt,versaclock5.txt +0 -1
index 05a245c9df08..bcff681a4bd0 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt

Applied to clk-next

BTW, the patch format threw my scripts off because there isn't a triple dash after the SoB line.

author
#4 lore raw
In reply to Adam Ford
Quoted 5 lines · Adam Ford

Update IDT VersaClock 5 driver to support 5P49V6965.

Gentle ping. Rob H has given the 2nd which adds the bindings his
'signed-of-by'

Once this has been approved, I'll be issuing an update to an another patch series for this same clock, and once those have been approved, I'll be introducing a new board, but I need this patch approved before I can do that.

thanks,

adam

Quoted 53 lines
drivers/clk/clk-versaclock5.c +0 -0

index 24fef51fbcb5..fa96659f8023

drivers/clk/clk-versaclock5.c +11 -1
@@ -124,6 +124,7 @@ enum vc5_model {
        IDT_VC5_5P49V5933,
        IDT_VC5_5P49V5935,
        IDT_VC6_5P49V6901,
+       IDT_VC6_5P49V6965,
 };
 
 /* Structure to describe features of a particular VC5 model */
@@ -683,6 +684,7 @@ static int vc5_map_index_to_output(const enum vc5_model model,
        case IDT_VC5_5P49V5925:
        case IDT_VC5_5P49V5935:
        case IDT_VC6_5P49V6901:
+       case IDT_VC6_5P49V6965:
        default:
                return n;
        }
@@ -956,12 +958,20 @@ static const struct vc5_chip_info idt_5p49v6901_info = {
        .flags = VC5_HAS_PFD_FREQ_DBL,
 };
 
+static const struct vc5_chip_info idt_5p49v6965_info = {
+       .model = IDT_VC6_5P49V6965,
+       .clk_fod_cnt = 4,
+       .clk_out_cnt = 5,
+       .flags = 0,
+};
+
 static const struct i2c_device_id vc5_id[] = {
        { "5p49v5923", .driver_data = IDT_VC5_5P49V5923 },
        { "5p49v5925", .driver_data = IDT_VC5_5P49V5925 },
        { "5p49v5933", .driver_data = IDT_VC5_5P49V5933 },
        { "5p49v5935", .driver_data = IDT_VC5_5P49V5935 },
        { "5p49v6901", .driver_data = IDT_VC6_5P49V6901 },
+       { "5p49v6965", .driver_data = IDT_VC6_5P49V6965 },
        { }
 };
 MODULE_DEVICE_TABLE(i2c, vc5_id);
@@ -972,6 +982,7 @@ static const struct of_device_id clk_vc5_of_match[] = {
        { .compatible = "idt,5p49v5933", .data = &idt_5p49v5933_info },
        { .compatible = "idt,5p49v5935", .data = &idt_5p49v5935_info },
        { .compatible = "idt,5p49v6901", .data = &idt_5p49v6901_info },
+       { .compatible = "idt,5p49v6965", .data = &idt_5p49v6965_info },
        { },
 };
 MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
--

2.25.1

maintainer Applied
#5 lore raw
In reply to Adam Ford

Quoting Adam Ford (2020-04-04 09:15:35)

Quoted 8 lines

Update IDT VersaClock 5 driver to support 5P49V6965.

drivers/clk/clk-versaclock5.c +0 -0

index 24fef51fbcb5..fa96659f8023
--- a/drivers/clk/clk-versaclock5.c

Applied to clk-next