Skip to contentSkip to conversation

mtd: spi-nor: Compile files in controllers/ directory

PATCH Applied Guenter Roeck 5 participants 5 messages Apr 4, 2020 – Apr 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: Compile files in controllers/ directory

Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") moved various files into a new directory, but did not add the new directory to its parent directory Makefile. The moved files no longer build, and affected flash chips no longer instantiate.

Adding the new directory to the parent directory Makefile fixes the problem.

Fixes a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc Boris Brezillon <[email protected]>
Cc Tudor Ambarus <[email protected]>
---
 drivers/mtd/spi-nor/Makefile | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/Makefile +2 -0
index 7ddb742de1fe..653923896205 100644
@@ -18,3 +18,5 @@ spi-nor-objs			+= winbond.o
 spi-nor-objs			+= xilinx.o
 spi-nor-objs			+= xmc.o
 obj-$(CONFIG_MTD_SPI_NOR)	+= spi-nor.o
+
+obj-$(CONFIG_MTD_SPI_NOR)	+= controllers/
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Sat, 4 Apr 2020 08:36:31 -0700 Guenter Roeck <[email protected]> wrote:

Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") moved various files into a new directory, but did not add the new directory to its parent directory Makefile. The moved files no longer build, and affected flash chips no longer instantiate.

Quoted 7 lines

Adding the new directory to the parent directory Makefile fixes the problem.

Fixes a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc Boris Brezillon <[email protected]>
Cc Tudor Ambarus <[email protected]>

Thanks for the fix, and my apologies for the regression.

Quoted 14 lines
---
 drivers/mtd/spi-nor/Makefile | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/Makefile +2 -0
index 7ddb742de1fe..653923896205 100644
@@ -18,3 +18,5 @@ spi-nor-objs			+= winbond.o
 spi-nor-objs			+= xilinx.o
 spi-nor-objs			+= xmc.o
 obj-$(CONFIG_MTD_SPI_NOR)	+= spi-nor.o
+
+obj-$(CONFIG_MTD_SPI_NOR)	+= controllers/
Acked-by on v1 1/1
#2 lore raw
In reply to Guenter Roeck
Quoted 6 lines · Guenter Roeck

Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") moved various files into a new directory, but did not add the new directory to its parent directory Makefile. The moved files no longer build, and affected flash chips no longer instantiate.

Quoted 7 lines

Adding the new directory to the parent directory Makefile fixes the problem.

Fixes a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc Boris Brezillon <[email protected]>
Cc Tudor Ambarus <[email protected]>

Thanks Guenter. I just discovered this too.

Quoted 17 lines
---
 drivers/mtd/spi-nor/Makefile | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/Makefile +2 -1
index 7ddb742de1fe..653923896205 100644
@@ -18,3 +18,5 @@ spi-nor-objs                  += winbond.o
 spi-nor-objs                   += xilinx.o
 spi-nor-objs                   += xmc.o
 obj-$(CONFIG_MTD_SPI_NOR)      += spi-nor.o
+
+obj-$(CONFIG_MTD_SPI_NOR)      += controllers/
--

2.17.1

Reviewed-by on v1 1/1
#3 lore raw
In reply to Guenter Roeck
Quoted 8 lines · EEST Guenter Roeck

Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") moved various files into a new directory, but did not add the new directory to its parent directory Makefile. The moved files no longer build, and affected flash chips no longer instantiate.

Adding the new directory to the parent directory Makefile fixes the problem.

Quoted 7 lines
Fixes a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc Boris Brezillon <[email protected]>
Cc Tudor Ambarus <[email protected]>
---
 drivers/mtd/spi-nor/Makefile | 2 ++
 1 file changed, 2 insertions(+)

I missed that somehow, sorry. Thank you for the fix, Guenter!

#4 lore raw
Quoted 18 lines · On Mon, Apr 6, 2020 at 7:31 AM <[email protected]> wrote:
Quoted 8 lines · EEST Guenter Roeck

Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") moved various files into a new directory, but did not add the new directory to its parent directory Makefile. The moved files no longer build, and affected flash chips no longer instantiate.

Adding the new directory to the parent directory Makefile fixes the problem.

Quoted 7 lines
Fixes a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split")
Cc Boris Brezillon <[email protected]>
Cc Tudor Ambarus <[email protected]>
---
 drivers/mtd/spi-nor/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Quoted 3 lines

I missed that somehow, sorry. Thank you for the fix, Guenter!

Applied to mtd/fixes, thanks to everyone for addressing this.

Signature · 2 lines
Thanks,
//richard