um: delete an unnecessary check before the kfree
Subsystems (4)
PATCH 1/1 um: delete an unnecessary check before the kfree
NULL check before kfree is unnecessary so remove it.
This issue was detected by using the Coccinelle software.
Signed-off-by Qiujun Huang <[email protected]>
--- arch/um/drivers/vector_user.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
arch/um/drivers/vector_user.c +5 -10
@@ -221,8 +221,7 @@ static struct vector_fds *user_init_tap_fds(struct arglist *ifspec)return result; tap_cleanup:printk (UM_KERN_ERR "user_init_tap: init failed, error %d" , fd); -if (result !=NULL ) -kfree (result); +kfree (result);return NULL ; }
@@ -266,8 +265,7 @@ static struct vector_fds *user_init_hybrid_fds(struct arglist *ifspec)return result; hybrid_cleanup:printk (UM_KERN_ERR "user_init_hybrid: init failed" ); -if (result !=NULL ) -kfree (result); +kfree (result);return NULL ; }
@@ -344,10 +342,8 @@ static struct vector_fds *user_init_unix_fds(struct arglist *ifspec, int id) unix_cleanup:if (fd >=0 )os_close_file (fd); -if (remote_addr !=NULL ) -kfree (remote_addr); -if (result !=NULL ) -kfree (result); +kfree (remote_addr); +kfree (result);return NULL ; }
@@ -382,8 +378,7 @@ static struct vector_fds *user_init_raw_fds(struct arglist *ifspec)return result; raw_cleanup:printk (UM_KERN_ERR "user_init_raw: init failed, error %d" , err); -if (result !=NULL ) -kfree (result); +kfree (result);return NULL ; }
Signature · 7 lines
2.17.1 _______________________________________________ linux-um mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-um