Skip to contentSkip to conversation

package/kodi: remove optional libtheora support

PATCH New Bernd Kuhls 2 participants 2 messages Apr 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kodi: remove optional libtheora support

Kodi plays these files through ffmpeg and does not link to libtheora anymore, see PR 9686.

---
 Config.in.legacy       | 6 ++++++
 package/kodi/Config.in | 7 -------
 package/kodi/kodi.mk   | 4 ----
 3 files changed, 6 insertions(+), 11 deletions(-)
Config.in.legacy +6 -0
index 22f6a2778d..caf31d4be3 100644
@@ -146,6 +146,12 @@ endif
 
 comment "Legacy options removed in 2020.05"
 
+config BR2_PACKAGE_KODI_LIBTHEORA
+	bool "libtheora support in Kodi was removed"
+	select BR2_LEGACY
+	help
+	  Kodi does not need libtheora
+
 config BR2_PACKAGE_CEGUI06
 	bool "BR2_PACKAGE_CEGUI06 was renamed"
 	select BR2_PACKAGE_CEGUI
package/kodi/Config.in +0 -7
index 07128ac3c5..f5b37cf7d2 100644
@@ -251,13 +251,6 @@ config BR2_PACKAGE_KODI_LIBSMBCLIENT
 	help
 	  Enable Samba support
 
-config BR2_PACKAGE_KODI_LIBTHEORA
-	bool "theora"
-	select BR2_PACKAGE_LIBTHEORA
-	help
-	  Enable Theora input support.
-	  Select this if you want to play back OGG/OGV files (Video).
-
 config BR2_PACKAGE_KODI_LIBUSB
 	bool "usb"
 	# https://github.com/xbmc/xbmc/blob/Jarvis/configure.ac#L1554
package/kodi/kodi.mk +0 -4
index 71b6d44415..0c4704ea84 100644
@@ -315,10 +315,6 @@ ifeq ($(BR2_PACKAGE_LIRC_TOOLS),y)
 KODI_DEPENDENCIES += lirc-tools
 endif
 
-ifeq ($(BR2_PACKAGE_KODI_LIBTHEORA),y)
-KODI_DEPENDENCIES += libtheora
-endif
-
 # kodi needs libva & libva-glx
 ifeq ($(BR2_PACKAGE_KODI_LIBVA)$(BR2_PACKAGE_MESA3D_DRI_DRIVER),yy)
 KODI_DEPENDENCIES += mesa3d libva
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 package/kodi: remove optional libtheora support

Quoted 9 lines · On Sun, 5 Apr 2020 15:07:59 +0200 Bernd Kuhls <[email protected]> wrote:

Kodi plays these files through ffmpeg and does not link to libtheora anymore, see PR 9686.

---
 Config.in.legacy       | 6 ++++++
 package/kodi/Config.in | 7 -------
 package/kodi/kodi.mk   | 4 ----
 3 files changed, 6 insertions(+), 11 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com