Skip to contentSkip to conversation

systemd: Package systemd-hwdb-update.service into udev

PATCH In review Khem Raj 2 participants 2 messages Apr 6, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 systemd: Package systemd-hwdb-update.service into udev

Currently, this unit is packaged into udev-hwdb which then adds it as rdep instead of rrecommends to systemd itself, this meant that even if we added udev-hwdb to BAD_RECOMMENDATIONS, it would not be respected since its a rdep, therefore move the service unit file into udev package instead, this decouples the hard runtime dependency and restores the bad recommendations expectations

Cc Alex Kiernan <[email protected]>
Cc Otavio Salvador <[email protected]>
---
 meta/recipes-core/systemd/systemd_244.3.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/systemd/systemd_244.3.bb +2 -1
index a68597284e..341ac6bbc5 100644
@@ -628,14 +628,15 @@ FILES_udev += "${base_sbindir}/udevd \
                ${sysconfdir}/init.d/systemd-udevd \
                ${systemd_unitdir}/system/*udev* \
                ${systemd_unitdir}/system/*.wants/*udev* \
+               ${base_bindir}/systemd-hwdb \
                ${base_bindir}/udevadm \
                ${base_sbindir}/udevadm \
                ${libexecdir}/${MLPREFIX}udevadm \
                ${datadir}/bash-completion/completions/udevadm \
+               ${systemd_unitdir}/system/systemd-hwdb-update.service \
               "
 
 FILES_udev-hwdb = "${rootlibexecdir}/udev/hwdb.d \
-                   ${systemd_unitdir}/system/systemd-hwdb-update.service \
                    "
 
 RCONFLICTS_${PN} = "tiny-init ${@bb.utils.contains('PACKAGECONFIG', 'resolved', 'resolvconf', '', d)}"
Signature · 1 line
2.26.0
Tested-by on v1 1/1
#1 lore raw
Quoted 11 lines · Khem Raj

Currently, this unit is packaged into udev-hwdb which then adds it as rdep instead of rrecommends to systemd itself, this meant that even if we added udev-hwdb to BAD_RECOMMENDATIONS, it would not be respected since its a rdep, therefore move the service unit file into udev package instead, this decouples the hard runtime dependency and restores the bad recommendations expectations

Cc Alex Kiernan <[email protected]>
Cc Otavio Salvador <[email protected]>
Signature · 1 line
Alex Kiernan