s390/dasd: Kconfig patch
Subsystems (2)
cover s390/dasd: Kconfig patch
Hi Jens,
please see the following patch that fixes the DASD iosched Kconfig.
Regards,
Stefan
Krzysztof Kozlowski (1):
s390: Cleanup removed IOSCHED_DEADLINE
drivers/s390/block/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH 1/1 s390: Cleanup removed IOSCHED_DEADLINE
From: Krzysztof Kozlowski <[email protected]>
CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
remove legacy IO schedulers").
--- drivers/s390/block/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/s390/block/Kconfig +1 -1
@@ -26,7 +26,7 @@ config DASD def_tristate y prompt "Support for DASD devices" depends on CCW && BLOCK - select IOSCHED_DEADLINE + select MQ_IOSCHED_DEADLINE help Enable this option if you want to access DASDs directly utilizing S/390s channel subsystem commands. This is necessary for running
Signature · 1 line
2.17.1
Jens Axboe
maintainerRe: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
Quoted 4 lines · Stefan Haberland
From: Krzysztof Kozlowski <[email protected]>
CONFIG_IOSCHED_DEADLINEis gone since commitf382fb0bcef4("block:
remove legacy IO schedulers").
Isn't this a leftover thing from when dasd selected deadline internally? I don't think we need this anymore, just kill the select completely.
Signature · 1 line
Jens Axboe
Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
Am 06.04.20 um 17:32 schrieb Jens Axboe:
Quoted 9 lines · Stefan Haberland
Quoted 4 lines
From: Krzysztof Kozlowski <[email protected]>
CONFIG_IOSCHED_DEADLINEis gone since commitf382fb0bcef4("block:
remove legacy IO schedulers").Isn't this a leftover thing from when dasd selected deadline internally? I don't think we need this anymore, just kill the select completely.
Basically yes.
We still have the recommendation to use deadline and there are some udev rules in place which select it.
So I thought it might be a good idea to keep the line. But I am also fine to drop it completely if you prefer this.
Regards,
Stefan
Jens Axboe
maintainerRe: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
Quoted 11 lines · Stefan Haberland
Am 06.04.20 um 17:32 schrieb Jens Axboe:
Quoted 9 lines · Stefan Haberland
Quoted 4 lines
From: Krzysztof Kozlowski <[email protected]>
CONFIG_IOSCHED_DEADLINEis gone since commitf382fb0bcef4("block:
remove legacy IO schedulers").Isn't this a leftover thing from when dasd selected deadline internally? I don't think we need this anymore, just kill the select completely.
Quoted 5 lines
Basically yes.
We still have the recommendation to use deadline and there are some udev rules in place which select it.
So I thought it might be a good idea to keep the line. But I am also fine to drop it completely if you prefer this.
I don't feel super strongly about it, but at the same time I don't think there's a reason for it. Besides, I think everyone has deadline enabled. So I guess we should just kill it.
Signature · 1 line
Jens Axboe
Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
Am 07.04.20 um 21:24 schrieb Jens Axboe:
Quoted 11 lines · Stefan Haberland
Quoted 10 lines
Am 06.04.20 um 17:32 schrieb Jens Axboe:
Quoted 9 lines · Stefan Haberland
Quoted 4 lines
From: Krzysztof Kozlowski <[email protected]>
CONFIG_IOSCHED_DEADLINEis gone since commitf382fb0bcef4("block:
remove legacy IO schedulers").Isn't this a leftover thing from when dasd selected deadline internally? I don't think we need this anymore, just kill the select completely.
Quoted 9 lines
Quoted 5 lines
Basically yes.
We still have the recommendation to use deadline and there are some udev rules in place which select it.
So I thought it might be a good idea to keep the line. But I am also fine to drop it completely if you prefer this.I don't feel super strongly about it, but at the same time I don't think there's a reason for it. Besides, I think everyone has deadline enabled. So I guess we should just kill it.
OK, thanks for your opinion. I will remove the line and come up with a different patch.