Add support for Allwinner H6 DVFS
Subsystems (2)
v2 cover Add support for Allwinner H6 DVFS
Hi Sunxi maintainers and members,
Now that required drivers are merged we can contibute on DVFS support for Allwinner H6.
This serie is based on Yangtao Li serie[0] and Ondřej Jirman work[1].
Most of the OPP tables are taken from original vendor kernel[2]. Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
I wrote a simple script to randomly set a frequency during a random time[3].
With this script and using stress-ng during several hours, I didn't see any issue. Moreover I have tested specifically the 1.8GHz on my Beelink GS1, max thermal 85°C is reached very quickly and then the SoC oscillates quickly between 1.5 and 1.8GHz. So i have added 1.6GHz and 1.7GHz my board now oscillate slower between 1.5GHz and 1.6GHz swapping every second and temperature is also morestable.
I also test that that offlining CPU0 and doing DVFS on other CPUs works. As CPU regulator is only set for CPU0.
But maybe it doesn't cost much to set the regulator for all the CPUs?
Jernej test the GPU devfreq on several H6 board particulary the Tanix TX6 which doesn't have a proper dedicated PMIC and doesn't had any trouble with it.
Do you think I can enable GPU OPP for all H6 Boards?
Also Yangtao Li enable DVFS for Pine64, as I can't test it. I'm waiting for his ack or someone who has a Pine64 and can test this serie before reenabling this board.
Thanks,
Clément
0: https://patchwork.kernel.org/cover/10815117/
1: https://megous.com/git/linux/log/?h=ths-5.7
2: https://github.com/orangepi-xunlong/OrangePiH6_Linux4_9/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L345-L517
3: https://gist.github.com/clementperon/55a055dae3f13bbd14fb39c0069fe2e2
Changes since v1 (thanks to Ondřej Jirman):
- Remove Polling thermal
- Add Orange Pi boards
- Remove minimal voltage change for Beelink GS1
- Add ramp-deplay for GPU and CPU regulators
- Push to thermal point to 85°C (Allwinner set them to 100°C and 115°C)
- Added 1.6GHz and 1.7GHz to OPP table.
Clément Péron (4):
arm64: dts: allwinner: h6: Add GPU Operating Performance Points table
arm64: configs: Enable sun50i cpufreq nvmem
arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Beelink
GS1
arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Orange Pi
boards
Ondrej Jirman (2):
arm64: dts: allwinner: h6: Add thermal trip points/cooling map
arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
Yangtao Li (1):
arm64: dts: allwinner: h6: Add clock to CPU cores
.../dts/allwinner/sun50i-h6-beelink-gs1.dts | 10 +- .../boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 121 ++++++++++++++++++ .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++ .../dts/allwinner/sun50i-h6-orangepi.dtsi | 10 +- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 36 ++++++ arch/arm64/configs/defconfig | 1 + 6 files changed, 250 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi
Signature · 1 line
2.20.1
PATCH v2 1/7 arm64: dts: allwinner: h6: Add clock to CPU cores
From: Yangtao Li <[email protected]>
The ARM CPU cores are fed by the CPU clock from the CCU. Add a reference to the clock for each CPU core, along with the clock transition latency.
--- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +8 -0
@@ -25,6 +25,8 @@ device_type = "cpu"; reg = <0>; enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ }; cpu1: cpu@1 {
@@ -32,6 +34,8 @@ device_type = "cpu"; reg = <1>; enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ }; cpu2: cpu@2 {
@@ -39,6 +43,8 @@ device_type = "cpu"; reg = <2>; enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ }; cpu3: cpu@3 {
@@ -46,6 +52,8 @@ device_type = "cpu"; reg = <3>; enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ }; };
Signature · 1 line
2.20.1
PATCH v2 2/7 arm64: dts: allwinner: h6: Add thermal trip points/cooling map
In reply to Clément PéronFrom: Ondrej Jirman <[email protected]>
This enables passive cooling by down-regulating CPU voltage and frequency.
--- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 24 ++++++++++++++++++++ 1 file changed, 24 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +24 -0
@@ -908,6 +908,30 @@ polling-delay-passive = <0>; polling-delay = <0>; thermal-sensors = <&ths 0>; + + trips { + cpu_hot_trip: cpu-hot { + temperature = <85000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_very_hot_trip: cpu-very-hot { + temperature = <100000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling-maps { + cpu-hot-limit { + trip = <&cpu_hot_trip>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; }; gpu-thermal {
Signature · 1 line
2.20.1
PATCH v2 3/7 arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
In reply to Clément PéronFrom: Ondrej Jirman <[email protected]>
Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the H6.
--- .../boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 121 ++++++++++++++++++ arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 + 2 files changed, 125 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +121 -0
@@ -0,0 +1,121 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Ondrej Jirman <[email protected]> +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + cpu0_opp_table: opp_table0 { + compatible = "allwinner,sun50i-h6-operating-points"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp@480000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <480000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@720000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <720000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@816000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <816000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@888000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <888000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@1080000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1080000000>; + + opp-microvolt-speed0 = <940000>; + opp-microvolt-speed1 = <880000>; + opp-microvolt-speed2 = <880000>; + }; + + opp@1320000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1320000000>; + + opp-microvolt-speed0 = <1000000>; + opp-microvolt-speed1 = <940000>; + opp-microvolt-speed2 = <940000>; + }; + + opp@1488000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1488000000>; + + opp-microvolt-speed0 = <1060000>; + opp-microvolt-speed1 = <1000000>; + opp-microvolt-speed2 = <1000000>; + }; + + opp@1608000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1608000000>; + + opp-microvolt-speed0 = <1090000>; + opp-microvolt-speed1 = <1030000>; + opp-microvolt-speed2 = <1030000>; + }; + + opp@1704000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1704000000>; + + opp-microvolt-speed0 = <1120000>; + opp-microvolt-speed1 = <1060000>; + opp-microvolt-speed2 = <1060000>; + }; + + opp@1800000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1800000000>; + + opp-microvolt-speed0 = <1160000>; + opp-microvolt-speed1 = <1100000>; + opp-microvolt-speed2 = <1100000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +};
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +4 -0
@@ -253,6 +253,10 @@ #address-cells = <1>; #size-cells = <1>; + speedbin_efuse: speed@1c { + reg = <0x1c 0x4>; + }; + ths_calibration: thermal-sensor-calibration@14 { reg = <0x14 0x8>; };
Signature · 1 line
2.20.1
Re: [PATCH v2 3/7] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
Quoted 19 lines · Clément Péron
From: Ondrej Jirman <[email protected]>
Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the H6.
Signed-off-by Ondrej Jirman <[email protected]>Signed-off-by Clément Péron <[email protected]>--- .../boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 121 ++++++++++++++++++ arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 + 2 files changed, 125 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsiarch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +0
-0
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi line 6
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +6
-0@@ -0,0 +1,121 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Ondrej Jirman <[email protected]> +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + cpu0_opp_table: opp_table0 {
Node names shouldn't have an underscore, this will trigger a DTC warning.
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi line 18
Quoted 12 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +12
-0+ compatible = "allwinner,sun50i-h6-operating-points"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp@480000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <480000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + };
And similarly, if you have a unit-address (the part after @), you should have a matching reg property. You should use a dash instead.
Quoted 107 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +102
-0+ opp@720000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <720000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@816000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <816000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@888000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <888000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@1080000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1080000000>; + + opp-microvolt-speed0 = <940000>; + opp-microvolt-speed1 = <880000>; + opp-microvolt-speed2 = <880000>; + }; + + opp@1320000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1320000000>; + + opp-microvolt-speed0 = <1000000>; + opp-microvolt-speed1 = <940000>; + opp-microvolt-speed2 = <940000>; + }; + + opp@1488000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1488000000>; + + opp-microvolt-speed0 = <1060000>; + opp-microvolt-speed1 = <1000000>; + opp-microvolt-speed2 = <1000000>; + }; + + opp@1608000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1608000000>; + + opp-microvolt-speed0 = <1090000>; + opp-microvolt-speed1 = <1030000>; + opp-microvolt-speed2 = <1030000>; + }; + + opp@1704000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1704000000>; + + opp-microvolt-speed0 = <1120000>; + opp-microvolt-speed1 = <1060000>; + opp-microvolt-speed2 = <1060000>; + }; + + opp@1800000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1800000000>; + + opp-microvolt-speed0 = <1160000>; + opp-microvolt-speed1 = <1100000>; + opp-microvolt-speed2 = <1100000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +};arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 259
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +4
-0@@ -253,6 +253,10 @@ #address-cells = <1>; #size-cells = <1>; + speedbin_efuse: speed@1c { + reg = <0x1c 0x4>; + }; +
You should order this by address, so after the THS calibration. Also, using a less generic node name than "speed" would be great. What about soc-bin ?
Maxime
Re: [PATCH v2 3/7] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
Hi,
Quoted 157 lines · Maxime Ripard
Quoted 19 lines · Clément Péron
From: Ondrej Jirman <[email protected]>
Add an Operating Performance Points table for the CPU cores to enable Dynamic Voltage & Frequency Scaling on the H6.
Signed-off-by Ondrej Jirman <[email protected]>Signed-off-by Clément Péron <[email protected]>--- .../boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 121 ++++++++++++++++++ arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 + 2 files changed, 125 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsiarch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +0
-0arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi line 6
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +6
-0@@ -0,0 +1,121 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Ondrej Jirman <[email protected]> +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + cpu0_opp_table: opp_table0 {Node names shouldn't have an underscore, this will trigger a DTC warning.
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi line 18
Quoted 12 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +12
-0+ compatible = "allwinner,sun50i-h6-operating-points"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp@480000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <480000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + };And similarly, if you have a unit-address (the part after @), you should have a matching reg property. You should use a dash instead.
Quoted 110 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi new file +102
-0+ opp@720000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <720000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@816000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <816000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@888000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <888000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <820000>; + }; + + opp@1080000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1080000000>; + + opp-microvolt-speed0 = <940000>; + opp-microvolt-speed1 = <880000>; + opp-microvolt-speed2 = <880000>; + }; + + opp@1320000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1320000000>; + + opp-microvolt-speed0 = <1000000>; + opp-microvolt-speed1 = <940000>; + opp-microvolt-speed2 = <940000>; + }; + + opp@1488000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1488000000>; + + opp-microvolt-speed0 = <1060000>; + opp-microvolt-speed1 = <1000000>; + opp-microvolt-speed2 = <1000000>; + }; + + opp@1608000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1608000000>; + + opp-microvolt-speed0 = <1090000>; + opp-microvolt-speed1 = <1030000>; + opp-microvolt-speed2 = <1030000>; + }; + + opp@1704000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1704000000>; + + opp-microvolt-speed0 = <1120000>; + opp-microvolt-speed1 = <1060000>; + opp-microvolt-speed2 = <1060000>; + }; + + opp@1800000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1800000000>; + + opp-microvolt-speed0 = <1160000>; + opp-microvolt-speed1 = <1100000>; + opp-microvolt-speed2 = <1100000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; +};arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0@@ -253,6 +253,10 @@ #address-cells = <1>; #size-cells = <1>;
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 259
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +4
-0+ speedbin_efuse: speed@1c { + reg = <0x1c 0x4>; + }; +You should order this by address, so after the THS calibration. Also, using a less generic node name than "speed" would be great. What about soc-bin ?
Indeed it's too generic.
I will keep coherency with i.MX8 and use "cpu_speed_grade"
Thanks for the review,
Clement
Quoted 2 lines
Maxime
Re: [PATCH v2 3/7] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table
Quoted 15 lines · Clément Péron
Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0@@ -253,6 +253,10 @@ #address-cells = <1>; #size-cells = <1>;Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi line 259
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +4
-0+ speedbin_efuse: speed@1c { + reg = <0x1c 0x4>; + }; +You should order this by address, so after the THS calibration. Also, using a less generic node name than "speed" would be great. What about soc-bin ?
Quoted 2 lines
Indeed it's too generic.
I will keep coherency with i.MX8 and use "cpu_speed_grade"
It works for me, but remember that you can't use underscores :)
Maxime
PATCH v2 4/7 arm64: dts: allwinner: h6: Add GPU Operating Performance Points table
In reply to Clément PéronAdd an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6.
--- .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +74 -0
@@ -0,0 +1,74 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + gpu_opp_table: opp_table1 { + compatible = "operating-points-v2"; + + opp@756000000 { + opp-hz = /bits/ 64 <756000000>; + opp-microvolt = <1040000>; + }; + opp@624000000 { + opp-hz = /bits/ 64 <624000000>; + opp-microvolt = <950000>; + }; + opp@576000000 { + opp-hz = /bits/ 64 <576000000>; + opp-microvolt = <930000>; + }; + opp@540000000 { + opp-hz = /bits/ 64 <540000000>; + opp-microvolt = <910000>; + }; + opp@504000000 { + opp-hz = /bits/ 64 <504000000>; + opp-microvolt = <890000>; + }; + opp@456000000 { + opp-hz = /bits/ 64 <456000000>; + opp-microvolt = <870000>; + }; + opp@432000000 { + opp-hz = /bits/ 64 <432000000>; + opp-microvolt = <860000>; + }; + opp@420000000 { + opp-hz = /bits/ 64 <420000000>; + opp-microvolt = <850000>; + }; + opp@408000000 { + opp-hz = /bits/ 64 <408000000>; + opp-microvolt = <840000>; + }; + opp@384000000 { + opp-hz = /bits/ 64 <384000000>; + opp-microvolt = <830000>; + }; + opp@360000000 { + opp-hz = /bits/ 64 <360000000>; + opp-microvolt = <820000>; + }; + opp@336000000 { + opp-hz = /bits/ 64 <336000000>; + opp-microvolt = <810000>; + }; + opp@312000000 { + opp-hz = /bits/ 64 <312000000>; + opp-microvolt = <810000>; + }; + opp@264000000 { + opp-hz = /bits/ 64 <264000000>; + opp-microvolt = <810000>; + }; + opp@216000000 { + opp-hz = /bits/ 64 <216000000>; + opp-microvolt = <810000>; + }; + }; +}; + +&gpu { + operating-points-v2 = <&gpu_opp_table>; + #cooling-cells = <2>; +};
Signature · 1 line
2.20.1
Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table
Quoted 15 lines · Clément Péron
Add an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6.
Signed-off-by Clément Péron <[email protected]>--- .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsiarch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +0
-0
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi line 5
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +5
-0@@ -0,0 +1,74 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + gpu_opp_table: opp_table1 {
A node name is supposed to be a generic description, so what about using gpu-opp-table (and cpu-opp-table) instead?
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi line 15
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +10
-0+ compatible = "operating-points-v2"; + + opp@756000000 { + opp-hz = /bits/ 64 <756000000>; + opp-microvolt = <1040000>; + }; + opp@624000000 { + opp-hz = /bits/ 64 <624000000>; + opp-microvolt = <950000>; + };
Ordering by ascending frequency would be great here.
Also, why did you need to create a new DTSI for it? Is there some downside to enabling it for all the users?
Maxime
Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table
Hi Maxime,
Quoted 37 lines · Maxime Ripard
Quoted 15 lines · Clément Péron
Add an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6.
Signed-off-by Clément Péron <[email protected]>--- .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsiarch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +0
-0arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi line 5
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +5
-0@@ -0,0 +1,74 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright (C) 2020 Clément Péron <[email protected]> + +/ { + gpu_opp_table: opp_table1 {A node name is supposed to be a generic description, so what about using gpu-opp-table (and cpu-opp-table) instead?
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi line 15
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi new file +10
-0+ compatible = "operating-points-v2"; + + opp@756000000 { + opp-hz = /bits/ 64 <756000000>; + opp-microvolt = <1040000>; + }; + opp@624000000 { + opp-hz = /bits/ 64 <624000000>; + opp-microvolt = <950000>; + };
Quoted 1 line
Ordering by ascending frequency would be great here.
Indeed will fix it.
Quoted 3 lines
Also, why did you need to create a new DTSI for it? Is there some downside to enabling it for all the users?
I didn't want to enable it for all boards as I can't test them and not all board have a dedicated regulator for VDD-GPU.
Hence my question in the cover,
But with Jernej Škrabec test on Tanix TX6 I think it can be safely enable on all boards.
Regards,
Clement
Quoted 2 lines
Maxime
PATCH v2 5/7 arm64: configs: Enable sun50i cpufreq nvmem
In reply to Clément PéronAllwinner H6 needs this driver to be able to get
the correct speed_bin required for DVFS.
Enable this option in arm64 defconfig.
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -83,6 +83,7 @@ CONFIG_CPU_FREQ_GOV_CONSERVATIVE=m CONFIG_CPU_FREQ_GOV_SCHEDUTIL=y CONFIG_CPUFREQ_DT=y CONFIG_ACPI_CPPC_CPUFREQ=m +CONFIG_ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM=y CONFIG_ARM_ARMADA_37XX_CPUFREQ=y CONFIG_ARM_SCPI_CPUFREQ=y CONFIG_ARM_IMX_CPUFREQ_DT=m
Signature · 1 line
2.20.1
Re: [PATCH v2 5/7] arm64: configs: Enable sun50i cpufreq nvmem
Quoted 6 lines · Clément Péron
Allwinner H6 needs this driver to be able to get
the correctspeed_binrequired for DVFS.Enable this option in arm64 defconfig.
Signed-off-by Clément Péron <[email protected]>
In general, it's better to put anything in arm64 defconfig as a module, this defconfig is used by everyone.
Maxime
PATCH v2 6/7 arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Beelink GS1
In reply to Clément PéronEnable CPU and GPU opp tables for Beelink GS1.
This needs to change the CPU regulator max voltage to fit the OPP table.
Also add the ramp-delay information to avoid any out of spec running as the regulator is slower at reaching the voltage requested compare to the PLL reaching the frequency.
There is no such information for AXP805 but similar PMIC (AXP813) has a DVM (Dynamic Voltage scaling Management) ramp rate equal to 2500uV/us.
--- .../arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts +9 -1
@@ -4,6 +4,8 @@ /dts-v1/; #include "sun50i-h6.dtsi" +#include "sun50i-h6-cpu-opp.dtsi" +#include "sun50i-h6-gpu-opp.dtsi" #include <dt-bindings/gpio/gpio.h>
@@ -70,6 +72,10 @@ }; }; +&cpu0 { + cpu-supply = <®_dcdca>; +}; + &de { status = "okay"; };
@@ -227,7 +233,8 @@ reg_dcdca: dcdca { regulator-always-on; regulator-min-microvolt = <810000>; - regulator-max-microvolt = <1080000>; + regulator-max-microvolt = <1160000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-cpu"; };
@@ -235,6 +242,7 @@ regulator-enable-ramp-delay = <32000>; regulator-min-microvolt = <810000>; regulator-max-microvolt = <1080000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-gpu"; };
Signature · 1 line
2.20.1
PATCH v2 7/7 arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Orange Pi boards
In reply to Clément PéronEnable CPU and GPU opp tables for Orange Pi boards.
This needs to change the CPU regulator max voltage to fit the OPP table.
Also add the ramp-delay information to avoid any out of spec running as the regulator is slower at reaching the voltage requested compare to the PLL reaching the frequency.
There is no such information for AXP805 but similar PMIC (AXP813) has a DVM (Dynamic Voltage scaling Management) ramp rate equal to 2500uV/us.
--- arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi +9 -1
@@ -5,6 +5,8 @@ /dts-v1/; #include "sun50i-h6.dtsi" +#include "sun50i-h6-cpu-opp.dtsi" +#include "sun50i-h6-gpu-opp.dtsi" #include <dt-bindings/gpio/gpio.h>
@@ -45,6 +47,10 @@ }; }; +&cpu0 { + cpu-supply = <®_dcdca>; +}; + &ehci0 { status = "okay"; };
@@ -161,7 +167,8 @@ reg_dcdca: dcdca { regulator-always-on; regulator-min-microvolt = <810000>; - regulator-max-microvolt = <1080000>; + regulator-max-microvolt = <1160000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-cpu"; };
@@ -169,6 +176,7 @@ regulator-enable-ramp-delay = <32000>; regulator-min-microvolt = <810000>; regulator-max-microvolt = <1080000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-gpu"; };
Signature · 1 line
2.20.1
Re: [PATCH v2 7/7] arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Orange Pi boards
Hi,
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
Quoted 23 lines · Clément Péron
Enable CPU and GPU opp tables for Orange Pi boards.
This needs to change the CPU regulator max voltage to fit the OPP table.
Also add the ramp-delay information to avoid any out of spec running as the regulator is slower at reaching the voltage requested compare to the PLL reaching the frequency.
There is no such information for AXP805 but similar PMIC (AXP813) has a DVM (Dynamic Voltage scaling Management) ramp rate equal to 2500uV/us.
Signed-off-by Clément Péron <[email protected]>--- arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi +0
-0
Made a mistake here.
Ondrej Jirman test DVFS on Orange Pi 3 board which is not this device-tree file.
Will fix in V3.
Regards,
Clément
Quoted 41 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi +9
-2@@ -5,6 +5,8 @@ /dts-v1/; #include "sun50i-h6.dtsi" +#include "sun50i-h6-cpu-opp.dtsi" +#include "sun50i-h6-gpu-opp.dtsi" #include <dt-bindings/gpio/gpio.h>@@ -45,6 +47,10 @@ }; }; +&cpu0 { + cpu-supply = <®_dcdca>; +}; + &ehci0 { status = "okay"; };@@ -161,7 +167,8 @@ reg_dcdca: dcdca { regulator-always-on; regulator-min-microvolt = <810000>; - regulator-max-microvolt = <1080000>; + regulator-max-microvolt = <1160000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-cpu"; };@@ -169,6 +176,7 @@ regulator-enable-ramp-delay = <32000>; regulator-min-microvolt = <810000>; regulator-max-microvolt = <1080000>; + regulator-ramp-delay = <2500>; regulator-name = "vdd-gpu"; }; --2.20.1
Hi,
Quoted 10 lines · Clément Péron
Now that required drivers are merged we can contibute on DVFS support for Allwinner H6.
This serie is based on Yangtao Li serie[0] and Ondřej Jirman work[1].
Most of the OPP tables are taken from original vendor kernel[2]. Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
I wrote a simple script to randomly set a frequency during a random time[3].
If you ever need to do that ever again, cpufreq-ljt-stress-test (found here https://github.com/ssvb/cpuburn-arm) has proven to be very reliable to detect cpufreq related issues. stress-ng might not be enough since the (at least older) Allwinner SoCs tend to create cache corruption when undervolted, and that might not be unnoticed by stress-ng but will be catched by cpufreq-ljt-stress-test.
Also, it will test each frequency, while random frequencies might skip a few.
Quoted 10 lines
With this script and using stress-ng during several hours, I didn't see any issue. Moreover I have tested specifically the 1.8GHz on my Beelink GS1, max thermal 85°C is reached very quickly and then the SoC oscillates quickly between 1.5 and 1.8GHz. So i have added 1.6GHz and 1.7GHz my board now oscillate slower between 1.5GHz and 1.6GHz swapping every second and temperature is also morestable.
I also test that that offlining CPU0 and doing DVFS on other CPUs works. As CPU regulator is only set for CPU0.
Quoted 7 lines
But maybe it doesn't cost much to set the regulator for all the CPUs?
Jernej test the GPU devfreq on several H6 board particulary the Tanix TX6 which doesn't have a proper dedicated PMIC and doesn't had any trouble with it.
Do you think I can enable GPU OPP for all H6 Boards?
It seems you're doing it?
Maxime
Hi Maxime,
Quoted 15 lines · Maxime Ripard
Hi,
Quoted 10 lines · Clément Péron
Now that required drivers are merged we can contibute on DVFS support for Allwinner H6.
This serie is based on Yangtao Li serie[0] and Ondřej Jirman work[1].
Most of the OPP tables are taken from original vendor kernel[2]. Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
I wrote a simple script to randomly set a frequency during a random time[3].
Quoted 6 lines
If you ever need to do that ever again, cpufreq-ljt-stress-test (found here https://github.com/ssvb/cpuburn-arm) has proven to be very reliable to detect cpufreq related issues. stress-ng might not be enough since the (at least older) Allwinner SoCs tend to create cache corruption when undervolted, and that might not be unnoticed by stress-ng but will be catched by cpufreq-ljt-stress-test.
Thanks for the tool and explanation. I will test the v3 with this one.
Quoted 3 lines
Also, it will test each frequency, while random frequencies might skip a few.
I didn't count them but there was more than 2000lines, probability to miss a frequency is really low. Also changing from 500MHz to 1.8GHz could have trigger some out-of-spec issue.
But just to be sure I will add an init phase before doing random stuff.
Quoted 13 lines
Quoted 13 lines
With this script and using stress-ng during several hours, I didn't see any issue. Moreover I have tested specifically the 1.8GHz on my Beelink GS1, max thermal 85°C is reached very quickly and then the SoC oscillates quickly between 1.5 and 1.8GHz. So i have added 1.6GHz and 1.7GHz my board now oscillate slower between 1.5GHz and 1.6GHz swapping every second and temperature is also morestable.
I also test that that offlining CPU0 and doing DVFS on other CPUs works. As CPU regulator is only set for CPU0.
But maybe it doesn't cost much to set the regulator for all the CPUs?
Quoted 7 lines
Quoted 5 lines
Jernej test the GPU devfreq on several H6 board particulary the Tanix TX6 which doesn't have a proper dedicated PMIC and doesn't had any trouble with it.
Do you think I can enable GPU OPP for all H6 Boards?
It seems you're doing it?
No I don't, see my answer on patch 4/7.
Thanks for your review,
Clément
Quoted 2 lines
Maxime
Hi Maxime,
Quoted 25 lines · Clément Péron
Hi Maxime,
Quoted 21 lines · Maxime Ripard
Hi,
Quoted 10 lines · Clément Péron
Now that required drivers are merged we can contibute on DVFS support for Allwinner H6.
This serie is based on Yangtao Li serie[0] and Ondřej Jirman work[1].
Most of the OPP tables are taken from original vendor kernel[2]. Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
I wrote a simple script to randomly set a frequency during a random time[3].
If you ever need to do that ever again, cpufreq-ljt-stress-test (found here https://github.com/ssvb/cpuburn-arm) has proven to be very reliable to detect cpufreq related issues. stress-ng might not be enough since the (at least older) Allwinner SoCs tend to create cache corruption when undervolted, and that might not be unnoticed by stress-ng but will be catched by cpufreq-ljt-stress-test.
The test seems good (see result below) :
# cpufreq-ljt-stress-test Creating './whitenoise-1920x1080.jpg' ... done CPU stress test, which is doing JPEG decoding by libjpeg-turbo at different cpufreq operating points.
Testing CPU 0
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OK
Testing CPU 1
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OK
Testing CPU 2
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OK
Testing CPU 3
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OK
Overall result : PASSED
Quoted 40 lines
Thanks for the tool and explanation. I will test the v3 with this one.
Quoted 3 lines
Also, it will test each frequency, while random frequencies might skip a few.
I didn't count them but there was more than 2000lines, probability to miss a frequency is really low. Also changing from 500MHz to 1.8GHz could have trigger some out-of-spec issue.
But just to be sure I will add an init phase before doing random stuff.
Quoted 13 lines
Quoted 13 lines
With this script and using stress-ng during several hours, I didn't see any issue. Moreover I have tested specifically the 1.8GHz on my Beelink GS1, max thermal 85°C is reached very quickly and then the SoC oscillates quickly between 1.5 and 1.8GHz. So i have added 1.6GHz and 1.7GHz my board now oscillate slower between 1.5GHz and 1.6GHz swapping every second and temperature is also morestable.
I also test that that offlining CPU0 and doing DVFS on other CPUs works. As CPU regulator is only set for CPU0.
But maybe it doesn't cost much to set the regulator for all the CPUs?
Quoted 7 lines
Quoted 5 lines
Jernej test the GPU devfreq on several H6 board particulary the Tanix TX6 which doesn't have a proper dedicated PMIC and doesn't had any trouble with it.
Do you think I can enable GPU OPP for all H6 Boards?
It seems you're doing it?
No I don't, see my answer on patch 4/7.
Thanks for your review,
ClémentQuoted 2 lines
Maxime
Hi Clement,
Quoted 79 lines · Clément Péron
Quoted 16 lines · Clément Péron
Quoted 15 lines · Maxime Ripard
Hi,
Quoted 10 lines · Clément Péron
Now that required drivers are merged we can contibute on DVFS support for Allwinner H6.
This serie is based on Yangtao Li serie[0] and Ondřej Jirman work[1].
Most of the OPP tables are taken from original vendor kernel[2]. Plus there is a new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz.
I wrote a simple script to randomly set a frequency during a random time[3].
Quoted 6 lines
Quoted 6 lines
If you ever need to do that ever again, cpufreq-ljt-stress-test (found here https://github.com/ssvb/cpuburn-arm) has proven to be very reliable to detect cpufreq related issues. stress-ng might not be enough since the (at least older) Allwinner SoCs tend to create cache corruption when undervolted, and that might not be unnoticed by stress-ng but will be catched by cpufreq-ljt-stress-test.
The test seems good (see result below) :
# cpufreq-ljt-stress-test Creating './whitenoise-1920x1080.jpg' ... done CPU stress test, which is doing JPEG decoding by libjpeg-turbo at different cpufreq operating points.Testing CPU 0
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OKTesting CPU 1
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OKTesting CPU 2
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OKTesting CPU 3
1800 MHz ............................................................ OK 1704 MHz ............................................................ OK 1608 MHz ............................................................ OK 1488 MHz ............................................................ OK 1320 MHz ............................................................ OK 1080 MHz ............................................................ OK
888 MHz ............................................................ OK 816 MHz ............................................................ OK 720 MHz ............................................................ OK 480 MHz ............................................................ OK
Quoted 1 line
Overall result : PASSED
Awesome, thanks for taking the time to do it :)
Maxime
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel