Skip to contentSkip to conversation

Add EDAC support for Cadence ddr controller

PATCH Superseded Dhananjay Kangude 1 participant 3 messages Apr 6, 2020

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add EDAC support for Cadence ddr controller

These patches add new edac driver for Cadence ddr memory controller. Cadence controller detects single(CE) and double(UE) bit errors during memory operations(RMW). DDR controller raised the interrupt on detection of the ecc error event and fill the data into registers. Driver handle the interrupt event and notify edac subsystem about ecc errors.

Changes since v2:
=================
- Added minor fixes to YAML file
- Split ISR into two differnt functions
- Removed unused paramters
- Fixed indentation issues
- Improved code readabilty
- Checked return value for edac_get_dimm
- Modified quirks as a ip_features

Changes since v1:
=================
- Made predefined arrays as static

Fixes 201447a5db9b ("EDAC/Cadence:Add EDAC driver for cadence memory controller")

- Replace macro 'EDAC_DIMM_PTR' with newly introduce function
- Removed unused variable root

Dhananjay Kangude (2):
dt-bindings: edac: Add cadence ddr mc support EDAC/Cadence:Add EDAC driver for cadence memory controller

 .../devicetree/bindings/cdns,ddr-edac.yaml         |   47 ++
 drivers/edac/Kconfig                               |    8 +
 drivers/edac/cadence_edac.c                        |  641 ++++++++++++++++++++
 3 files changed, 696 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/cdns,ddr-edac.yaml
 create mode 100644 drivers/edac/cadence_edac.c
#1 lore raw

PATCH v2 1/2 dt-bindings: edac: Add cadence ddr mc support

Add documentation for cadence ddr memory controller EDAC DTS bindings

---
 .../devicetree/bindings/cdns,ddr-edac.yaml         |   47 ++++++++++++++++++++
 1 files changed, 47 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/cdns,ddr-edac.yaml
Documentation/devicetree/bindings/cdns,ddr-edac.yaml new file +47 -0
new file mode 100644
index 0000000..30ea757
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/edac/cdns,ddr-edac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cadence DDR IP with ECC support (EDAC)
+
+description:
+  This binding describes the Cadence DDR/LPDDR IP with ECC feature enabled
+  to detect and correct CE/UE errors.
+
+maintainers:
+  - Dhananjay Kangdue <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - cdns,ddr4-mc
+
+  reg:
+    minItems: 1
+    maxItems: 2
+    items:
+      - description:
+          Register block of DDR/LPDDR apb registers up to mapped area.
+          Mapped area contains the register set for memory controller,
+          phy and PI module register set doesn't part of this mapping.
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    edac: edac@fd100000 {
+        compatible = "cdns,ddr4-mc-edac";
+        reg = <0xfd100000 0x4000>;
+        interrupts = <0x00 0x01 0x04>;
+    };
+...
Signature · 1 line
1.7.1
#2 lore raw

PATCH v2 2/2 EDAC/Cadence:Add EDAC driver for cadence memory controller

In reply to Dhananjay Kangude

Added edac platform driver for Cadence DDR controller which notify the ecc events based on the single or double bit errors during memory operations.

---
 drivers/edac/Kconfig        |    8 +
 drivers/edac/cadence_edac.c |  641 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 649 insertions(+), 0 deletions(-)
 create mode 100644 drivers/edac/cadence_edac.c
drivers/edac/Kconfig +8 -0
index fe2eb89..d5bb399 100644
@@ -530,4 +530,12 @@ config EDAC_DMC520
 	  Support for error detection and correction on the
 	  SoCs with ARM DMC-520 DRAM controller.
 
+config EDAC_CADENCE
+	tristate "Candence DDR Memory Controller ECC"
+	depends on ARM
+	help
+	  Support for error detection and correction on the Cadence DDR
+	  memory controller. The driver reports correctable and uncorrectable
+	  memory errors.
+
 endif # EDAC
drivers/edac/cadence_edac.c new file +641 -0

641 lines not on this page · raw message

Signature · 1 line
1.7.1