vdpa: Signedness bugs in vdpasim_work()
Subsystems (2)
PATCH 1/2 vdpa: Signedness bugs in vdpasim_work()
The "read" and "write" variables need to be signed for the error handling to work.
--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/vdpa/vdpa_sim/vdpa_sim.c +2 -1
@@ -132,7 +132,8 @@ static void vdpasim_work(struct work_struct *work) vdpasim, work);struct vdpasim_virtqueue *txq = &vdpasim->vqs[1 ];struct vdpasim_virtqueue *rxq = &vdpasim->vqs[0 ]; -size_t read, write, total_write; +ssize_t read, write; +size_t total_write;int err;int pkts =0 ;
Signature · 1 line
2.25.1
PATCH 2/2 vdpa: Fix pointer math bug in vdpasim_get_config()
If "offset" is non-zero then we end up copying from beyond the end of the config because of pointer math. We can fix this by casting the struct to a u8 pointer.
---
Is it really worth letting people specify the offset?
drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vdpa/vdpa_sim/vdpa_sim.c +1 -1
@@ -509,7 +509,7 @@ static void vdpasim_get_config(struct vdpa_device *vdpa, unsigned int offset,struct vdpasim *vdpasim =vdpa_to_sim (vdpa);if (offset + len <sizeof (struct virtio_net_config )) -memcpy (buf, &vdpasim->config + offset, len); +memcpy (buf, (u8 *)&vdpasim->config + offset, len); } static void vdpasim_set_config(struct vdpa_device *vdpa, unsigned int offset,
Signature · 1 line
2.25.1
Re: [PATCH 2/2] vdpa: Fix pointer math bug in vdpasim_get_config()
Quoted 17 lines · Dan Carpenter
If "offset" is non-zero then we end up copying from beyond the end of the config because of pointer math. We can fix this by casting the struct to a u8 pointer.
Fixes 2c53d0f64c06 ("vdpasim: vDPA device simulator")Signed-off-by Dan Carpenter <[email protected]>---
Is it really worth letting people specify the offset?drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vdpa/vdpa_sim/vdpa_sim.c +0
-0
drivers/vdpa/vdpa_sim/vdpa_sim.c static void vdpasim_get_config(struct vdpa_device *vdpa, unsigned int offset, · line 515
Quoted 8 lines
drivers/vdpa/vdpa_sim/vdpa_sim.c +1
-1@@ -509,7 +509,7 @@ static void vdpasim_get_config(struct vdpa_device *vdpa, unsigned int offset,struct vdpasim *vdpasim =vdpa_to_sim (vdpa);if (offset + len <sizeof (struct virtio_net_config )) -memcpy (buf, &vdpasim->config + offset, len); +memcpy (buf, (u8 *)&vdpasim->config + offset, len); } static void vdpasim_set_config(struct vdpa_device *vdpa, unsigned int offset,
Quoted 14 lines · Dan Carpenter
The "read" and "write" variables need to be signed for the error handling to work.
Fixes 2c53d0f64c06 ("vdpasim: vDPA device simulator")Signed-off-by Dan Carpenter <[email protected]>--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/vdpa/vdpa_sim/vdpa_sim.c +0
-0
drivers/vdpa/vdpa_sim/vdpa_sim.c static void vdpasim_work(struct work_struct *work) · line 139
Quoted 9 lines
drivers/vdpa/vdpa_sim/vdpa_sim.c +2
-1@@ -132,7 +132,8 @@ static void vdpasim_work(struct work_struct *work) vdpasim, work);struct vdpasim_virtqueue *txq = &vdpasim->vqs[1 ];struct vdpasim_virtqueue *rxq = &vdpasim->vqs[0 ]; -size_t read, write, total_write; +ssize_t read, write; +size_t total_write;int err;int pkts =0 ;