Skip to contentSkip to conversation

Support ADIS16475 and similar IMUs

PATCH Superseded Nuno Sá 3 participants 16 messages Apr 6, 2020 – Apr 12, 2020

Subsystems (5)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Nuno Sá

author maintainer
#0 lore raw

v4 cover Support ADIS16475 and similar IMUs

This series adds support for the adis16475 and similar IMUs. This driver will be the first user of some changes on the adis library. Hence, the first three patches are related to the library:
* Add anaged device functions for registering triggers with the library;
* Updates the way irq_mask is passed to request_irq();
* It adds an update_bits() like API.

A new patch was introduced (iio: adis: Add burst_max_len variable) in order to make burst32 configuration at runtime.

Nuno Sá (6):
iio: imu: adis: Add Managed device functions
iio: imu: adis: Add irq mask variable
iio: adis: Add adis_update_bits() APIs
iio: adis: Support different burst sizes
iio: imu: Add support for adis16475
dt-bindings: iio: Add adis16475 documentation

 .../bindings/iio/imu/adi,adis16475.yaml       |  137 ++
 MAINTAINERS                                   |    8 +
 drivers/iio/imu/Kconfig                       |   13 +
 drivers/iio/imu/Makefile                      |    1 +
 drivers/iio/imu/adis.c                        |   25 +
 drivers/iio/imu/adis16400.c                   |    2 +-
 drivers/iio/imu/adis16475.c                   | 1333 +++++++++++++++++
 drivers/iio/imu/adis_buffer.c                 |   58 +-
 drivers/iio/imu/adis_trigger.c                |   72 +-
 include/linux/iio/imu/adis.h                  |   87 +-
 10 files changed, 1725 insertions(+), 11 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
 create mode 100644 drivers/iio/imu/adis16475.c
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH v4 1/6 iio: imu: adis: Add Managed device functions

This patch adds support for a managed device version of adis_setup_buffer_and_trigger. It works exactly as the original one but it calls all the devm_iio_* functions to setup an iio buffer and trigger. Hence we do not need to care about cleaning those and we do not need to support a remove() callback for every driver using the adis library.

---
Changes in v2:
* Added blank lines for readability.

Changes in V3:
* Removed unnecessary inline;
* Free buffer resources.

Changes in v4:
* Make use of irq_handler_t.

 drivers/iio/imu/adis_buffer.c  | 45 ++++++++++++++++++++++++++++++++++
 drivers/iio/imu/adis_trigger.c | 41 ++++++++++++++++++++++++++++---
 include/linux/iio/imu/adis.h   | 17 +++++++++++++
 3 files changed, 100 insertions(+), 3 deletions(-)
drivers/iio/imu/adis_buffer.c +45 -0
index 04e5e2a0fd6b..8fdc4dca10c0 100644
@@ -156,6 +156,14 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
 	return IRQ_HANDLED;
 }
 
+static void adis_buffer_cleanup(void *arg)
+{
+	struct adis *adis = arg;
+
+	kfree(adis->buffer);
+	kfree(adis->xfer);
+}
+
 /**
  * adis_setup_buffer_and_trigger() - Sets up buffer and trigger for the adis device
  * @adis: The adis device.
@@ -198,6 +206,43 @@ int adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
 }
 EXPORT_SYMBOL_GPL(adis_setup_buffer_and_trigger);
 
+/**
+ * devm_adis_setup_buffer_and_trigger() - Sets up buffer and trigger for
+ *					  the managed adis device
+ * @adis: The adis device
+ * @indio_dev: The IIO device
+ * @trigger_handler: Optional trigger handler, may be NULL.
+ *
+ * Returns 0 on success, a negative error code otherwise.
+ *
+ * This function perfoms exactly the same as adis_setup_buffer_and_trigger()
+ */
+int
+devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
+				   irq_handler_t trigger_handler)
+{
+	int ret;
+
+	if (!trigger_handler)
+		trigger_handler = adis_trigger_handler;
+
+	ret = devm_iio_triggered_buffer_setup(&adis->spi->dev, indio_dev,
+					      &iio_pollfunc_store_time,
+					      trigger_handler, NULL);
+	if (ret)
+		return ret;
+
+	if (adis->spi->irq) {
+		ret = devm_adis_probe_trigger(adis, indio_dev);
+		if (ret)
+			return ret;
+	}
+
+	return devm_add_action_or_reset(&adis->spi->dev, adis_buffer_cleanup,
+					adis);
+}
+EXPORT_SYMBOL_GPL(devm_adis_setup_buffer_and_trigger);
+
 /**
  * adis_cleanup_buffer_and_trigger() - Free buffer and trigger resources
  * @adis: The adis device.
drivers/iio/imu/adis_trigger.c +38 -3

59 lines not on this page · raw message

include/linux/iio/imu/adis.h +17 -0
index dd8219138c2e..e70814d96e1c 100644
@@ -448,11 +448,15 @@ struct adis_burst {
 	unsigned int	extra_len;
 };
 
+int
+devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
+				   irq_handler_t trigger_handler);
 int adis_setup_buffer_and_trigger(struct adis *adis,
 	struct iio_dev *indio_dev, irqreturn_t (*trigger_handler)(int, void *));
 void adis_cleanup_buffer_and_trigger(struct adis *adis,
 	struct iio_dev *indio_dev);
 
+int devm_adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev);
 int adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev);
 void adis_remove_trigger(struct adis *adis);
 
@@ -461,6 +465,13 @@ int adis_update_scan_mode(struct iio_dev *indio_dev,
 
 #else /* CONFIG_IIO_BUFFER */
 
+static inline int
+devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
+				   irq_handler_t trigger_handler)
+{
+	return 0;
+}
+
 static inline int adis_setup_buffer_and_trigger(struct adis *adis,
 	struct iio_dev *indio_dev, irqreturn_t (*trigger_handler)(int, void *))
 {
@@ -472,6 +483,12 @@ static inline void adis_cleanup_buffer_and_trigger(struct adis *adis,
 {
 }
 
+static inline int devm_adis_probe_trigger(struct adis *adis,
+					  struct iio_dev *indio_dev)
+{
+	return 0;
+}
+
 static inline int adis_probe_trigger(struct adis *adis,
 	struct iio_dev *indio_dev)
 {
Signature · 1 line
2.17.1
author maintainer
#2 lore raw

PATCH v4 2/6 iio: imu: adis: Add irq mask variable

In reply to Nuno Sá

There are some ADIS devices that can configure the data ready pin polarity. Hence, we cannot hardcode our IRQ mask as IRQF_TRIGGER_RISING since we might want to have it as IRQF_TRIGGER_FALLING.

---
Changes in v2:
* Add kernel doc-string for irq-mask.

Changes in v3:
* Removed unnecessary inline;
* Renamed __adis_validate_irq_mask to adis_validate_irq_mask to keep lib consistency;
* Cosmetics in logs.

Changes in v4:
* Use flag suffix instead of mask;
* Add comments to adis_validate_irq_flag.

 drivers/iio/imu/adis_trigger.c | 33 +++++++++++++++++++++++++++++++--
 include/linux/iio/imu/adis.h   |  2 ++
 2 files changed, 33 insertions(+), 2 deletions(-)
drivers/iio/imu/adis_trigger.c +31 -2
index a36810e0b1ab..8afe71947c00 100644
@@ -34,6 +34,27 @@ static void adis_trigger_setup(struct adis *adis)
 	iio_trigger_set_drvdata(adis->trig, adis);
 }
 
+static int adis_validate_irq_flag(struct adis *adis)
+{
+	/*
+	 * Typically this devices have data ready either on the rising edge or
+	 * on the falling edge of the data ready pin. This checks enforces that
+	 * one of those is set in the drivers... It defaults to
+	 * IRQF_TRIGGER_RISING for backward compatibility wiht devices that
+	 * don't support changing the pin polarity.
+	 */
+	if (!adis->irq_flag) {
+		adis->irq_flag = IRQF_TRIGGER_RISING;
+		return 0;
+	} else if (adis->irq_flag != IRQF_TRIGGER_RISING &&
+		   adis->irq_flag != IRQF_TRIGGER_FALLING) {
+		dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n",
+			adis->irq_flag);
+		return -EINVAL;
+	}
+
+	return 0;
+}
 /**
  * adis_probe_trigger() - Sets up trigger for a adis device
  * @adis: The adis device
@@ -54,9 +75,13 @@ int adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev)
 
 	adis_trigger_setup(adis);
 
+	ret = adis_validate_irq_flag(adis);
+	if (ret)
+		return ret;
+
 	ret = request_irq(adis->spi->irq,
 			  &iio_trigger_generic_data_rdy_poll,
-			  IRQF_TRIGGER_RISING,
+			  adis->irq_flag,
 			  indio_dev->name,
 			  adis->trig);
 	if (ret)
@@ -96,9 +121,13 @@ int devm_adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev)
 
 	adis_trigger_setup(adis);
 
+	ret = adis_validate_irq_flag(adis);
+	if (ret)
+		return ret;
+
 	ret = devm_request_irq(&adis->spi->dev, adis->spi->irq,
 			       &iio_trigger_generic_data_rdy_poll,
-			       IRQF_TRIGGER_RISING,
+			       adis->irq_flag,
 			       indio_dev->name,
 			       adis->trig);
 	if (ret)
include/linux/iio/imu/adis.h +2 -0
index e70814d96e1c..70e4d1d262f5 100644
@@ -87,6 +87,7 @@ struct adis_data {
  * @msg: SPI message object
  * @xfer: SPI transfer objects to be used for a @msg
  * @current_page: Some ADIS devices have registers, this selects current page
+ * @irq_flag: IRQ handling flags as passed to request_irq()
  * @buffer: Data buffer for information read from the device
  * @tx: DMA safe TX buffer for SPI transfers
  * @rx: DMA safe RX buffer for SPI transfers
@@ -113,6 +114,7 @@ struct adis {
 	struct spi_message	msg;
 	struct spi_transfer	*xfer;
 	unsigned int		current_page;
+	unsigned long		irq_flag;
 	void			*buffer;
 
 	uint8_t			tx[10] ____cacheline_aligned;
Signature · 1 line
2.17.1
author maintainer
#3 lore raw

PATCH v4 3/6 iio: adis: Add adis_update_bits() APIs

In reply to Nuno Sá

This patch adds a regmap_update_bits() like API to the ADIS library. It provides locked and unlocked variant.

---
Changes in v2:
* Add BUILD_BUG_ON() to avoid invalid types.

Changes in V3:
* Nothing changed.

Changes in v4:
* Use one liner for updating the bits.

 drivers/iio/imu/adis.c       | 25 +++++++++++++++
 include/linux/iio/imu/adis.h | 59 ++++++++++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
drivers/iio/imu/adis.c +25 -0
index a8afd01de4f3..df8adbfda10d 100644
@@ -223,6 +223,31 @@ int __adis_read_reg(struct adis *adis, unsigned int reg,
 	return ret;
 }
 EXPORT_SYMBOL_GPL(__adis_read_reg);
+/**
+ * __adis_update_bits_base() - ADIS Update bits function - Unlocked version
+ * @adis: The adis device
+ * @reg: The address of the lower of the two registers
+ * @mask: Bitmask to change
+ * @val: Value to be written
+ * @size: Size of the register to update
+ *
+ * Updates the desired bits of @reg in accordance with @mask and @val.
+ */
+int __adis_update_bits_base(struct adis *adis, unsigned int reg, const u32 mask,
+			    const u32 val, u8 size)
+{
+	int ret;
+	u32 __val;
+
+	ret = __adis_read_reg(adis, reg, &__val, size);
+	if (ret)
+		return ret;
+
+	__val = (__val & ~mask) | (val & mask);
+
+	return __adis_write_reg(adis, reg, __val, size);
+}
+EXPORT_SYMBOL_GPL(__adis_update_bits_base);
 
 #ifdef CONFIG_DEBUG_FS
 
include/linux/iio/imu/adis.h +59 -0

65 lines not on this page · raw message

Signature · 1 line
2.17.1
author maintainer
#4 lore raw

PATCH v4 4/6 iio: adis: Support different burst sizes

In reply to Nuno Sá

Add burst_max_len to adis_burst. This is useful for devices which support different burst modes with different sizes. The buffer to be used in the spi transfer is allocated with this variable making sure that has space for all burst modes. The spi transfer length should hold the "real" burst length depending on the current burst mode configured in the device.

Moreover, extra_len in adis_burst is made const and it should contain the smallest extra length necessary for a burst transfer. In struct adis was added a new burst_extra_len that should hold the extra bytes needed depending on the device instance being used.

---
Changes in v2:
* Nothing changed.

Changes in v3:
* Reworked commit message;
* Made extra_len const;
* Added burst_extra_len to struct adis;
* Changed adis16400 accordingly.

Changes in v4:
* Nothing changed.

 drivers/iio/imu/adis16400.c   |  2 +-
 drivers/iio/imu/adis_buffer.c | 13 +++++++++----
 include/linux/iio/imu/adis.h  |  9 +++++++--
 3 files changed, 17 insertions(+), 7 deletions(-)
drivers/iio/imu/adis16400.c +1 -1
index 4445c242709c..439feb755d82 100644
@@ -1195,7 +1195,7 @@ static int adis16400_probe(struct spi_device *spi)
 		indio_dev->available_scan_masks = st->avail_scan_mask;
 		st->adis.burst = &adis16400_burst;
 		if (st->variant->flags & ADIS16400_BURST_DIAG_STAT)
-			st->adis.burst->extra_len = sizeof(u16);
+			st->adis.burst_extra_len = sizeof(u16);
 	}
 
 	adis16400_data = &st->variant->adis_data;
drivers/iio/imu/adis_buffer.c +9 -4
index 8fdc4dca10c0..5b4225ee09b9 100644
@@ -23,25 +23,30 @@ static int adis_update_scan_mode_burst(struct iio_dev *indio_dev,
 	const unsigned long *scan_mask)
 {
 	struct adis *adis = iio_device_get_drvdata(indio_dev);
-	unsigned int burst_length;
+	unsigned int burst_length, burst_max_length;
 	u8 *tx;
 
 	/* All but the timestamp channel */
 	burst_length = (indio_dev->num_channels - 1) * sizeof(u16);
-	burst_length += adis->burst->extra_len;
+	burst_length += adis->burst->extra_len + adis->burst_extra_len;
+
+	if (adis->burst->burst_max_len)
+		burst_max_length = adis->burst->burst_max_len;
+	else
+		burst_max_length = burst_length;
 
 	adis->xfer = kcalloc(2, sizeof(*adis->xfer), GFP_KERNEL);
 	if (!adis->xfer)
 		return -ENOMEM;
 
-	adis->buffer = kzalloc(burst_length + sizeof(u16), GFP_KERNEL);
+	adis->buffer = kzalloc(burst_max_length + sizeof(u16), GFP_KERNEL);
 	if (!adis->buffer) {
 		kfree(adis->xfer);
 		adis->xfer = NULL;
 		return -ENOMEM;
 	}
 
-	tx = adis->buffer + burst_length;
+	tx = adis->buffer + burst_max_length;
 	tx[0] = ADIS_READ_REG(adis->burst->reg_cmd);
 	tx[1] = 0;
 
include/linux/iio/imu/adis.h +7 -2
index 247fc4c7185c..2df67448f0d1 100644
@@ -83,6 +83,8 @@ struct adis_data {
  * @trig: IIO trigger object data
  * @data: ADIS chip variant specific data
  * @burst: ADIS burst transfer information
+ * @burst_extra_len: Burst extra length. Should only be used by devices that can
+ *		     dynamically change their burst mode length.
  * @state_lock: Lock used by the device to protect state
  * @msg: SPI message object
  * @xfer: SPI transfer objects to be used for a @msg
@@ -98,7 +100,7 @@ struct adis {
 
 	const struct adis_data	*data;
 	struct adis_burst	*burst;
-
+	unsigned int		burst_extra_len;
 	/**
 	 * The state_lock is meant to be used during operations that require
 	 * a sequence of SPI R/W in order to protect the SPI transfer
@@ -502,11 +504,14 @@ int adis_single_conversion(struct iio_dev *indio_dev,
  * @en			burst mode enabled
  * @reg_cmd		register command that triggers burst
  * @extra_len		extra length to account in the SPI RX buffer
+ * @burst_max_len	holds the maximum burst size when the device supports
+ *			more than one burst mode with different sizes
  */
 struct adis_burst {
 	bool		en;
 	unsigned int	reg_cmd;
-	unsigned int	extra_len;
+	const u32	extra_len;
+	const u32	burst_max_len;
 };
 
 int
Signature · 1 line
2.17.1
author maintainer
#5 lore raw

PATCH v4 5/6 iio: imu: Add support for adis16475

In reply to Nuno Sá

Support ADIS16475 and similar IMU devices. These devices are a precision, miniature MEMS inertial measurement unit (IMU) that includes a triaxial gyroscope and a triaxial accelerometer. Each inertial sensor combines with signal conditioning that optimizes dynamic performance.

The driver adds support for the following devices:
* adis16470, adis16475, adis16477, adis16465, adis16467, adis16500, adis16505, adis16507.

---
Changes in v2:
* Remove burst mode config (enabled by default);
* Fix timestamp channel index;
* Do return code checks inline in adis16475_read_raw;
* Increase buffer size to fit aligned timestamp;
* Remove spi_device_id table;
* Rename adis16475_clks to adis16475_sync;
* Rename adis16475_config_ext_clk adis16475_config_sync_mode;
* Fix output-sync mode. There's no need to call clk_get in this mode as
it acts as an output pin;
* Fix scaled-mode configuration. Up scale was not being written on the right register;
* Handle burst32 configuration at runtime. When the decimation or the FIR filter is enabled
the LSB bits are meangninfull. Hence, use burst32 in that case (if the part supports it);
* When there's no burst32 mode and the LSB data is meangninfull, read it manually...
* Do not push data to buffers if crc is invalid.

Changes in V3:
* Fix multiple instance devices for different burst sizes;
* Only return error if freq is 0 on `adis16475_set_freq``;
* Fixed typo in comment;
* Do not allow 7 to be set in adis16475_set_filter;
* Change adis16475_validate_crc return type to bool;
* Return 1 if crc is valid instead of 0.

Changes in v4:
* Remove unused file from MAINTAINERS;
* Remove <asm/unaligned.h>;
* Use irq_flag - Changed in 2 patch;
* Use DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe;
* No need to return in adis16475_debugfs_init;
* Drop parentheses in (crc == 0);
* Remove unnecessary casts;
* Directly pass data to iio_push_to_buffers_with_timestamp;
* Remove all get_unaligned calls;
* Better indent macros with inside macros;
* Use assign_bit();
* Drop ret < 0 checks;
* Use device_get_match_data();
* Replace linux/of_device.h by <linux/mod_devicetable.h>and <linux/property.h>;
* Remove invalid index in adis16475_3db_freqs;
* Make the loop in adis16475_set_filter more readable.

 MAINTAINERS                 |    7 +
 drivers/iio/imu/Kconfig     |   13 +
 drivers/iio/imu/Makefile    |    1 +
 drivers/iio/imu/adis16475.c | 1333 +++++++++++++++++++++++++++++++++++
 4 files changed, 1354 insertions(+)
 create mode 100644 drivers/iio/imu/adis16475.c
MAINTAINERS +7 -0
index 8687cc5397c8..a2ff8322c184 100644
@@ -1009,6 +1009,13 @@ W:	http://ez.analog.com/community/linux-device-drivers
 F:	drivers/iio/imu/adis16460.c
 F:	Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
 
+ANALOG DEVICES INC ADIS16475 DRIVER
+M:	Nuno Sa <[email protected]>
+L:	[email protected]
+W:	http://ez.analog.com/community/linux-device-drivers
+S:	Supported
+F:	drivers/iio/imu/adis16475.c
+
 ANALOG DEVICES INC ADM1177 DRIVER
 M:	Beniamin Bia <[email protected]>
 M:	Michael Hennerich <[email protected]>
drivers/iio/imu/Kconfig +13 -0
index 60bb1029e759..fc4123d518bc 100644
@@ -29,6 +29,19 @@ config ADIS16460
 	  To compile this driver as a module, choose M here: the module will be
 	  called adis16460.
 
+config ADIS16475
+	tristate "Analog Devices ADIS16475 and similar IMU driver"
+	depends on SPI
+	select IIO_ADIS_LIB
+	select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
+	help
+	  Say yes here to build support for Analog Devices ADIS16470, ADIS16475,
+	  ADIS16477, ADIS16465, ADIS16467, ADIS16500, ADIS16505, ADIS16507 inertial
+	  sensors.
+
+	  To compile this driver as a module, choose M here: the module will be
+	  called adis16475.
+
 config ADIS16480
 	tristate "Analog Devices ADIS16480 and similar IMU driver"
 	depends on SPI
drivers/iio/imu/Makefile +1 -0
index 5237fd4bc384..88b2c4555230 100644
@@ -6,6 +6,7 @@
 # When adding new entries keep the list in alphabetical order
 obj-$(CONFIG_ADIS16400) += adis16400.o
 obj-$(CONFIG_ADIS16460) += adis16460.o
+obj-$(CONFIG_ADIS16475) += adis16475.o
 obj-$(CONFIG_ADIS16480) += adis16480.o
 
 adis_lib-y += adis.o
drivers/iio/imu/adis16475.c new file +1333 -0

1,333 lines not on this page · raw message

Signature · 1 line
2.17.1
#6 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 10 lines · Nuno Sá

Support ADIS16475 and similar IMU devices. These devices are a precision, miniature MEMS inertial measurement unit (IMU) that includes a triaxial gyroscope and a triaxial accelerometer. Each inertial sensor combines with signal conditioning that optimizes dynamic performance.

The driver adds support for the following devices:
* adis16470, adis16475, adis16477, adis16465, adis16467, adis16500, adis16505, adis16507.

...

drivers/iio/imu/adis16475.c line 329

Quoted 6 lines
drivers/iio/imu/adis16475.c new file +5 -0
+       int i = ARRAY_SIZE(adis16475_3db_freqs);
+       int ret;
 
+       while (--i)
+               if (adis16475_3db_freqs[i] >= filter)
+                       break;

Nit: perhaps {} to add.

...

Quoted 13 lines
drivers/iio/imu/adis16475.c new file +13 -0
+enum adis16475_variant {
+       ADIS16470,
+       ADIS16475_1,
+       ADIS16475_2,
+       ADIS16475_3,
+       ADIS16477_1,
+       ADIS16477_2,
+       ADIS16477_3,
+       ADIS16465_1,
+       ADIS16465_2,
+       ADIS16465_3,
+       ADIS16467_1,
+       ADIS16467_2,

drivers/iio/imu/adis16475.c line 510

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +9 -0
+       ADIS16467_3,
+       ADIS16500,
+       ADIS16505_1,
+       ADIS16505_2,
+       ADIS16505_3,
+       ADIS16507_1,
+       ADIS16507_2,
+       ADIS16507_3,
 
+

Extra blank line.

Quoted 1 line

+};

...

Quoted 7 lines
drivers/iio/imu/adis16475.c new file +7 -0
+static void adis16475_burst32_check(struct adis16475 *st)
+{
+       int ret;
+       struct adis *adis = &st->adis;
+
+       if (!st->info->has_burst32)
+               return;

drivers/iio/imu/adis16475.c line 958

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+
+       if (st->lsb_flag && !st->burst32) {
+               const u16 en = ADIS16500_BURST32(1);
+
+               ret = __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
+                                        ADIS16500_BURST32_MASK, en);
+               if (ret)
+                       return;
+
+               st->burst32 = true;

+ Blank line.

Review

Quoted 2 lines
(quoted diff) +2 -0
+               /*
+                * In 32bit mode we need extra 2 bytes for all gyro

32-bit

Quoted 6 lines
drivers/iio/imu/adis16475.c new file +6 -0
+                * and accel channels.
+                */
+               adis->burst_extra_len = 6 * sizeof(u16);
+               adis->xfer[1].len += 6 * sizeof(u16);
+               dev_dbg(&adis->spi->dev, "Enable burst32 mode, xfer:%d",
+                       adis->xfer[1].len);

drivers/iio/imu/adis16475.c line 976

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+
+       } else if (!st->lsb_flag && st->burst32) {
+               const u16 en = ADIS16500_BURST32(0);
+
+               ret = __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
+                                        ADIS16500_BURST32_MASK, en);
+               if (ret)
+                       return;
+
+               st->burst32 = false;

+ Blank line

Quoted 7 lines
drivers/iio/imu/adis16475.c new file +7 -0
+               /* Remove the extra bits */
+               adis->burst_extra_len = 0;
+               adis->xfer[1].len -= 6 * sizeof(u16);
+               dev_dbg(&adis->spi->dev, "Disable burst32 mode, xfer:%d\n",
+                       adis->xfer[1].len);
+       }
+}

...

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

drivers/iio/imu/adis16475.c line 1046

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +4 -0
+                               if (st->lsb_flag && !st->info->has_burst32) {
+                                       u16 val = 0;
 
+                                       const u32 reg = ADIS16475_REG_X_GYRO_L +
+                                               (bit * 4);

Redundant parentheses.

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+                                       adis_read_reg_16(adis, reg, &val);
+                                       data[i++] = cpu_to_be16(val);
+                               } else {
+                                       /* lower not used */
+                                       data[i++] = 0;
+                               }
+                       }
+                       break;
+               }
+       }

...

Quoted 7 lines
drivers/iio/imu/adis16475.c new file +7 -0
+               if (sync->sync_mode == ADIS16475_SYNC_SCALED) {
+                       u16 up_scale;
+                       u32 scaled_out_freq = 0;
+                       /*
+                        * If we are in scaled mode, we must have an up_scale.
+                        * In scaled mode the allowable input clock range is
+                        * 1 Hz to 128 Hz, and the allowable output range is

drivers/iio/imu/adis16475.c line 1139

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+                        * 1900 to 2100 Hz. Hence, a scale must be given to
+                        * get the allowable output.
+                        */
+                       device_property_read_u32(dev, "adi,scaled-output-hz",
+                                                &scaled_out_freq);
+
+                       if (scaled_out_freq < 1900 || scaled_out_freq > 2100) {
+                               dev_err(dev,
+                                       "Invalid value:%u for adi,scaled-output-hz",
+                                       scaled_out_freq);

When there is no property or property has a value 0 this message can't tell the difference.
Perhaps you have to check return code from device_property_read_u32() call.

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +3 -0
+                               return -EINVAL;
+                       }
 
+               }

...

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +5 -0
+       /*
+        * It is possible to configure the data ready polarity. Furthermore, we
+        * need to update the adis struct if we want data ready as active low.
+        */
+       irq_type = irqd_get_trigger_type(desc);

drivers/iio/imu/adis16475.c line 1203

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+       if (irq_type == IRQF_TRIGGER_RISING) {
+               polarity = 1;
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x specified\n",
+                       irq_type);
+               return -EINVAL;
+       }

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

--
With Best Regards,
Andy Shevchenko

author maintainer
#7 lore raw

RE: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 26 lines

From: Andy Shevchenko <[email protected]>
Sent: Montag, 6. April 2020 18:20
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 10 lines · Nuno Sá

Support ADIS16475 and similar IMU devices. These devices are a precision, miniature MEMS inertial measurement unit (IMU) that includes a triaxial gyroscope and a triaxial accelerometer. Each inertial sensor combines with signal conditioning that optimizes dynamic performance.

The driver adds support for the following devices:
* adis16470, adis16475, adis16477, adis16465, adis16467, adis16500, adis16505, adis16507.

...

Quoted 9 lines

drivers/iio/imu/adis16475.c line 329

Quoted 6 lines
drivers/iio/imu/adis16475.c new file +5 -0
+       int i = ARRAY_SIZE(adis16475_3db_freqs);
+       int ret;
 
+       while (--i)
+               if (adis16475_3db_freqs[i] >= filter)
+                       break;

Nit: perhaps {} to add.

Actually thought about that and removed them in the last minute. Will add them again...

Quoted 24 lines

...

Quoted 21 lines
drivers/iio/imu/adis16475.c new file +21 -0
+enum adis16475_variant {
+       ADIS16470,
+       ADIS16475_1,
+       ADIS16475_2,
+       ADIS16475_3,
+       ADIS16477_1,
+       ADIS16477_2,
+       ADIS16477_3,
+       ADIS16465_1,
+       ADIS16465_2,
+       ADIS16465_3,
+       ADIS16467_1,
+       ADIS16467_2,
+       ADIS16467_3,
+       ADIS16500,
+       ADIS16505_1,
+       ADIS16505_2,
+       ADIS16505_3,
+       ADIS16507_1,
+       ADIS16507_2,
+       ADIS16507_3,
Quoted 4 lines
Quoted 1 line

+

Extra blank line.

ack

Quoted 15 lines
Quoted 1 line

+};

...

Quoted 11 lines
drivers/iio/imu/adis16475.c new file +11 -0
+static void adis16475_burst32_check(struct adis16475 *st)
+{
+       int ret;
+       struct adis *adis = &st->adis;
+
+       if (!st->info->has_burst32)
+               return;
+
+       if (st->lsb_flag && !st->burst32) {
+               const u16 en = ADIS16500_BURST32(1);
+
Quoted 9 lines

drivers/iio/imu/adis16475.c line 958

Quoted 6 lines
drivers/iio/imu/adis16475.c new file +6 -0
+               ret = __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
+                                        ADIS16500_BURST32_MASK, en);
+               if (ret)
+                       return;
+
+               st->burst32 = true;

+ Blank line.

Can add it. For some reason I like to save blank lines when the next lines are comments...

Quoted 32 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+               /*
+                * In 32bit mode we need extra 2 bytes for all gyro

32-bit

Quoted 6 lines
drivers/iio/imu/adis16475.c new file +6 -0
+                * and accel channels.
+                */
+               adis->burst_extra_len = 6 * sizeof(u16);
+               adis->xfer[1].len += 6 * sizeof(u16);
+               dev_dbg(&adis->spi->dev, "Enable burst32 mode, xfer:%d",
+                       adis->xfer[1].len);

drivers/iio/imu/adis16475.c line 976

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+
+       } else if (!st->lsb_flag && st->burst32) {
+               const u16 en = ADIS16500_BURST32(0);
+
+               ret = __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
+                                        ADIS16500_BURST32_MASK, en);
+               if (ret)
+                       return;
+
+               st->burst32 = false;

+ Blank line

drivers/iio/imu/adis16475.c line 983

Quoted 7 lines
drivers/iio/imu/adis16475.c new file +7 -0
+               /* Remove the extra bits */
+               adis->burst_extra_len = 0;
+               adis->xfer[1].len -= 6 * sizeof(u16);
+               dev_dbg(&adis->spi->dev, "Disable burst32 mode, xfer:%d\n",
+                       adis->xfer[1].len);
+       }
+}
Quoted 7 lines

...

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

It goes beyond 80 col limit... I know I could initialize these to some local const but...

Quoted 8 lines

drivers/iio/imu/adis16475.c line 1046

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +4 -0
+                               if (st->lsb_flag && !st->info->has_burst32) {
+                                       u16 val = 0;
 
+                                       const u32 reg = ADIS16475_REG_X_GYRO_L +
+                                               (bit * 4);

Redundant parentheses.

Definitely...

Quoted 31 lines
Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+                                       adis_read_reg_16(adis, reg, &val);
+                                       data[i++] = cpu_to_be16(val);
+                               } else {
+                                       /* lower not used */
+                                       data[i++] = 0;
+                               }
+                       }
+                       break;
+               }
+       }

...

Quoted 7 lines
drivers/iio/imu/adis16475.c new file +7 -0
+               if (sync->sync_mode == ADIS16475_SYNC_SCALED) {
+                       u16 up_scale;
+                       u32 scaled_out_freq = 0;
+                       /*
+                        * If we are in scaled mode, we must have an up_scale.
+                        * In scaled mode the allowable input clock range is
+                        * 1 Hz to 128 Hz, and the allowable output range is

drivers/iio/imu/adis16475.c line 1139

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+                        * 1900 to 2100 Hz. Hence, a scale must be given to
+                        * get the allowable output.
+                        */
+                       device_property_read_u32(dev, "adi,scaled-output-hz",
+                                                &scaled_out_freq);
+
+                       if (scaled_out_freq < 1900 || scaled_out_freq > 2100) {
+                               dev_err(dev,
+                                       "Invalid value:%u for adi,scaled-output-hz",
+                                       scaled_out_freq);
Quoted 5 lines

When there is no property or property has a value 0 this message can't tell the difference.
Perhaps you have to check return code from device_property_read_u32() call.

Well, I think we don't really need to. If the sync mode is scaled, then this property is mandatory (and this is stated in the bindings). So, I don't really care if the property is not there or if it's just a wrong value. We should fail either way and I'm not sure an extra if with some other message will give us that extra value...

Quoted 23 lines
Quoted 4 lines
drivers/iio/imu/adis16475.c new file +3 -0
+                               return -EINVAL;
+                       }
 
+               }

...

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +5 -0
+       /*
+        * It is possible to configure the data ready polarity. Furthermore, we
+        * need to update the adis struct if we want data ready as active low.
+        */
+       irq_type = irqd_get_trigger_type(desc);

drivers/iio/imu/adis16475.c line 1203

Quoted 10 lines
drivers/iio/imu/adis16475.c new file +10 -0
+       if (irq_type == IRQF_TRIGGER_RISING) {
+               polarity = 1;
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x specified\n",
+                       irq_type);
+               return -EINVAL;
+       }
Quoted 4 lines

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

Hmm, thanks! Honestly, this was copy paste from adis16480 and I never realized this. I will use IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING. I guess we need a patch changing this in adis16480...

Thanks,
- Nuno Sá

Quoted 3 lines

--
With Best Regards,
Andy Shevchenko

#8 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 13 lines · Nuno
Quoted 13 lines

From: Andy Shevchenko <[email protected]>
Sent: Montag, 6. April 2020 18:20
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

On Mon, Apr 6, 2020 at 6:10 PM Nuno Sá <[email protected]> wrote:

...

Quoted 7 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

It goes beyond 80 col limit... I know I could initialize these to some local const but...

That's why question mark is there.
Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway.

JFYI: readability has a priority over 80 limit.

Quoted 1 line
Quoted 1 line
Quoted 1 line

+ }

...

Quoted 11 lines
Quoted 10 lines

drivers/iio/imu/adis16475.c line 1139

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +4 -0
+                       if (scaled_out_freq < 1900 || scaled_out_freq > 2100) {
+                               dev_err(dev,
+                                       "Invalid value:%u for adi,scaled-output-hz",
+                                       scaled_out_freq);

When there is no property or property has a value 0 this message can't tell the difference.
Perhaps you have to check return code from device_property_read_u32() call.

Quoted 4 lines

Well, I think we don't really need to. If the sync mode is scaled, then this property is mandatory (and this is stated in the bindings). So, I don't really care if the property is not there or if it's just a wrong value. We should fail either way and I'm not sure an extra if with some other message will give us that extra value...

Up to maintainer (I have no strong opinion about this)

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(quoted diff) +2 -0
+                               return -EINVAL;
+                       }

...

Quoted 8 lines
Quoted 8 lines

drivers/iio/imu/adis16475.c line 1195

Quoted 8 lines
drivers/iio/imu/adis16475.c new file +7 -0
+       /*
+        * It is possible to configure the data ready polarity. Furthermore, we
+        * need to update the adis struct if we want data ready as active low.
+        */
+       irq_type = irqd_get_trigger_type(desc);
+       if (irq_type == IRQF_TRIGGER_RISING) {
 
+               polarity = 1;

For the sake of consistency I would assign irq_flag here as well.

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
drivers/iio/imu/adis16475.c new file +8 -0
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x specified\n",
+                       irq_type);
+               return -EINVAL;
+       }
Quoted 8 lines
Quoted 4 lines

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

Hmm, thanks! Honestly, this was copy paste from adis16480 and I never realized this. I will use IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING. I guess we need a patch changing this in adis16480...

As a separate patch, yes.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#9 lore raw

RE: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 36 lines

From: Andy Shevchenko <[email protected]>
Sent: Dienstag, 7. April 2020 11:19
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 7 lines · Nuno
Quoted 7 lines

From: Andy Shevchenko <[email protected]>
Sent: Montag, 6. April 2020 18:20
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>;

Rob

Quoted 6 lines
Quoted 6 lines

Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

On Mon, Apr 6, 2020 at 6:10 PM Nuno Sá <[email protected]> wrote:

...

Quoted 6 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

Quoted 8 lines
Quoted 1 line

It goes beyond 80 col limit... I know I could initialize these to some local

const but...

That's why question mark is there.
Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway.

JFYI: readability has a priority over 80 limit.

Thanks! I would say it also depends on the maintainer (not sure)? Some are more strict about checkpatch...
Btw, the line will have 84 if one liner...

Quoted 35 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

+ }

...

Quoted 8 lines
Quoted 8 lines

drivers/iio/imu/adis16475.c line 1139

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +4 -0
+                       if (scaled_out_freq < 1900 || scaled_out_freq > 2100) {
+                               dev_err(dev,
+                                       "Invalid value:%u for adi,scaled-output-hz",
+                                       scaled_out_freq);

When there is no property or property has a value 0 this message can't tell the difference.
Perhaps you have to check return code from

device_property_read_u32()

Quoted 4 lines
Quoted 2 lines

call.

Well, I think we don't really need to. If the sync mode is scaled, then this

property is mandatory

Quoted 1 line

(and this is stated in the bindings). So, I don't really care if the property is

not there or if it's just

Quoted 1 line

a wrong value. We should fail either way and I'm not sure an extra if with

some other message will

Quoted 1 line

give us that extra value...

Up to maintainer (I have no strong opinion about this)

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(quoted diff) +2 -0
+                               return -EINVAL;
+                       }

...

Quoted 2 lines
Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+       /*
+        * It is possible to configure the data ready polarity. Furthermore,

we

Quoted 1 line
Quoted 1 line
Quoted 1 line

+ * need to update the adis struct if we want data ready as active

Quoted 9 lines

low.

Quoted 5 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c line 1195

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +4 -0
+        */
+       irq_type = irqd_get_trigger_type(desc);
+       if (irq_type == IRQF_TRIGGER_RISING) {
 
+               polarity = 1;

For the sake of consistency I would assign irq_flag here as well.

The library will do it by default, But that's me using "inside" info... or maybe if I document that in patch 2 (the struct kernel docs) we would not really need to assign it here?

Quoted 14 lines
Quoted 14 lines
Quoted 13 lines

drivers/iio/imu/adis16475.c line 1203

Quoted 8 lines
drivers/iio/imu/adis16475.c new file +8 -0
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x specified\n",
+                       irq_type);
+               return -EINVAL;
+       }

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

Quoted 7 lines
Quoted 1 line

Hmm, thanks! Honestly, this was copy paste from adis16480 and I never

realized this. I will

Quoted 1 line

use IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING. I guess we

need a patch changing this

Quoted 1 line

in adis16480...

As a separate patch, yes.

Sure...

Thanks!
- Nuno Sá

Quoted 3 lines

--
With Best Regards,
Andy Shevchenko

#10 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 12 lines · Nuno
Quoted 12 lines

From: Andy Shevchenko <[email protected]>
Sent: Dienstag, 7. April 2020 11:19
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

...

Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

It goes beyond 80 col limit... I know I could initialize these to some local

const but...

That's why question mark is there.
Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway.

Quoted 6 lines
Quoted 2 lines

JFYI: readability has a priority over 80 limit.

Thanks! I would say it also depends on the maintainer (not sure)? Some are more strict about checkpatch...
Btw, the line will have 84 if one liner...

Let's leave it to maintainer then.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+ }

...

Quoted 11 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

drivers/iio/imu/adis16475.c line 1195

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +3 -0
+       irq_type = irqd_get_trigger_type(desc);
+       if (irq_type == IRQF_TRIGGER_RISING) {
 
+               polarity = 1;

For the sake of consistency I would assign irq_flag here as well.

The library will do it by default, But that's me using "inside" info... or maybe if I document that in patch 2 (the struct kernel docs) we would not really need to assign it here?

I see now. From my point of view the library here does an ill turn because it hides some details which driver needs to do anyway. I prefer explicit over implicit at least here.

I would say okay, if there is no such code (like below) would be present in the driver.

Quoted 17 lines
Quoted 17 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
drivers/iio/imu/adis16475.c new file +8 -0
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x specified\n",
+                       irq_type);
+               return -EINVAL;
+       }
Quoted 6 lines
Quoted 4 lines

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

Hmm, thanks! Honestly, this was copy paste from adis16480 and I never

realized this. I will

Quoted 1 line

use IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#11 lore raw

RE: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 66 lines

From: [email protected] <[email protected]> On Behalf Of Andy Shevchenko
Sent: Dienstag, 7. April 2020 11:55
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 8 lines · Nuno
Quoted 8 lines

From: Andy Shevchenko <[email protected]>
Sent: Dienstag, 7. April 2020 11:19
To: Sa, Nuno <[email protected]>
Cc: linux-iio <[email protected]>; devicetree <[email protected]>; Jonathan Cameron <[email protected]>; Hartmut Knaack <[email protected]>; Lars-Peter Clausen <[email protected]>; Peter Meerwald-Stadler <[email protected]>;

Rob

Quoted 4 lines
Quoted 4 lines

Herring <[email protected]>; Mark Rutland <[email protected]>; Ardelean, Alexandru <[email protected]>; Hennerich, Michael <[email protected]>
Subject: Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

...

Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c line 1016

Quoted 2 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {

One line?

It goes beyond 80 col limit... I know I could initialize these to some local

const but...

That's why question mark is there.
Nonetheless, if it ~2-3 characters more, I would leave it on one line

anyway.

Quoted 5 lines
Quoted 3 lines

JFYI: readability has a priority over 80 limit.

Thanks! I would say it also depends on the maintainer (not sure)? Some are

more

Quoted 2 lines

strict about checkpatch...
Btw, the line will have 84 if one liner...

Let's leave it to maintainer then.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+ }

...

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines

drivers/iio/imu/adis16475.c line 1195

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +3 -0
+       irq_type = irqd_get_trigger_type(desc);
+       if (irq_type == IRQF_TRIGGER_RISING) {
 
+               polarity = 1;

For the sake of consistency I would assign irq_flag here as well.

The library will do it by default, But that's me using "inside" info... or maybe

Quoted 9 lines

if

Quoted 1 line

I document that in patch 2 (the struct kernel docs) we would not really

need to

Quoted 1 line

assign it here?

I see now. From my point of view the library here does an ill turn because it hides some details which driver needs to do anyway. I prefer explicit over implicit at least here.

Let's explicitly assign the irq_flag then...

Quoted 2 lines

I would say okay, if there is no such code (like below) would be present in the driver.

Now that I think about, this is actually code that, probably, could go inside the library since this is pretty standard for this kind of devices. Anyways, that's another story...

- Nuno Sá

Quoted 22 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

drivers/iio/imu/adis16475.c

Quoted 5 lines
drivers/iio/imu/adis16475.c new file +5 -0
+       } else if (irq_type == IRQF_TRIGGER_FALLING) {
+               polarity = 0;
+               st->adis.irq_flag = IRQF_TRIGGER_FALLING;
+       } else {
+               dev_err(&spi->dev, "Invalid interrupt type 0x%x

specified\n",

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
drivers/iio/imu/adis16475.c new file +3 -0
+                       irq_type);
+               return -EINVAL;
+       }
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Here is the problem. You got type, but you compare it to flags. It's not correct.
Although values are the same, the meaning is different.

Hmm, thanks! Honestly, this was copy paste from adis16480 and I never

realized this. I will

Quoted 1 line

use IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING.

--
With Best Regards,
Andy Shevchenko

#12 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

Quoted 16 lines · Nuno
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

+ irq_type = irqd_get_trigger_type(desc);

For the sake of consistency I would assign irq_flag here as well.

The library will do it by default, But that's me using "inside" info... or maybe

Quoted 9 lines

if

Quoted 1 line

I document that in patch 2 (the struct kernel docs) we would not really

need to

Quoted 1 line

assign it here?

I see now. From my point of view the library here does an ill turn because it hides some details which driver needs to do anyway. I prefer explicit over implicit at least here.

Quoted 8 lines

Let's explicitly assign the irq_flag then...

Quoted 2 lines

I would say okay, if there is no such code (like below) would be present in the driver.

Now that I think about, this is actually code that, probably, could go inside the library since this is pretty standard for this kind of devices. Anyways, that's another story...

It would be awesome if you can do that!
Yes, it probably will require a separate series.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#13 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

In reply to Andy Shevchenko
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 9 lines
Quoted 7 lines

drivers/iio/imu/adis16475.c line 1016

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +2 -0
+       for_each_set_bit(bit, indio_dev->active_scan_mask,
+                        indio_dev->masklength) {  

One line?

It goes beyond 80 col limit... I know I could initialize these to some local

const but...

That's why question mark is there.
Nonetheless, if it ~2-3 characters more, I would leave it on one line anyway.

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

JFYI: readability has a priority over 80 limit.

Thanks! I would say it also depends on the maintainer (not sure)? Some are more strict about checkpatch...
Btw, the line will have 84 if one liner...

Let's leave it to maintainer then.

I care very little either way :) In this case I'd argue that not being annoyed by checkpatch is worth the ever so slightly uglier 2 line option but find it hard to get worked up about it.

maintainer
#14 lore raw

Re: [PATCH v4 5/6] iio: imu: Add support for adis16475

In reply to Andy Shevchenko
Quoted 15 lines

...

Quoted 11 lines
Quoted 10 lines

drivers/iio/imu/adis16475.c line 1139

Quoted 4 lines
drivers/iio/imu/adis16475.c new file +4 -0
+                       if (scaled_out_freq < 1900 || scaled_out_freq > 2100) {
+                               dev_err(dev,
+                                       "Invalid value:%u for adi,scaled-output-hz",
+                                       scaled_out_freq);  

When there is no property or property has a value 0 this message can't tell the difference.
Perhaps you have to check return code from device_property_read_u32() call.

Quoted 6 lines
Quoted 4 lines

Well, I think we don't really need to. If the sync mode is scaled, then this property is mandatory (and this is stated in the bindings). So, I don't really care if the property is not there or if it's just a wrong value. We should fail either way and I'm not sure an extra if with some other message will give us that extra value...

Up to maintainer (I have no strong opinion about this)

Nice to give a hint to the user about the two different cases so I'd check the return value as Andy first suggested.

author maintainer
#15 lore raw

PATCH v4 6/6 dt-bindings: iio: Add adis16475 documentation

In reply to Nuno Sá

Document the ADIS16475 device devicetree bindings

---
Changes in v2:
* Remove burst32 property;
* Rename clk-mode to adi,sync-mode;
* Remove clock-names;
* Add conditionals to state that clocks is only needed depending on adi,sync-mode property.

Changes in v3:
* Make use of 'allOf' in conditionals.

Changes in v4:
* Nothing changed.

 .../bindings/iio/imu/adi,adis16475.yaml       | 137 ++++++++++++++++++
 MAINTAINERS                                   |   1 +
 2 files changed, 138 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml new file +137 -0
new file mode 100644
index 000000000000..98baecb4b98a
@@ -0,0 +1,137 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/imu/adi,adis16475.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices ADIS16475 and similar IMUs
+
+maintainers:
+  - Nuno Sá <[email protected]>
+
+description: |
+  Analog Devices ADIS16475 and similar IMUs
+  https://www.analog.com/media/en/technical-documentation/data-sheets/ADIS16475.pdf
+
+properties:
+  compatible:
+    enum:
+      - adi,adis16475-1
+      - adi,adis16475-2
+      - adi,adis16475-3
+      - adi,adis16477-1
+      - adi,adis16477-2
+      - adi,adis16477-3
+      - adi,adis16470
+      - adi,adis16465-1
+      - adi,adis16465-2
+      - adi,adis16465-3
+      - adi,adis16467-1
+      - adi,adis16467-2
+      - adi,adis16467-3
+      - adi,adis16500
+      - adi,adis16505-1
+      - adi,adis16505-2
+      - adi,adis16505-3
+      - adi,adis16507-1
+      - adi,adis16507-2
+      - adi,adis16507-3
+
+  reg:
+    maxItems: 1
+
+  spi-cpha: true
+
+  spi-cpol: true
+
+  spi-max-frequency:
+    maximum: 2000000
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Must be the device tree identifier of the RESET pin. If specified,
+      it will be asserted during driver probe. As the line is active low,
+      it should be marked GPIO_ACTIVE_LOW.
+    maxItems: 1
+
+  adi,sync-mode:
+    description:
+      Configures the device SYNC pin. The following modes are supported
+      0 - output_sync
+      1 - direct_sync
+      2 - scaled_sync
+      3 - pulse_sync
+    allOf:
+      - $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 3
+
+  adi,scaled-output-hz:
+    description:
+      This property must be present if the clock mode is scaled-sync through
+      clock-names property. In this mode, the input clock can have a range
+      of 1Hz to 128HZ which must be scaled to originate an allowable sample
+      rate. This property specifies that rate.
+    minimum: 1900
+    maximum: 2100
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - spi-cpha
+  - spi-cpol
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - adi,adis16500
+              - adi,adis16505-1
+              - adi,adis16505-2
+              - adi,adis16505-3
+              - adi,adis16507-1
+              - adi,adis16507-2
+              - adi,adis16507-3
+
+    then:
+      properties:
+        adi,sync-mode:
+          minimum: 0
+          maximum: 2
+
+  - if:
+      properties:
+        adi,sync-mode:
+          enum: [1, 2, 3]
+
+    then:
+      dependencies:
+        adi,sync-mode: [ clocks ]
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            adis16475: adis16475-3@0 {
+                    compatible = "adi,adis16475-3";
+                    reg = <0>;
+                    spi-cpha;
+                    spi-cpol;
+                    spi-max-frequency = <2000000>;
+                    interrupts = <4 IRQ_TYPE_EDGE_RISING>;
+                    interrupt-parent = <&gpio>;
+            };
+    };
+...
MAINTAINERS +1 -0
index a2ff8322c184..0828302accd8 100644
@@ -1015,6 +1015,7 @@ L:	[email protected]
 W:	http://ez.analog.com/community/linux-device-drivers
 S:	Supported
 F:	drivers/iio/imu/adis16475.c
+F:	Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
 
 ANALOG DEVICES INC ADM1177 DRIVER
 M:	Beniamin Bia <[email protected]>
Signature · 1 line
2.17.1