Skip to contentSkip to conversation

package/libclc: disable ccache

PATCH New aduskett at gmail.com 3 participants 3 messages Apr 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libclc: disable ccache

From: Adam Duskett <[email protected]>

Configure.py extracts arch, vendor, and os from the passed toolchain string on line 180. When using ccache, the passed path string is "/usr/lib64/ccache/g++" which breaks the logic, causing the following error:

Traceback (most recent call last):
File "./configure.py", line 180, in <module>

    (t_arch, t_vendor, t_os) = target.split('-')

ValueError: not enough values to unpack (expected 3, got 1)

Use --with-cxx-compiler=$(HOSTCXX_NOCCACHE) instead of $(HOSTCXX) to fix the above error.

---
 package/libclc/libclc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libclc/libclc.mk +1 -1
index 52249a7087..630616905c 100644
@@ -25,7 +25,7 @@ LIBCLC_CONF_OPTS = \
 	--prefix=/usr \
 	--includedir=/usr/share \
 	--pkgconfigdir=/usr/lib/pkgconfig \
-	--with-cxx-compiler=$(HOSTCXX)
+	--with-cxx-compiler=$(HOSTCXX_NOCCACHE)
 
 define LIBCLC_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.py $(LIBCLC_CONF_OPTS))
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/libclc: disable ccache

Hi Adam, All,

Le 06/04/2020 ? 18:50, aduskett at gmail.com a ?crit?:

Quoted 24 lines

From: Adam Duskett <[email protected]>

Configure.py extracts arch, vendor, and os from the passed toolchain string on line 180. When using ccache, the passed path string is "/usr/lib64/ccache/g++" which breaks the logic, causing the following error:

Traceback (most recent call last):
File "./configure.py", line 180, in <module>

    (t_arch, t_vendor, t_os) = target.split('-')

ValueError: not enough values to unpack (expected 3, got 1)

Use --with-cxx-compiler=$(HOSTCXX_NOCCACHE) instead of $(HOSTCXX) to fix the above error.

---
 package/libclc/libclc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libclc/libclc.mk +0 -0
index 52249a7087..630616905c 100644

package/libclc/libclc.mk LIBCLC_CONF_OPTS = \ · line 28

Quoted 5 lines
package/libclc/libclc.mk +1 -1
@@ -25,7 +25,7 @@ LIBCLC_CONF_OPTS = \
 	--prefix=/usr \
 	--includedir=/usr/share \
 	--pkgconfigdir=/usr/lib/pkgconfig \
-	--with-cxx-compiler=$(HOSTCXX)
+	--with-cxx-compiler=$(HOSTCXX_NOCCACHE)

I don't use ccache while testing...

Best regards,
Romain

Quoted 4 lines
package/libclc/libclc.mk +0 -0
 define LIBCLC_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.py $(LIBCLC_CONF_OPTS))
 
#2 lore raw

PATCH 1/1 package/libclc: disable ccache

In reply to aduskett at gmail.com

Adam, Romain, All,

On 2020-04-06 09:50 -0700, aduskett at gmail.com spake thusly:

Quoted 6 lines

From: Adam Duskett <[email protected]>

Configure.py extracts arch, vendor, and os from the passed toolchain string on line 180. When using ccache, the passed path string is "/usr/lib64/ccache/g++" which breaks the logic, causing the following error:

Quoted 7 lines

Traceback (most recent call last):
File "./configure.py", line 180, in <module>

    (t_arch, t_vendor, t_os) = target.split('-')

ValueError: not enough values to unpack (expected 3, got 1)

Use --with-cxx-compiler=$(HOSTCXX_NOCCACHE) instead of $(HOSTCXX) to fix the above error.

This is very unfortunate. :-(

But I can see that libclc does have a CMakeList.txt. Can't we make it a cmake paclage? Presumably, that is supposed to work better than this hand-crafted atrocity of configure.py... Care to have a look?

In the meantime, I've applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/libclc/libclc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libclc/libclc.mk +1 -1
index 52249a7087..630616905c 100644
@@ -25,7 +25,7 @@ LIBCLC_CONF_OPTS = \
 	--prefix=/usr \
 	--includedir=/usr/share \
 	--pkgconfigdir=/usr/lib/pkgconfig \
-	--with-cxx-compiler=$(HOSTCXX)
+	--with-cxx-compiler=$(HOSTCXX_NOCCACHE)
 
 define LIBCLC_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.py $(LIBCLC_CONF_OPTS))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'