package/mesa3d: Select more options for freedreno
PATCH 1/1 package/mesa3d: Select more options for freedreno
Currently it is not possible to select KMSCUBE on a target that uses BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO due to the missing dependency.
Fix this problem by selecting BR2_PACKAGE_LIBDRM_FREEDRENO and BR2_PACKAGE_MESA3D_OPENGL_EGL, just like Etnaviv does.
--- package/mesa3d/Config.in | 2 ++ 1 file changed, 2 insertions(+)
package/mesa3d/Config.in +2 -0
@@ -113,7 +113,9 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO bool "Gallium freedreno driver" select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER + select BR2_PACKAGE_LIBDRM_FREEDRENO select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO + select BR2_PACKAGE_MESA3D_OPENGL_EGL help Mesa driver for Freedreno GPUs.
Signature · 1 line
2.17.1
PATCH 1/1 package/mesa3d: Select more options for freedreno
Quoted 17 lines · On Mon, 30 Mar 2020 20:11:14 -0300 Fabio Estevam <[email protected]> wrote:
Currently it is not possible to select KMSCUBE on a target that uses
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENOdue to the missing dependency.Fix this problem by selecting
BR2_PACKAGE_LIBDRM_FREEDRENOandBR2_PACKAGE_MESA3D_OPENGL_EGL, just like Etnaviv does.Signed-off-by Fabio Estevam <[email protected]>--- package/mesa3d/Config.in | 2 ++ 1 file changed, 2 insertions(+)package/mesa3d/Config.in +0
-0
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV · line 116
Quoted 4 lines
package/mesa3d/Config.in +1
-0@@ -113,7 +113,9 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO bool "Gallium freedreno driver" select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER + select BR2_PACKAGE_LIBDRM_FREEDRENO
So I kind of agree with this one, because the mesa3d freedreno driver is not usable without the libdrm support for this platform. However, this is not really explained in your commit log.
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV · line 118
Quoted 2 lines
package/mesa3d/Config.in +1
-0select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO + select BR2_PACKAGE_MESA3D_OPENGL_EGL
However, this one I disagree, and I also disagree for it on etnaviv. Indeed, even with this, you still can't enable kmscube, which requires EGL *and* OpenGL ES, but you're not forcefully enabling OpenGL ES. And I don't think it makes sense to forcefully enable EGL and OpenGL ES.
So, what I'd prefer to see is:
- A patch that drops the select BR2_PACKAGE_MESA3D_OPENGL_EGL from the etnaviv mesa3d option.
- A patch that adds just the select BR2_PACKAGE_LIBDRM_FREEDRENO, perhaps with a comment that says it's a runtime dependency.
What do you think ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/mesa3d: Select more options for freedreno
Hi Thomas,
Quoted 9 lines · Thomas Petazzoni
So, what I'd prefer to see is:
- A patch that drops the select
BR2_PACKAGE_MESA3D_OPENGL_EGLfrom the etnaviv mesa3d option.- A patch that adds just the select
BR2_PACKAGE_LIBDRM_FREEDRENO, perhaps with a comment that says it's a runtime dependency.What do you think ?
I have just submitted a patch series with your proposal.
Thanks