soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()
Subsystems (3)
PATCH 1/1 soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()
From: Markus Elfring <[email protected]>
Date: Sun, 5 Apr 2020 18:08:13 +0200
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
--- drivers/soc/qcom/smp2p.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/smp2p.c +1 -3
@@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev) goto report_read_failure; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"unable to acquire smp2p interrupt\n" ); +if (irq <0 )return irq; - } smp2p->mbox_client.dev = &pdev->dev; smp2p->mbox_client.knows_txdone = true;
--
2.26.0
Quoted 10 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Sun, 5 Apr 2020 18:08:13 +0200The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
Thanks Markus, picked up for 5.8.
Regards,
Bjorn
Quoted 23 lines
--- drivers/soc/qcom/smp2p.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/soc/qcom/smp2p.c +1
-4@@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev) goto report_read_failure; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"unable to acquire smp2p interrupt\n" ); +if (irq <0 )return irq; - } smp2p->mbox_client.dev = &pdev->dev; smp2p->mbox_client.knows_txdone = true; --2.26.0