Skip to contentSkip to conversation

soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()

PATCH In review Markus Elfring 2 participants 2 messages Apr 5, 2020 – Apr 7, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 5 Apr 2020 18:08:13 +0200

The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.

This issue was detected by using the Coccinelle software.

---
 drivers/soc/qcom/smp2p.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/smp2p.c +1 -3
index c7300d54e444..07183d731d74 100644
@@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
 		goto report_read_failure;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	smp2p->mbox_client.dev = &pdev->dev;
 	smp2p->mbox_client.knows_txdone = true;

--
2.26.0

#1 lore raw
Quoted 10 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sun, 5 Apr 2020 18:08:13 +0200

The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.

This issue was detected by using the Coccinelle software.

Thanks Markus, picked up for 5.8.

Regards,
Bjorn

Quoted 23 lines
---
 drivers/soc/qcom/smp2p.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/qcom/smp2p.c +1 -4
index c7300d54e444..07183d731d74 100644
@@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
 		goto report_read_failure;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	smp2p->mbox_client.dev = &pdev->dev;
 	smp2p->mbox_client.knows_txdone = true;
--

2.26.0