Skip to contentSkip to conversation

cmd: eeprom: Staticize eeprom_i2c_bus

PATCH New Marek Vasut 2 participants 3 messages Apr 7, 2020 – Apr 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: eeprom: Staticize eeprom_i2c_bus

The eeprom_i2c_bus is not used outside of this file, make it static.

Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
---
 cmd/eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
cmd/eeprom.c +1 -1
index 667149e2d4..792415ef93 100644
@@ -61,7 +61,7 @@
 #endif
 
 #if defined(CONFIG_DM_I2C)
-int eeprom_i2c_bus;
+static int eeprom_i2c_bus;
 #endif
 
 __weak int eeprom_write_enable(unsigned dev_addr, int state)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 cmd: eeprom: Staticize eeprom_i2c_bus

Hello Marek,

Am 07.04.2020 um 13:29 schrieb Marek Vasut:

Quoted 8 lines

The eeprom_i2c_bus is not used outside of this file, make it static.

Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
---
  cmd/eeprom.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#2 lore raw

PATCH 1/1 cmd: eeprom: Staticize eeprom_i2c_bus

In reply to Marek Vasut

Hello Marek,

Am 07.04.2020 um 13:29 schrieb Marek Vasut:

Quoted 8 lines

The eeprom_i2c_bus is not used outside of this file, make it static.

Cc Heiko Schocher <[email protected]>
Cc Tom Rini <[email protected]>
---
  cmd/eeprom.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-i2c master, thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de