package/python-autobahn: drop python 2 support
PATCH 1/1 package/python-autobahn: drop python 2 support
Upstream removed python 2 support so we need to depend on python 3.
Removed python 2 autobahn tests.
Removed python-six dependency which is no longer used by autobahn.
--- .gitlab-ci.yml | 1 - package/python-autobahn/Config.in | 3 ++- support/testing/tests/package/test_python_autobahn.py | 10 ---------- 3 files changed, 2 insertions(+), 12 deletions(-)
.gitlab-ci.yml +0 -1
@@ -456,7 +456,6 @@ tests.package.test_python_argh.TestPythonPy2Argh: { extends: .runtime_test } tests.package.test_python_argh.TestPythonPy3Argh: { extends: .runtime_test } tests.package.test_python_attrs.TestPythonPy2Attrs: { extends: .runtime_test } tests.package.test_python_attrs.TestPythonPy3Attrs: { extends: .runtime_test } -tests.package.test_python_autobahn.TestPythonPy2Autobahn: { extends: .runtime_test } tests.package.test_python_autobahn.TestPythonPy3Autobahn: { extends: .runtime_test } tests.package.test_python_automat.TestPythonPy2Automat: { extends: .runtime_test } tests.package.test_python_automat.TestPythonPy3Automat: { extends: .runtime_test }
package/python-autobahn/Config.in +2 -1
@@ -1,8 +1,8 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN bool "python-autobahn" depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn + depends on BR2_PACKAGE_PYTHON3 select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime - select BR2_PACKAGE_PYTHON_SIX # runtime select BR2_PACKAGE_PYTHON_TXAIO # runtime help WebSocket client and server library, WAMP real-time
@@ -12,3 +12,4 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN comment "python-autobahn needs a toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_PACKAGE_PYTHON3
support/testing/tests/package/test_python_autobahn.py +0 -10
@@ -1,16 +1,6 @@ from tests.package.test_python import TestPythonPackageBase -class TestPythonPy2Autobahn(TestPythonPackageBase): - __test__ = True - config = TestPythonPackageBase.config + \ - """ - BR2_PACKAGE_PYTHON=y - BR2_PACKAGE_PYTHON_AUTOBAHN=y - """ - sample_scripts = ["tests/package/sample_python_autobahn.py"] - - class TestPythonPy3Autobahn(TestPythonPackageBase): __test__ = True config = TestPythonPackageBase.config + \
Signature · 1 line
2.20.1
PATCH 1/1 package/python-autobahn: drop python 2 support
Hi James, All,
Le 08/04/2020 ? 02:09, James Hilliard a ?crit?:
Quoted 5 lines
Upstream removed python 2 support so we need to depend on python 3.
Removed python 2 autobahn tests.
Removed python-six dependency which is no longer used by autobahn.
Don't hesitate to use all links to the upstream changes and our discussion on the mailing list.
http://lists.busybox.net/pipermail/buildroot/2020-April/279309.html
Quoted 25 lines
Signed-off-by James Hilliard <[email protected]>--- .gitlab-ci.yml | 1 - package/python-autobahn/Config.in | 3 ++- support/testing/tests/package/test_python_autobahn.py | 10 ---------- 3 files changed, 2 insertions(+), 12 deletions(-).gitlab-ci.yml +0
-1@@ -456,7 +456,6 @@ tests.package.test_python_argh.TestPythonPy2Argh: { extends: .runtime_test } tests.package.test_python_argh.TestPythonPy3Argh: { extends: .runtime_test } tests.package.test_python_attrs.TestPythonPy2Attrs: { extends: .runtime_test } tests.package.test_python_attrs.TestPythonPy3Attrs: { extends: .runtime_test } -tests.package.test_python_autobahn.TestPythonPy2Autobahn: { extends: .runtime_test } tests.package.test_python_autobahn.TestPythonPy3Autobahn: { extends: .runtime_test } tests.package.test_python_automat.TestPythonPy2Automat: { extends: .runtime_test } tests.package.test_python_automat.TestPythonPy3Automat: { extends: .runtime_test }package/python-autobahn/Config.in +0
-0
package/python-autobahn/Config.in line 4
Quoted 4 lines
package/python-autobahn/Config.in +1
-0@@ -1,8 +1,8 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN bool "python-autobahn" depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn + depends on BR2_PACKAGE_PYTHON3
I checked that all packages selecting python-autobahn (python-daphne and python-crossbar) are already python3 only.
package/python-autobahn/Config.in line 5
Quoted 2 lines
package/python-autobahn/Config.in +0
-1select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime - select BR2_PACKAGE_PYTHON_SIX # runtime
Maybe we have double check if python-daphne or python-crossbar are not using python-six at runtime.
Otherwise,
Best regards,
Romain
Quoted 30 lines
package/python-autobahn/Config.in +1
-0select BR2_PACKAGE_PYTHON_TXAIO # runtime help WebSocket client and server library, WAMP real-time@@ -12,3 +12,4 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN comment "python-autobahn needs a toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_PACKAGE_PYTHON3support/testing/tests/package/test_python_autobahn.py +0
-10@@ -1,16 +1,6 @@ from tests.package.test_python import TestPythonPackageBase -class TestPythonPy2Autobahn(TestPythonPackageBase): - __test__ = True - config = TestPythonPackageBase.config + \ - """ - BR2_PACKAGE_PYTHON=y - BR2_PACKAGE_PYTHON_AUTOBAHN=y - """ - sample_scripts = ["tests/package/sample_python_autobahn.py"] - - class TestPythonPy3Autobahn(TestPythonPackageBase): __test__ = True config = TestPythonPackageBase.config + \
PATCH 1/1 package/python-autobahn: drop python 2 support
In reply to James HilliardQuoted 7 lines · On Tue, 7 Apr 2020 18:09:48 -0600 James Hilliard <[email protected]>…
Upstream removed python 2 support so we need to depend on python 3.
Removed python 2 autobahn tests.
Removed python-six dependency which is no longer used by autobahn.
Signed-off-by James Hilliard <[email protected]>
I agree with Romain: this commit log was not sufficiently documented. References to the appropriate upstream commits + indication of what was the first upstream release to drop Python 2.x support and to drop python-six usage would have been relevant.
So I have extended the commit log with all those details, and applied. For future patches, it would be nice if you could document the commit log a bit more.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com