Skip to contentSkip to conversation

udev: Ignore change event for imsm

PATCH Applied Mariusz Tkaczyk 2 participants 2 messages Apr 8, 2020 – Apr 27, 2020 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 udev: Ignore change event for imsm

When adding a device to a container mdadm has to close its file descriptor before sysfs_add_disk(). This generates change event. There is race possibility because metadata is already written and other -I process can place drive differently. As a result device can be added to two containers simultaneously.
From IMSM perspective there is no need to react for change event. IMSM doesn't support stacked devices.

---
 udev-md-raid-assembly.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
udev-md-raid-assembly.rules +1 -1
index 9f055ed0..d668cddd 100644
@@ -23,7 +23,7 @@ IMPORT{cmdline}="nodmraid"
 ENV{nodmraid}=="?*", GOTO="md_inc_end"
 ENV{ID_FS_TYPE}=="ddf_raid_member", GOTO="md_inc"
 ENV{noiswmd}=="?*", GOTO="md_inc_end"
-ENV{ID_FS_TYPE}=="isw_raid_member", GOTO="md_inc"
+ENV{ID_FS_TYPE}=="isw_raid_member", ACTION!="change", GOTO="md_inc"
 GOTO="md_inc_end"
 
 LABEL="md_inc"
Signature · 1 line
2.25.0
Applied
#1 lore raw
Quoted 8 lines · Mariusz Tkaczyk

When adding a device to a container mdadm has to close its file descriptor before sysfs_add_disk(). This generates change event. There is race possibility because metadata is already written and other -I process can place drive differently. As a result device can be added to two containers simultaneously.
From IMSM perspective there is no need to react for change event. IMSM doesn't support stacked devices.

Quoted 4 lines
---
 udev-md-raid-assembly.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied!

Thanks,
Jes