Skip to contentSkip to conversation

dmaengine: tegra: fix broken 'select' statement

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: tegra: fix broken 'select' statement

A SoC driver selects the dmaengine driver for the platform it is made for, leading to Kconfig warnings in some configurations:

WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=y]) Selected by [y]:
- SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]

WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=y]) Selected by [y]:
- SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]

Generally, no driver should 'select' a driver from a different subsystem, especially when there is no build-time dependency between the two.

Remove the bogus 'select' and instead change the dmaengine driver to be default-enabled in this configuration, to let existing defconfig files continue working.

---
 drivers/dma/Kconfig       | 1 +
 drivers/soc/tegra/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/dma/Kconfig +1 -0
index 023db6883d05..c19e25b140c5 100644
@@ -619,6 +619,7 @@ config TXX9_DMAC
 config TEGRA20_APB_DMA
 	tristate "NVIDIA Tegra20 APB DMA support"
 	depends on ARCH_TEGRA || COMPILE_TEST
+	default SOC_TEGRA_FUSE && ARCH_TEGRA_2x_SOC
 	select DMA_ENGINE
 	help
 	  Support for the NVIDIA Tegra20 APB DMA controller driver. The
drivers/soc/tegra/Kconfig +0 -1
index 3693532949b8..84bd615c4a92 100644
@@ -126,7 +126,6 @@ config SOC_TEGRA_FUSE
 	def_bool y
 	depends on ARCH_TEGRA
 	select SOC_BUS
-	select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
 
 config SOC_TEGRA_FLOWCTRL
 	bool
Signature · 1 line
2.26.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

A SoC driver selects the dmaengine driver for the platform it is made for, leading to Kconfig warnings in some configurations:

WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=y]) Selected by [y]:
- SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]

Quoted 7 lines

WARNING: unmet direct dependencies detected for TEGRA20_APB_DMA
Depends on [n]: DMADEVICES [=n] && (ARCH_TEGRA [=y] || COMPILE_TEST [=y]) Selected by [y]:
- SOC_TEGRA_FUSE [=y] && ARCH_TEGRA [=y] && ARCH_TEGRA_2x_SOC [=y]

Generally, no driver should 'select' a driver from a different subsystem, especially when there is no build-time dependency between the two.

IIRC there's a run-time dependency between the two though; without the DMA driver available to implement a HW WAR, the fuse driver has to access fuse registers directly which IIRC can cause a lock-up, or something like that. So I think allowing APD_DMA to be deselected by the user is wrong for T20 at least; it simply must be enabled. Perhaps ARCH_TEGRA_2x_SOC should select it instead?