Skip to contentSkip to conversation

package/assimp: bump version to 5.0.1

PATCH New Peter Seiderer 2 participants 5 messages Apr 7, 2020 – Apr 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/assimp: bump version to 5.0.1

---
 ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
 package/assimp/assimp.hash                             |  4 ++--
 package/assimp/assimp.mk                               |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)
package/assimp/0001-Fix-FBXConverter-use-proper-64-bit-constant.patch +6 -4
index bfcbeb55e3..1b23d66364 100644
@@ -12,15 +12,17 @@ Use proper 64-bit constant for CONVERT_FBX_TIME(time) conversion, fixes:
   code/FBXConverter.cpp:2878: error: integer constant is too large for 'long' type
   code/FBXConverter.cpp:2888: error: integer constant is too large for 'long' type
 
+Signed-off-by: Peter Seiderer <[email protected]>
+[Rebased on 5.0.1]
 Signed-off-by: Peter Seiderer <[email protected]>
 ---
- code/FBXConverter.cpp | 2 +-
+ code/FBX/FBXConverter.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/code/FBXConverter.cpp b/code/FBXConverter.cpp
+diff --git a/code/FBX/FBXConverter.cpp b/code/FBXConverter.cpp
 index e0c6b9c..b1e9a71 100644
---- a/code/FBXConverter.cpp
-+++ b/code/FBXConverter.cpp
+--- a/code/FBX/FBXConverter.cpp
++++ b/code/FBX/FBXConverter.cpp
 @@ -67,7 +67,7 @@ namespace FBX {
  
  #define MAGIC_NODE_TAG "_$AssimpFbx$"
package/assimp/assimp.hash +2 -2
index 72d367ac43..df5daa79c9 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256 3520b1e9793b93a2ca3b797199e16f40d61762617e072f2d525fad70f9678a71  assimp-4.1.0.tar.gz
-sha256 a26ccc3dbf2f58ea99c100945a8a126fa0f9f4d7fd2b49aa8bdb8e09355864d8  LICENSE
+sha256  11310ec1f2ad2cd46b95ba88faca8f7aaa1efe9aa12605c55e3de2b977b3dbfc  assimp-5.0.1.tar.gz
+sha256  a26ccc3dbf2f58ea99c100945a8a126fa0f9f4d7fd2b49aa8bdb8e09355864d8  LICENSE
package/assimp/assimp.mk +1 -1
index ce02ef300c..5e8e825375 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-ASSIMP_VERSION = 4.1.0
+ASSIMP_VERSION = 5.0.1
 ASSIMP_SITE = $(call github,assimp,assimp,v$(ASSIMP_VERSION))
 ASSIMP_LICENSE = BSD-3-Clause
 ASSIMP_LICENSE_FILES = LICENSE
Signature · 1 line
2.26.0
#1 lore raw

PATCH 1/1 package/assimp: bump version to 5.0.1

Quoted 6 lines · On Tue, 7 Apr 2020 23:12:38 +0200 Peter Seiderer <[email protected]> wrote:
---
 ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
 package/assimp/assimp.hash                             |  4 ++--
 package/assimp/assimp.mk                               |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)

Applied, thanks. Could you submit the patch we have to the upstream project?

Also did you test building the qt53d package after this update? It is the only package in Buildroot that uses assimp.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/assimp: bump version to 5.0.1

Hello Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 6 lines · On Tue, 7 Apr 2020 23:12:38 +0200 Peter Seiderer <[email protected]> wrote:
---
 ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
 package/assimp/assimp.hash                             |  4 ++--
 package/assimp/assimp.mk                               |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)
Quoted 2 lines

Applied, thanks. Could you submit the patch we have to the upstream project?

Already on my ToDo list ;-)...

Quoted 3 lines

Also did you test building the qt53d package after this update? It is the only package in Buildroot that uses assimp.

Yes...and compiled without failure after the assimp version bump...

Regards,
Peter

Quoted 4 lines

Thanks!

Thomas

#3 lore raw

PATCH 1/1 package/assimp: bump version to 5.0.1

Hello Thomas,

Quoted 14 lines · Peter Seiderer

Hello Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 6 lines · On Tue, 7 Apr 2020 23:12:38 +0200 Peter Seiderer <[email protected]> wrote:
---
 ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
 package/assimp/assimp.hash                             |  4 ++--
 package/assimp/assimp.mk                               |  2 +-
 3 files changed, 9 insertions(+), 7 deletions(-)
Quoted 4 lines
Quoted 2 lines

Applied, thanks. Could you submit the patch we have to the upstream project?

Already on my ToDo list ;-)...

Seems Fabrice Fontaine already handled it, see [1], but the change did not make it into the 5.0.1 release...

Regards,
Peter

[1] https://github.com/assimp/assimp/commit/32781a566db2cd6022c7020ff2ac591d753c11ab

Quoted 19 lines
Quoted 4 lines

Also did you test building the qt53d package after this update? It is the only package in Buildroot that uses assimp.

Yes...and compiled without failure after the assimp version bump...

Regards,
Peter

Quoted 4 lines

Thanks!

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 package/assimp: bump version to 5.0.1

Quoted 7 lines · On Wed, 8 Apr 2020 23:15:41 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 4 lines
Quoted 2 lines

Applied, thanks. Could you submit the patch we have to the upstream project?

Already on my ToDo list ;-)...

Seems Fabrice Fontaine already handled it, see [1], but the change did not make it into the 5.0.1 release...

Great, thanks for having checked!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com