MIPS: CI20: add HDMI out support

and add compatible: jz4780-lcd, including an example how to configure both lcd controllers.

Also fix the clock names and examples.

Based on work by Paul Cercueil <[email protected]> and Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

---
 .../bindings/display/ingenic,lcd.txt          |  45 ------
 .../bindings/display/ingenic,lcd.yaml         | 128 ++++++++++++++++++
 2 files changed, 128 insertions(+), 45 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt
 create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

Am 30.03.2020 um 17:42 schrieb Rob Herring <[email protected]>:

Quoted 11 lines · H. Nikolaus Schaller

and add compatible: jz4780-lcd, including an example how to configure both lcd controllers.

Also fix the clock names and examples.

Based on work by Paul Cercueil <[email protected]> and Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

Quoted 7 lines

---
.../bindings/display/ingenic,lcd.txt | 45 ------
.../bindings/display/ingenic,lcd.yaml | 128 ++++++++++++++++++

2 files changed, 128 insertions(+), 45 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic,lcd.example.dt.yaml: lcd-controller@13050000: clocks: [[4294967295, 9]] is too short

See https://patchwork.ozlabs.org/patch/1263508

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.

Am 30.03.2020 um 19:07 schrieb Paul Cercueil <[email protected]>:

Quoted 26 lines · H. Nikolaus Schaller

Quoted 26 lines

Am 30.03.2020 um 18:43 schrieb Paul Cercueil <[email protected]>:
Hi Nikolaus,

Quoted 23 lines · H. Nikolaus Schaller

Hi Paul,

Quoted 16 lines

Am 30.03.2020 um 17:42 schrieb Rob Herring <[email protected]>:

Quoted 8 lines · H. Nikolaus Schaller

and add compatible: jz4780-lcd, including an example how to configure both lcd controllers.
Also fix the clock names and examples.
Based on work by Paul Cercueil <[email protected]> and Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

Quoted 6 lines

---
.../bindings/display/ingenic,lcd.txt | 45 ------
.../bindings/display/ingenic,lcd.yaml | 128 ++++++++++++++++++

2 files changed, 128 insertions(+), 45 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

Quoted 3 lines

My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic,lcd.example.dt.yaml: lcd-controller@13050000: clocks: [[4294967295, 9]] is too short See https://patchwork.ozlabs.org/patch/1263508

If I read the message correctly, I think there should be 2 clocks specified in the jz4725b-lcd example and not just

	clocks = <&cgu JZ4725B_CLK_LCD>;

Quoted 4 lines

Quoted 1 line

You get this message because that's what the YAML says. There is only one clock on JZ4725B so the yaml should reflect that.

That was the missing piece of information that there is only one clock on the jz4780. Anyways, is there some example? Does some jz4725b.dtsi exist somewhere? It is difficult to write correct yaml for a device that is not upstream.

https://github.com/OpenDingux/linux/blob/jz-5.5-rs90/arch/mips/boot/dts/ingenic/jz4725b.dtsi#L331

-Paul

Quoted 18 lines

Otherwise I'd propose to drop the jz4725b and use the jz4740 as example. BR and thanks,
Nikolaus

Quoted 15 lines

-Paul

Quoted 14 lines

Unfortunately the jz4725b.dtsi does not seem to be upstream or in linux-next so I don't know if it works without lcd_pclk or not.
If there is really just one clock, we need to modify the clocks and clock-names schema and add minItems: 1 and maxItems: 2 to allow for this flexibility. Otherwise we have to fix the example. Do you have some git with an up-to-date jz4725b.dtsi to look at?

Quoted 3 lines

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

+++ :)

Quoted 1 line

Please check and re-submit.

Sure, since it is a RFC.
BR and thanks,
Nikolaus

and add compatible: jz4780-lcd, including an example how to configure both lcd controllers.

Also fix the clock names and examples.

Based on work by Paul Cercueil <[email protected]> and Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

---
 .../bindings/display/ingenic,lcd.txt          |  45 ------
 .../bindings/display/ingenic,lcd.yaml         | 128 ++++++++++++++++++
 2 files changed, 128 insertions(+), 45 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt
 create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

Documentation/devicetree/bindings/display/ingenic,lcd.txt deleted +0 -45

deleted file mode 100644
index 01e3261defb6..000000000000
@@ -1,45 +0,0 @@
-Ingenic JZ47xx LCD driver
-
-Required properties:
-- compatible: one of:
-  * ingenic,jz4740-lcd
-  * ingenic,jz4725b-lcd
-  * ingenic,jz4770-lcd
-- reg: LCD registers location and length
-- clocks: LCD pixclock and device clock specifiers.
-	   The device clock is only required on the JZ4740.
-- clock-names: "lcd_pclk" and "lcd"
-- interrupts: Specifies the interrupt line the LCD controller is connected to.
-
-Example:
-
-panel {
-	compatible = "sharp,ls020b1dd01d";
-
-	backlight = <&backlight>;
-	power-supply = <&vcc>;
-
-	port {
-		panel_input: endpoint {
-			remote-endpoint = <&panel_output>;
-		};
-	};
-};
-
-
-lcd: lcd-controller@13050000 {
-	compatible = "ingenic,jz4725b-lcd";
-	reg = <0x13050000 0x1000>;
-
-	interrupt-parent = <&intc>;
-	interrupts = <31>;
-
-	clocks = <&cgu JZ4725B_CLK_LCD>;
-	clock-names = "lcd";
-
-	port {
-		panel_output: endpoint {
-			remote-endpoint = <&panel_input>;
-		};
-	};
-};

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +62 -0

new file mode 100644
index 000000000000..8b6467cfc191
@@ -0,0 +1,128 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic,lcd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for Ingenic JZ4780 LCD Controller
+
+maintainers:
+  - Paul Cercueil <[email protected]>
+
+description: |
+  LCD Controller is the Display Controller for the Ingenic JZ47xx SoC
+
+properties:
+  compatible:
+    oneOf:
+     - const: ingenic,jz4725b-lcd
+     - const: ingenic,jz4740-lcd
+     - const: ingenic,jz4770-lcd
+     - const: ingenic,jz4780-lcd
+
+  reg:
+    maxItems: 1
+    description: LCD registers location and length
+
+  interrupts:
+    maxItems: 1
+    description: Specifies the interrupt provided by parent
+
+  clocks:
+    maxItems: 2
+    description: Clock specifiers for LCD pixclock and device clock.
+      The device clock is only required on the JZ4740 and JZ4780
+
+  clock-names:
+    items:
+      - const: lcd
+      - const: lcd_pclk
+
+  port:
+    type: object
+    description: |
+      A port node with endpoint definitions as defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt
+
+required:
+    - compatible
+    - reg
+    - interrupts
+    - clocks
+    - clock-names
+    - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4725b-cgu.h>
+
+    panel {
+      compatible = "sharp,ls020b1dd01d";

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +7 -0

+
+    lcd: lcd-controller@13050000 {
+      compatible = "ingenic,jz4725b-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <31>;

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +10 -0

+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x13050000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";
+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        jz4780_lcd_out: port {

Am 09.04.2020 um 09:25 schrieb Sam Ravnborg <[email protected]>:

Hi Nikolaus

Some comments below that will result in a simplee binding that passes the checks.
Thanks for pushing this.

Sam

Quoted 140 lines · H. Nikolaus Schaller

and add compatible: jz4780-lcd, including an example how to configure both lcd controllers.

Also fix the clock names and examples.

Based on work by Paul Cercueil <[email protected]> and Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

---
.../bindings/display/ingenic,lcd.txt | 45 ------
.../bindings/display/ingenic,lcd.yaml | 128 ++++++++++++++++++

2 files changed, 128 insertions(+), 45 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.yaml

Documentation/devicetree/bindings/display/ingenic,lcd.txt deleted +0 -45

deleted file mode 100644
index 01e3261defb6..000000000000
@@ -1,45 +0,0 @@
-Ingenic JZ47xx LCD driver
-
-Required properties:
-- compatible: one of:
-  * ingenic,jz4740-lcd
-  * ingenic,jz4725b-lcd
-  * ingenic,jz4770-lcd
-- reg: LCD registers location and length
-- clocks: LCD pixclock and device clock specifiers.
-	   The device clock is only required on the JZ4740.
-- clock-names: "lcd_pclk" and "lcd"
-- interrupts: Specifies the interrupt line the LCD controller is connected to.
-
-Example:
-
-panel {
-	compatible = "sharp,ls020b1dd01d";
-
-	backlight = <&backlight>;
-	power-supply = <&vcc>;
-
-	port {
-		panel_input: endpoint {
-			remote-endpoint = <&panel_output>;
-		};
-	};
-};
-
-
-lcd: lcd-controller@13050000 {
-	compatible = "ingenic,jz4725b-lcd";
-	reg = <0x13050000 0x1000>;
-
-	interrupt-parent = <&intc>;
-	interrupts = <31>;
-
-	clocks = <&cgu JZ4725B_CLK_LCD>;
-	clock-names = "lcd";
-
-	port {
-		panel_output: endpoint {
-			remote-endpoint = <&panel_input>;
-		};
-	};
-};

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +65 -0

new file mode 100644
index 000000000000..8b6467cfc191
@@ -0,0 +1,128 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic,lcd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for Ingenic JZ4780 LCD Controller
+
+maintainers:
+  - Paul Cercueil <[email protected]>
+
+description: |
+  LCD Controller is the Display Controller for the Ingenic JZ47xx SoC
+
+properties:
+  compatible:
+    oneOf:
+     - const: ingenic,jz4725b-lcd
+     - const: ingenic,jz4740-lcd
+     - const: ingenic,jz4770-lcd
+     - const: ingenic,jz4780-lcd
+
+  reg:
+    maxItems: 1
+    description: LCD registers location and length
+
+  interrupts:
+    maxItems: 1
+    description: Specifies the interrupt provided by parent
+
+  clocks:
+    maxItems: 2
+    description: Clock specifiers for LCD pixclock and device clock.
+      The device clock is only required on the JZ4740 and JZ4780
+
+  clock-names:
+    items:
+      - const: lcd
+      - const: lcd_pclk
+
+  port:
+    type: object
+    description: |
+      A port node with endpoint definitions as defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt
+
+required:
+    - compatible
+    - reg
+    - interrupts
+    - clocks
+    - clock-names
+    - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4725b-cgu.h>
+
+    panel {
+      compatible = "sharp,ls020b1dd01d";
+
+      backlight = <&backlight>;
+      power-supply = <&vcc>;

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 72

Quoted 7 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +7 -0

+
+      port {
+        panel_input: endpoint {
+          remote-endpoint = <&panel_output>;
+          };
+        };
+      };

The panel part is not needed - better to drop it.

Quoted 15 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +13 -0

+
+    lcd: lcd-controller@13050000 {
+      compatible = "ingenic,jz4725b-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <31>;
+
+      clocks = <&cgu JZ4725B_CLK_LCD>;
+      clock-names = "lcd", "lcd_pclk";
+
+      port {
+        panel_output: endpoint {

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 89

Quoted 4 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +4 -0

+          remote-endpoint = <&panel_input>;
+          };
+        };
+      };

We know this example will not pass the check, as there is only one clock specified.
I suggest to drop this example.
If it later turns out that jz4725b only have one clock,

then the binding
needs to be updated.

But the best guess is that the example is wrong.

The example below for jz4780-lcd cover all relevant parts - so just keep it as the only example.

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 94

Quoted 5 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +5 -0

+
+  - |
+    #include <dt-bindings/clock/jz4780-cgu.h>
+
+    lcdc0: lcdc0@13050000 {

Name this lcdc
And drop "lcdc0@13050000" as this is not relevant for this example.

Remember - the examples exist to explain the binding. They are just examples.

Quoted 14 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +14 -0

+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x13050000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";
+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        jz4780_lcd_out: port {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            jz4780_out_hdmi: endpoint@0 {

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 114

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+                reg = <0>;
+                remote-endpoint = <&hdmi_in_lcd>;
+            };
+        };
+    };
+

And drop this as it does not add anything extra.

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+    lcdc1: lcdc1@130a0000 {
+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x130a0000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD1PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 126

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        status = "disabled";
+    };

Sam

Quoted 10 lines

Quoted 10 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +10 -0

+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4725b-cgu.h>
+
+    panel {
+      compatible = "sharp,ls020b1dd01d";
+
+      backlight = <&backlight>;
+      power-supply = <&vcc>;

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 72

Quoted 7 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +7 -0

+
+      port {
+        panel_input: endpoint {
+          remote-endpoint = <&panel_output>;
+          };
+        };
+      };

The panel part is not needed - better to drop it.

Well, it is needed to fulfill the remote-endpoint below.

Quoted 16 lines

Quoted 16 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +13 -0

+
+    lcd: lcd-controller@13050000 {
+      compatible = "ingenic,jz4725b-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <31>;
+
+      clocks = <&cgu JZ4725B_CLK_LCD>;
+      clock-names = "lcd", "lcd_pclk";
+
+      port {
+        panel_output: endpoint {

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 89

Quoted 4 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +4 -0

+          remote-endpoint = <&panel_input>;
+          };
+        };
+      };

We know this example will not pass the check, as there is only one clock specified.
I suggest to drop this example.
If it later turns out that jz4725b only have one clock,

Paul already reported that it only wants to see one clock.

Quoted 2 lines

then the binding
needs to be updated.

Yes, I have that on my to-do list to update the binding to reflect this minItems/maxItems thing but I am not yet sure about how to handle the clock-names in that case. I.e. make "lcd" optional and enforce "lcd_pclk" only.

Quoted 31 lines

But the best guess is that the example is wrong.

The example below for jz4780-lcd cover all relevant parts - so just keep it as the only example.

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 94

Quoted 5 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +5 -0

+
+  - |
+    #include <dt-bindings/clock/jz4780-cgu.h>
+
+    lcdc0: lcdc0@13050000 {

Name this lcdc
And drop "lcdc0@13050000" as this is not relevant for this example.

Remember - the examples exist to explain the binding. They are just examples.

Quoted 14 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +14 -0

+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x13050000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";
+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        jz4780_lcd_out: port {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            jz4780_out_hdmi: endpoint@0 {

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 114

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+                reg = <0>;
+                remote-endpoint = <&hdmi_in_lcd>;
+            };
+        };
+    };
+

And drop this as it does not add anything extra.

Well, it demonstrates how to add a second lcdc which is disabled.

Showing that it is possible to do so is IMHO the most important part of the example because it is not at all obvious.

I have also added both SoC to show how differently they can and should be.

Quoted 6 lines

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+    lcdc1: lcdc1@130a0000 {
+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x130a0000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD1PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 126

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        status = "disabled";
+    };

Sam

BR and thanks,
Nikolaus

Am 09.04.2020 um 14:20 schrieb Sam Ravnborg <[email protected]>:

Hi Nikolaus.

Quoted 19 lines

Quoted 18 lines

Quoted 7 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +7 -0

+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4725b-cgu.h>
+
+    panel {
+      compatible = "sharp,ls020b1dd01d";

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 72

Quoted 10 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +10 -0

+
+      backlight = <&backlight>;
+      power-supply = <&vcc>;
+
+      port {
+        panel_input: endpoint {
+          remote-endpoint = <&panel_output>;
+          };
+        };
+      };

The panel part is not needed - better to drop it.

Quoted 1 line

Well, it is needed to fulfill the remote-endpoint below.

Examples may have phandle that are not defined.
So the example will work fine without it.
See other similar examples.

Quoted 28 lines

Quoted 17 lines

Quoted 17 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +13 -0

+
+    lcd: lcd-controller@13050000 {
+      compatible = "ingenic,jz4725b-lcd";
+      reg = <0x13050000 0x1000>;
+
+      interrupt-parent = <&intc>;
+      interrupts = <31>;
+
+      clocks = <&cgu JZ4725B_CLK_LCD>;
+      clock-names = "lcd", "lcd_pclk";
+
+      port {
+        panel_output: endpoint {

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 89

Quoted 4 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +4 -0

+          remote-endpoint = <&panel_input>;
+          };
+        };
+      };

We know this example will not pass the check, as there is only one clock specified.
I suggest to drop this example.
If it later turns out that jz4725b only have one clock,

Paul already reported that it only wants to see one clock.

Quoted 7 lines

Quoted 2 lines

then the binding
needs to be updated.

Yes, I have that on my to-do list to update the binding to reflect this minItems/maxItems thing but I am not yet sure about how to handle the clock-names in that case. I.e. make "lcd" optional and enforce "lcd_pclk" only.

Look forward to next version.

Quoted 40 lines

Quoted 39 lines

But the best guess is that the example is wrong.

The example below for jz4780-lcd cover all relevant parts - so just keep it as the only example.

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 94

Quoted 5 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +5 -0

+
+  - |
+    #include <dt-bindings/clock/jz4780-cgu.h>
+
+    lcdc0: lcdc0@13050000 {

Name this lcdc
And drop "lcdc0@13050000" as this is not relevant for this example.

Remember - the examples exist to explain the binding. They are just examples.

Quoted 10 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +10 -0

+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x13050000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";
+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        jz4780_lcd_out: port {

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 114

Quoted 10 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +10 -0

+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            jz4780_out_hdmi: endpoint@0 {
+                reg = <0>;
+                remote-endpoint = <&hdmi_in_lcd>;
+            };
+        };
+    };
+

And drop this as it does not add anything extra.

Quoted 1 line

Well, it demonstrates how to add a second lcdc which is disabled.

The purpose of the example is to show an example of the binding specified in this file.
Adding a second disabled lcdc is a general thing, and not something we want in all the individual examples.

Also the actual content, for example register values can be random as they are not part of the binding.
This is not a documentation of the HW but a binding example.

Sam

Quoted 25 lines

Showing that it is possible to do so is IMHO the most important part of the example because it is not at all obvious.

I have also added both SoC to show how differently they can and should be.

Quoted 6 lines

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+    lcdc1: lcdc1@130a0000 {
+        compatible = "ingenic,jz4780-lcd";
+        reg = <0x130a0000 0x1800>;
+
+        clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD1PIXCLK>;
+        clock-names = "lcd", "lcd_pclk";

Quoted 8 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml line 126

Quoted 6 lines

Documentation/devicetree/bindings/display/ingenic,lcd.yaml new file +6 -0

+
+        interrupt-parent = <&intc>;
+        interrupts = <31>;
+
+        status = "disabled";
+    };

Sam

BR and thanks,
Nikolaus

so that the driver can load by matching the device tree if compiled as module.

Signed-off-by H. Nikolaus Schaller <[email protected]>

---
 drivers/gpu/drm/ingenic/ingenic-drm.c | 1 +
 1 file changed, 1 insertion(+)

drivers/gpu/drm/ingenic/ingenic-drm.c +1 -0

index 6d47ef7b148c..bcba2f024842 100644
@@ -843,6 +843,7 @@ static const struct of_device_id 
 ingenic_drm_of_match[] = {
 	{ .compatible = "ingenic,jz4770-lcd", .data = &jz4770_soc_info },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
 
 static struct platform_driver ingenic_drm_driver = {

.driver = {
--
2.25.1

From: Sam Ravnborg <[email protected]>

Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel

Signed-off-by Sam Ravnborg <[email protected]>

Signed-off-by H. Nikolaus Schaller <[email protected]>

Cc Rob Herring <[email protected]>

Cc [email protected]

---
 .../bindings/display/ingenic-jz4780-hdmi.yaml | 82 +++++++++++++++++++
 1 file changed, 82 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml

Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml new file +7 -0

new file mode 100644
index 000000000000..a545ff8704eb
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bindings for Ingenic JZ4780 HDMI Transmitter

Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml new file +18 -0

+
+properties:
+  compatible:
+    items:
+      - const: ingenic,jz4780-hdmi
+
+  reg:
+    maxItems: 1
+    description: the address & size of the LCD controller registers
+
+  reg-io-width:
+    const: 4
+
+  interrupts:
+    maxItems: 1
+    description: Specifies the interrupt provided by parent
+
+  clocks:

Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml new file +37 -0

+
+required:
+    - compatible
+    - clocks
+    - clock-names
+    - ports
+    - reg-io-width
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/jz4780-cgu.h>
+
+    hdmi: hdmi@10180000 {
+        compatible = "ingenic,jz4780-hdmi";
+        reg = <0x10180000 0x8000>;
+        reg-io-width = <4>;
+        ddc-i2c-bus = <&i2c4>;
+        interrupt-parent = <&intc>;
+        interrupts = <3>;
+        clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>;
+        clock-names = "isfr", "iahb";
+
+        ports {
+            hdmi_in: port {
+                #address-cells = <1>;
+                #size-cells = <0>;
+                hdmi_in_lcd: endpoint@0 {
+                    reg = <0>;
+                    remote-endpoint = <&jz4780_out_hdmi>;
+                };
+            };
+        };
+    };
+
+...

Signature · 6 lines

2.25.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel