Skip to contentSkip to conversation

staging: fbtft: fb_st7789v: enabled inversion

PATCH In review Oliver Graute 2 participants 6 messages Apr 9, 2020 – Apr 28, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: fb_st7789v: enabled inversion

From: Oliver Graute <[email protected]>

Enable inversion mode

---
 drivers/staging/fbtft/fb_st7789v.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/fbtft/fb_st7789v.c +4 -0
index 3c3f387936e8..84c5af2dc9a0 100644
@@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, PWCTRL1, 0xA4, 0xA1);
 
 	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
+
+	/* enable inversion mode */
+	write_reg(par, 0x21);
+
 	return 0;
 }
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · Oliver Graute

From: Oliver Graute <[email protected]>

Enable inversion mode

---
 drivers/staging/fbtft/fb_st7789v.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/fbtft/fb_st7789v.c +0 -0
index 3c3f387936e8..84c5af2dc9a0 100644

drivers/staging/fbtft/fb_st7789v.c static int init_display(struct fbtft_par *par) · line 125

Quoted 6 lines
drivers/staging/fbtft/fb_st7789v.c +3 -0
@@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, PWCTRL1, 0xA4, 0xA1);
 
 	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
+
+	/* enable inversion mode */
+	write_reg(par, 0x21);

Use the define and delete the comment.

	write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);

regards,
dan carpenter

#2 lore raw
Quoted 17 lines · Dan Carpenter
Quoted 16 lines · Oliver Graute

From: Oliver Graute <[email protected]>

Enable inversion mode

---
 drivers/staging/fbtft/fb_st7789v.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/fbtft/fb_st7789v.c +0 -0
index 3c3f387936e8..84c5af2dc9a0 100644
@@ -120,6 +120,10 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, PWCTRL1, 0xA4, 0xA1);
 
Quoted 8 lines

drivers/staging/fbtft/fb_st7789v.c static int init_display(struct fbtft_par *par) · line 125

Quoted 4 lines
drivers/staging/fbtft/fb_st7789v.c +3 -0
 	write_reg(par, MIPI_DCS_SET_DISPLAY_ON);
+
+	/* enable inversion mode */
+	write_reg(par, 0x21);

Use the define and delete the comment.

	write_reg(par, MIPI_DCS_ENTER_INVERT_MODE);

ok, I'll do on next version

Best regards,

Oliver

#4 lore raw
Quoted 6 lines · Dan Carpenter
Quoted 3 lines · Oliver Graute

From: Oliver Graute <[email protected]>

Enable inversion mode

What the heck is an inversion mode and why would you want it?

Should I name it:

Enable MIPI_DCS_ENTER_INVERT_MODE

Best Regards,

Oliver

#5 lore raw
Quoted 4 lines · Oliver Graute
Quoted 3 lines · Dan Carpenter
Quoted 2 lines · Oliver Graute

From: Oliver Graute <[email protected]>

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

Enable inversion mode

What the heck is an inversion mode and why would you want it?

Should I name it:

Enable MIPI_DCS_ENTER_INVERT_MODE

What I'm saying is the changelog should explain why would want to apply the patch. What does the inversion mode do? Is it inverting the color or flipping something upside down?

Probably if I had a background in graphics I would know what "Enable inversion mode" means... But three words is not a proper and complete commit message normally.

regards,
dan carpenter