Skip to contentSkip to conversation

build: add note about make system deprecation

PATCH Superseded Bruce Richardson 3 participants 6 messages Apr 9, 2020 – May 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: add note about make system deprecation

When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead.

---
 mk/rte.sdkbuild.mk  | 4 ++++
 mk/rte.sdkconfig.mk | 4 ++++
 2 files changed, 8 insertions(+)
mk/rte.sdkbuild.mk +4 -0
index b512de1ec..67d07a7ed 100644
@@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
 .PHONY: clean
 clean: $(CLEANDIRS)
mk/rte.sdkconfig.mk +4 -0
index f538649f2..9a7ffbe9a 100644
@@ -62,6 +62,10 @@ else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 endif
 
 $(RTE_OUTPUT):
Signature · 1 line
2.20.1
#1 lore raw
Quoted 30 lines · Bruce Richardson

When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead.

---
 mk/rte.sdkbuild.mk  | 4 ++++
 mk/rte.sdkconfig.mk | 4 ++++
 2 files changed, 8 insertions(+)
mk/rte.sdkbuild.mk +4 -0
index b512de1ec..67d07a7ed 100644
@@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
 .PHONY: clean
 clean: $(CLEANDIRS)
mk/rte.sdkconfig.mk +0 -0
index f538649f2..9a7ffbe9a 100644

mk/rte.sdkconfig.mk else · line 68

Quoted 7 lines
mk/rte.sdkconfig.mk +4 -0
@@ -62,6 +62,10 @@ else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="

What do you think providing a link to meson documentation too?

Quoted 4 lines
mk/rte.sdkconfig.mk +0 -0
 endif
 
 $(RTE_OUTPUT):
#2 lore raw
Quoted 24 lines · Ferruh Yigit
Quoted 23 lines · Bruce Richardson

When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead.

---
 mk/rte.sdkbuild.mk  | 4 ++++
 mk/rte.sdkconfig.mk | 4 ++++
 2 files changed, 8 insertions(+)
mk/rte.sdkbuild.mk +4 -0
index b512de1ec..67d07a7ed 100644
@@ -28,6 +28,10 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
Quoted 17 lines
Quoted 7 lines
mk/rte.sdkbuild.mk +0 -0
 .PHONY: clean
 clean: $(CLEANDIRS)
mk/rte.sdkconfig.mk +0 -0
index f538649f2..9a7ffbe9a 100644

mk/rte.sdkconfig.mk else · line 68

Quoted 7 lines
mk/rte.sdkconfig.mk +4 -0
@@ -62,6 +62,10 @@ else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="

What do you think providing a link to meson documentation too?

Not a bad idea - though it may need to wait until the instructions on the website itself get updated. Currently the best link is probably,
http://doc.dpdk.org/guides/linux_gsg/build_dpdk.html#compiling-and-installing-dpdk-system-wide
but it's rather long and unwieldy.

/Bruce

#3 lore raw

PATCH v2 1/1 build: add note about make system deprecation

In reply to Bruce Richardson

When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead.

---
v2: added link to the docs on building DPDK

---
 mk/rte.sdkbuild.mk  | 5 +++++
 mk/rte.sdkconfig.mk | 5 +++++
 2 files changed, 10 insertions(+)
mk/rte.sdkbuild.mk +5 -0
index b512de1ec..d1d57b669 100644
@@ -28,6 +28,11 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
 .PHONY: clean
 clean: $(CLEANDIRS)
mk/rte.sdkconfig.mk +5 -0
index f538649f2..2ea85e464 100644
@@ -62,6 +62,11 @@ else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 endif
 
 $(RTE_OUTPUT):
Signature · 1 line
2.20.1