Skip to contentSkip to conversation

package/mesa3d: Do not select MESA3D_OPENGL_EGL for etnaviv

PATCH New Fabio Estevam 2 participants 6 messages Apr 9, 2020 – Apr 11, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/5 package/mesa3d: Do not select MESA3D_OPENGL_EGL for etnaviv

As suggested by Thomas, BR2_PACKAGE_MESA3D_OPENGL_EGL should not be automatically selected by the etnaviv driver.

---
Changes since v1:
- None

 package/mesa3d/Config.in | 1 -
 1 file changed, 1 deletion(-)
package/mesa3d/Config.in +0 -1
index 16d77f42c2..6f78da174c 100644
@@ -106,7 +106,6 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_ETNAVIV
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
-	select BR2_PACKAGE_MESA3D_OPENGL_EGL
 	help
 	  Mesa driver for Vivante GPUs.
 
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH v2 2/5 package/mesa3d: Select LIBDRM_FREEDRENO for freedreno

The mesa3d freedreno driver is not usable without the corresponding libdrm support for this platform, so select LIBDRM_FREEDRENO.

---
Changes since v1:
- None

 package/mesa3d/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/mesa3d/Config.in +1 -0
index 6f78da174c..dd512d9b76 100644
@@ -112,6 +112,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
 	bool "Gallium freedreno driver"
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_FREEDRENO
 	select BR2_PACKAGE_MESA3D_GALLIUM_KMSRO
 	help
 	  Mesa driver for Freedreno GPUs.
Signature · 1 line
2.17.1
author reviewer
#2 lore raw

PATCH v2 3/5 configs/imx6-sabresd_qt5: Select MESA3D_OPENGL_EGL

In reply to Fabio Estevam

Now that MESA3D_OPENGL_EGL is not automatically selected by the mesa3d etnaviv driver, explicitly select it in the config file.

---
Changes since v1:
- Mention mesa3d etanviv instead of kmscube in the commit log

 configs/imx6-sabresd_qt5_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/imx6-sabresd_qt5_defconfig +1 -0
index 47c00284d9..647be06d00 100644
@@ -50,6 +50,7 @@ BR2_PACKAGE_MESA3D=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
 BR2_PACKAGE_MESA3D_OPENGL_ES=y
+BR2_PACKAGE_MESA3D_OPENGL_EGL=y
 
 # Fonts
 BR2_PACKAGE_BITSTREAM_VERA=y
Signature · 1 line
2.17.1
author reviewer
#3 lore raw

PATCH v2 4/5 configs/engicam_imx6qdl_icore_qt5: Select MESA3D_OPENGL_EGL

In reply to Fabio Estevam

Now that MESA3D_OPENGL_EGL is not automatically selected by the mesa3d etnaviv driver, explicitly select it in the config file.

---
Changes since v1:
- Mention mesa3d etanviv instead of kmscube in the commit log

 configs/engicam_imx6qdl_icore_qt5_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/engicam_imx6qdl_icore_qt5_defconfig +1 -0
index 4d3d4e3a22..62d3008b4d 100644
@@ -63,6 +63,7 @@ BR2_PACKAGE_MESA3D=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
 BR2_PACKAGE_MESA3D_OPENGL_ES=y
+BR2_PACKAGE_MESA3D_OPENGL_EGL=y
 
 # qt5 demo packages
 BR2_PACKAGE_GLMARK2=y
Signature · 1 line
2.17.1
author reviewer
#4 lore raw

PATCH v2 5/5 configs/imx6-sabresd_qt5: Select LIBV4L_UTILS

In reply to Fabio Estevam

Select LIBV4L_UTILS so that camera capture pipelines can be configured.

---
Changes since v1:
- None

 configs/imx6-sabresd_qt5_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/imx6-sabresd_qt5_defconfig +1 -0
index 647be06d00..0b11225b72 100644
@@ -65,6 +65,7 @@ BR2_PACKAGE_LIBERATION=y
 BR2_PACKAGE_GLMARK2=y
 BR2_PACKAGE_KMSCUBE=y
 BR2_PACKAGE_LIBV4L=y
+BR2_PACKAGE_LIBV4L_UTILS=y
 BR2_PACKAGE_MESA3D_DEMOS=y
 
 # Qt5
Signature · 1 line
2.17.1
#5 lore raw

PATCH v2 1/5 package/mesa3d: Do not select MESA3D_OPENGL_EGL for etnaviv

In reply to Fabio Estevam
Quoted 8 lines · On Thu, 9 Apr 2020 09:35:14 -0300 Fabio Estevam <[email protected]> wrote:

As suggested by Thomas, BR2_PACKAGE_MESA3D_OPENGL_EGL should not be automatically selected by the etnaviv driver.

---
Changes since v1:
- None

Thanks, series applied!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com