perf stat: Zero ena and run for interval mode
PATCH 1/1 perf stat: Zero ena and run for interval mode
As the code comments in perf_stat_process_counter() say, we calculate counter's data every interval, and the display code shows ps->res_stats avg value. We need to zero the stats for interval mode.
But the current code only zeros the res_stats[0], it doesn't zero the res_stats[1] and res_stats[2], which are for ena and run of counter.
This patch zeros the whole res_stats[] for interval mode.
--- tools/perf/util/stat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/perf/util/stat.c +4 -2
@@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,* interval mode, otherwise overall avg running * averages will be shown for each interval. */ -if (config->interval) -init_stats (ps->res_stats); +if (config->interval) { +for (i =0 ; i <3 ; i++) +init_stats (&ps->res_stats[i]); + }if (counter->per_pkg)zero_per_pkg (counter);
Signature · 1 line
2.17.1
Quoted 5 lines · Jin Yao
As the code comments in
perf_stat_process_counter()say, we calculate counter's data every interval, and the display code showsps->res_statsavg value. We need to zero the stats for interval mode.
Quoted 7 lines
But the current code only zeros the res_stats[0], it doesn't zero the res_stats[1] and res_stats[2], which are for ena and run of counter.
This patch zeros the whole res_stats[] for interval mode.
Signed-off-by Jin Yao <[email protected]>
nice catch ;-)
thanks,
jirka
Quoted 24 lines
--- tools/perf/util/stat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)tools/perf/util/stat.c +4
-2@@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,* interval mode, otherwise overall avg running * averages will be shown for each interval. */ -if (config->interval) -init_stats (ps->res_stats); +if (config->interval) { +for (i =0 ; i <3 ; i++) +init_stats (&ps->res_stats[i]); + }if (counter->per_pkg)zero_per_pkg (counter);Signature · 1 line
2.17.1
Arnaldo Carvalho de Melo
AppliedEm Thu, Apr 09, 2020 at 05:43:32PM +0200, Jiri Olsa escreveu:
Quoted 10 lines · Jin Yao
Quoted 9 lines
As the code comments in
perf_stat_process_counter()say, we calculate counter's data every interval, and the display code showsps->res_statsavg value. We need to zero the stats for interval mode.But the current code only zeros the res_stats[0], it doesn't zero the res_stats[1] and res_stats[2], which are for ena and run of counter.
Quoted 7 lines
Quoted 3 lines
This patch zeros the whole res_stats[] for interval mode.
Signed-off-by Jin Yao <[email protected]>nice catch ;-)
Acked-by Jiri Olsa <[email protected]>
Thanks, applied, together with the:
51fd2df1e882 ("perf stat: Fix interval output values")
you provided under private cover.
- Arnaldo
Quoted 28 lines
thanks,
jirkaQuoted 24 lines
--- tools/perf/util/stat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)tools/perf/util/stat.c +4
-2@@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,* interval mode, otherwise overall avg running * averages will be shown for each interval. */ -if (config->interval) -init_stats (ps->res_stats); +if (config->interval) { +for (i =0 ; i <3 ; i++) +init_stats (&ps->res_stats[i]); + }if (counter->per_pkg)zero_per_pkg (counter);Signature · 1 line
2.17.1
Signature · 1 line
- Arnaldo
[tip: perf/core] perf stat: Zero all the 'ena' and 'run' array slot stats for interval mode
In reply to Jin YaoThe following commit has been merged into the perf/core branch of tip:
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 0e0bf1ea1147fcf74eab19c2d3c853cc3740a72f Gitweb: https://git.kernel.org/tip/0e0bf1ea1147fcf74eab19c2d3c853cc3740a72f Author: Jin Yao <[email protected]> AuthorDate: Thu, 09 Apr 2020 15:07:55 +08:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Wed, 22 Apr 2020 15:51:01 -03:00
perf stat: Zero all the 'ena' and 'run' array slot stats for interval mode
As the code comments in perf_stat_process_counter() say, we calculate counter's data every interval, and the display code shows ps->res_stats avg value. We need to zero the stats for interval mode.
But the current code only zeros the res_stats[0], it doesn't zero the res_stats[1] and res_stats[2], which are for ena and run of counter.
This patch zeros the whole res_stats[] for interval mode.
--- tools/perf/util/stat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/perf/util/stat.c +4 -2
@@ -368,8 +368,10 @@ int perf_stat_process_counter(struct perf_stat_config *config,* interval mode, otherwise overall avg running * averages will be shown for each interval. */ -if (config->interval) -init_stats (ps->res_stats); +if (config->interval) { +for (i =0 ; i <3 ; i++) +init_stats (&ps->res_stats[i]); + }if (counter->per_pkg)zero_per_pkg (counter);