SAGV support for Gen12+
Subsystems (3)
v22 cover SAGV support for Gen12+
For Gen11+ platforms BSpec suggests disabling specific QGV points separately, depending on bandwidth limitations and current display configuration. Thus it required adding a new PCode request for disabling QGV points and some refactoring of already existing SAGV code.
Also had to refactor intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+.
Stanislav Lisovskiy (13):
drm/i915: Start passing latency as parameter drm/i915: Eliminate magic numbers "0" and "1" from color plane drm/i915: Introduce skl_plane_wm_level accessor. drm/i915: Add intel_atomic_get_bw_*_state helpers drm/i915: Prepare to extract gen specific functions from
intel_can_enable_sagv
drm/i915: Add pre/post plane updates for SAGV drm/i915: Use bw state for per crtc SAGV evaluation drm/i915: Separate icl and skl SAGV checking drm/i915: Add TGL+ SAGV support
drm/i915: Added required new PCode commands
drm/i915: Rename bw_state to new_bw_state
drm/i915: Restrict qgv points which don't have enough bandwidth. drm/i915: Enable SAGV support for Gen12
drivers/gpu/drm/i915/display/intel_bw.c | 191 +++++-- drivers/gpu/drm/i915/display/intel_bw.h | 24 + drivers/gpu/drm/i915/display/intel_display.c | 21 +- .../drm/i915/display/intel_display_types.h | 11 + drivers/gpu/drm/i915/i915_reg.h | 5 + drivers/gpu/drm/i915/intel_pm.c | 476 +++++++++++++++--- drivers/gpu/drm/i915/intel_pm.h | 8 +- drivers/gpu/drm/i915/intel_sideband.c | 2 + 8 files changed, 604 insertions(+), 134 deletions(-)
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 1/13 drm/i915: Start passing latency as parameter
We need to start passing memory latency as a
parameter when calculating plane wm levels,
as latency can get changed in different
circumstances(for example with or without SAGV).
So we need to be more flexible on that matter.
v2: Changed latency type from u32 to unsigned int(Ville Syrjälä)
--- drivers/gpu/drm/i915/intel_pm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +8 -4
@@ -4016,6 +4016,7 @@ static int skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int color_plane);static void skl_compute_plane_wm (const struct intel_crtc_state *crtc_state,int level, +unsigned int latency,const struct skl_wm_params *wp,const struct skl_wm_level *result_prev,struct skl_wm_level *result/* out */ );
@@ -4038,7 +4039,9 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,drm_WARN_ON (&dev_priv->drm, ret);for (level =0 ; level <= max_level; level++) { -skl_compute_plane_wm (crtc_state, level, &wp, &wm, &wm); +unsigned int latency = dev_priv->wm.skl_latency[level]; + +skl_compute_plane_wm (crtc_state, level, latency, &wp, &wm, &wm);if (wm.min_ddb_alloc ==U16_MAX )break ;
@@ -4972,12 +4975,12 @@ static bool skl_wm_has_lines(struct drm_i915_private *dev_priv, int level)static void skl_compute_plane_wm (const struct intel_crtc_state *crtc_state,int level, +unsigned int latency,const struct skl_wm_params *wp,const struct skl_wm_level *result_prev,struct skl_wm_level *result/* out */ ) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev); -u32 latency = dev_priv->wm.skl_latency[level];uint_fixed_16_16_t method1, method2;uint_fixed_16_16_t selected_result;u32 res_blocks, res_lines, min_ddb_alloc =0 ;
@@ -5106,9 +5109,10 @@ skl_compute_wm_levels(const struct intel_crtc_state *crtc_state,for (level =0 ; level <= max_level; level++) {struct skl_wm_level *result = &levels[level]; +unsigned int latency = dev_priv->wm.skl_latency[level]; -skl_compute_plane_wm (crtc_state, level, wm_params, - result_prev, result); +skl_compute_plane_wm (crtc_state, level, latency, + wm_params, result_prev, result); result_prev = result; }
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 01/13] drm/i915: Start passing latency as parameter
Quoted 10 lines · Stanislav Lisovskiy
We need to start passing memory latency as a
parameter when calculating plane wm levels,
as latency can get changed in different
circumstances(for example with or without SAGV).
So we need to be more flexible on that matter.v2: Changed latency type from u32 to unsigned int(Ville Syrjälä)
Reviewed-by Ville Syrjälä <[email protected]>Signed-off-by Stanislav Lisovskiy <[email protected]>
Pushed this one. Thanks.
Quoted 56 lines
--- drivers/gpu/drm/i915/intel_pm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_pm.c +8
-4@@ -4016,6 +4016,7 @@ static int skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int color_plane);static void skl_compute_plane_wm (const struct intel_crtc_state *crtc_state,int level, +unsigned int latency,const struct skl_wm_params *wp,const struct skl_wm_level *result_prev,struct skl_wm_level *result/* out */ );@@ -4038,7 +4039,9 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,drm_WARN_ON (&dev_priv->drm, ret);for (level =0 ; level <= max_level; level++) { -skl_compute_plane_wm (crtc_state, level, &wp, &wm, &wm); +unsigned int latency = dev_priv->wm.skl_latency[level]; + +skl_compute_plane_wm (crtc_state, level, latency, &wp, &wm, &wm);if (wm.min_ddb_alloc ==U16_MAX )break ;@@ -4972,12 +4975,12 @@ static bool skl_wm_has_lines(struct drm_i915_private *dev_priv, int level)static void skl_compute_plane_wm (const struct intel_crtc_state *crtc_state,int level, +unsigned int latency,const struct skl_wm_params *wp,const struct skl_wm_level *result_prev,struct skl_wm_level *result/* out */ ) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev); -u32 latency = dev_priv->wm.skl_latency[level];uint_fixed_16_16_t method1, method2;uint_fixed_16_16_t selected_result;u32 res_blocks, res_lines, min_ddb_alloc =0 ;@@ -5106,9 +5109,10 @@ skl_compute_wm_levels(const struct intel_crtc_state *crtc_state,for (level =0 ; level <= max_level; level++) {struct skl_wm_level *result = &levels[level]; +unsigned int latency = dev_priv->wm.skl_latency[level]; -skl_compute_plane_wm (crtc_state, level, wm_params, - result_prev, result); +skl_compute_plane_wm (crtc_state, level, latency, + wm_params, result_prev, result); result_prev = result; }Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 2/13 drm/i915: Eliminate magic numbers "0" and "1" from color plane
In reply to Stanislav LisovskiyAccording to many computer science sources - magic values in code _are_ _bad_. For many reasons: the reason is that "0" or "1" or whatever magic values confuses and doesn't give any info why this parameter is this value and what it's meaning is.
I renamed "0" to COLOR_PLANE_Y and "1" to COLOR_PLANE_UV, because we in fact already use this naming in many other places and function names, when dealing with color planes.
v2: Removed long line to make checkpatch happy.
--- .../drm/i915/display/intel_display_types.h | 5 +++ drivers/gpu/drm/i915/intel_pm.c | 42 ++++++++++--------- 2 files changed, 27 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/display/intel_display_types.h +5 -0
@@ -691,6 +691,11 @@ struct skl_plane_wm {bool is_planar; }; +enum color_plane { +COLOR_PLANE_Y , +COLOR_PLANE_UV +}; +struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ]; };
drivers/gpu/drm/i915/intel_pm.c +22 -20
154 lines not on this page · raw message
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 02/13] drm/i915: Eliminate magic numbers "0" and "1" from color plane
Quoted 9 lines · Stanislav Lisovskiy
According to many computer science sources - magic values in code _are_ _bad_. For many reasons: the reason is that "0" or "1" or whatever magic values confuses and doesn't give any info why this parameter is this value and what it's meaning is.
I renamed "0" toCOLOR_PLANE_Yand "1" toCOLOR_PLANE_UV, because we in fact already use this naming in many other places and function names, when dealing with color planes.
Quoted 6 lines
v2: Removed long line to make checkpatch happy.
Signed-off-by Stanislav Lisovskiy <[email protected]>--- .../drm/i915/display/intel_display_types.h | 5 +++ drivers/gpu/drm/i915/intel_pm.c | 42 ++++++++++---------
Still super inconsistent with the rest of the driver. Also there's the fact that wm_uv doesn't even exist on icl+ so the Y vs. UV naming isn't even accurate in a bunch of places.
IMO just drop this for now. We can argue ab out this sort of stuff later if we figure out a way to make it consistent across the whole driver.
Quoted 193 lines
2 files changed, 27 insertions(+), 20 deletions(-)drivers/gpu/drm/i915/display/intel_display_types.h +5
-0@@ -691,6 +691,11 @@ struct skl_plane_wm {bool is_planar; }; +enum color_plane { +COLOR_PLANE_Y , +COLOR_PLANE_UV +}; +struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ]; };drivers/gpu/drm/i915/intel_pm.c +22
-20@@ -4013,7 +4013,7 @@ static int skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int width, const struct drm_format_info *format, u64 modifier, unsigned int rotation, u32 plane_pixel_rate, struct skl_wm_params *wp, - int color_plane); + enum color_plane); static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, int level, unsigned int latency,@@ -4035,7 +4035,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,drm_format_info (DRM_FORMAT_ARGB8888 ),DRM_FORMAT_MOD_LINEAR ,DRM_MODE_ROTATE_0 , - crtc_state->pixel_rate, &wp, 0); + crtc_state->pixel_rate, &wp, COLOR_PLANE_Y);drm_WARN_ON (&dev_priv->drm, ret);for (level =0 ; level <= max_level; level++) {@@ -4431,7 +4431,7 @@ static u8 skl_compute_dbuf_slices(const struct intel_crtc_state *crtc_state,static u64 skl_plane_relative_data_rate (const struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -int color_plane) +enum color_plane color_plane) {struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane);const struct drm_framebuffer *fb = plane_state->hw.fb;@@ -4446,7 +4446,7 @@ skl_plane_relative_data_rate(const struct intel_crtc_state *crtc_state,if (plane->id ==PLANE_CURSOR )return 0 ; -if (color_plane ==1 && +if (color_plane ==COLOR_PLANE_UV && !intel_format_info_is_yuv_semiplanar (fb->format, fb->modifier))return 0 ;@@ -4459,7 +4459,7 @@ skl_plane_relative_data_rate(const struct intel_crtc_state *crtc_state, height =drm_rect_height (&plane_state->uapi.src) >>16 ;/* UV plane does 1/2 pixel sub-sampling */ -if (color_plane ==1 ) { +if (color_plane ==COLOR_PLANE_UV ) { width /=2 ; height /=2 ; }@@ -4489,12 +4489,12 @@ skl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,u64 rate;/* packed/y */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_Y ); plane_data_rate[plane_id] = rate; total_data_rate += rate;/* uv-plane */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,1 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_UV ); uv_plane_data_rate[plane_id] = rate; total_data_rate += rate; }@@ -4516,7 +4516,7 @@ icl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,u64 rate;if (!plane_state->planar_linked_plane) { - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_Y ); plane_data_rate[plane_id] = rate; total_data_rate += rate; }else {@@ -4533,12 +4533,14 @@ icl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,continue ;/* Y plane rate is calculated on the slave */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state, +COLOR_PLANE_Y ); y_plane_id = plane_state->planar_linked_plane->id; plane_data_rate[y_plane_id] = rate; total_data_rate += rate; - rate =skl_plane_relative_data_rate (crtc_state, plane_state,1 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state, +COLOR_PLANE_UV ); plane_data_rate[plane_id] = rate; total_data_rate += rate; }@@ -4854,14 +4856,14 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int width, const struct drm_format_info *format, u64 modifier, unsigned int rotation, u32 plane_pixel_rate, struct skl_wm_params *wp, - int color_plane) + enum color_plane color_plane) { struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);u32 interm_pbpl;/* only planar format has two planes */ -if (color_plane ==1 && +if (color_plane ==COLOR_PLANE_UV && !intel_format_info_is_yuv_semiplanar (format, modifier)) {drm_dbg_kms (&dev_priv->drm,"Non planar format have single plane\n" );@@ -4878,7 +4880,7 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, wp->is_planar =intel_format_info_is_yuv_semiplanar (format, modifier); wp->width = width; -if (color_plane ==1 && wp->is_planar) +if (color_plane ==COLOR_PLANE_UV && wp->is_planar) wp->width /=2 ; wp->cpp = format->cpp[color_plane];@@ -4945,7 +4947,7 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state,static int skl_compute_plane_wm_params (const struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -struct skl_wm_params *wp,int color_plane) +struct skl_wm_params *wp,enum color_plane color_plane) {const struct drm_framebuffer *fb = plane_state->hw.fb;int width;@@ -5187,7 +5189,7 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *crtc_state,static int skl_build_plane_wm_single (struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -enum plane_id plane_id,int color_plane) +enum plane_id plane_id,enum color_plane color_plane) {struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane_id];struct skl_wm_params wm_params;@@ -5216,7 +5218,7 @@ static int skl_build_plane_wm_uv(struct intel_crtc_state *crtc_state,/* uv plane watermarks must also be validated for NV12/Planar */ ret =skl_compute_plane_wm_params (crtc_state, plane_state, - &wm_params,1 ); + &wm_params,COLOR_PLANE_UV );if (ret)return ret;@@ -5237,7 +5239,7 @@ static int skl_build_plane_wm(struct intel_crtc_state *crtc_state,return 0 ; ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,0 ); + plane_id,COLOR_PLANE_Y );if (ret)return ret;@@ -5270,17 +5272,17 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state, fb->format->num_planes == 1); ret =skl_build_plane_wm_single (crtc_state, plane_state, - y_plane_id,0 ); + y_plane_id,COLOR_PLANE_Y );if (ret)return ret; ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,1 ); + plane_id,COLOR_PLANE_UV );if (ret)return ret; }else if (intel_wm_plane_visible (crtc_state, plane_state)) { ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,0 ); + plane_id,COLOR_PLANE_Y );if (ret)return ret; }Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 02/13] drm/i915: Eliminate magic numbers "0" and "1" from color plane
Quoted 17 lines · Ville Syrjälä
Quoted 9 lines · Stanislav Lisovskiy
According to many computer science sources - magic values in code _are_ _bad_. For many reasons: the reason is that "0" or "1" or whatever magic values confuses and doesn't give any info why this parameter is this value and what it's meaning is.
I renamed "0" toCOLOR_PLANE_Yand "1" toCOLOR_PLANE_UV, because we in fact already use this naming in many other places and function names, when dealing with color planes.Quoted 6 lines
v2: Removed long line to make checkpatch happy.
Signed-off-by Stanislav Lisovskiy <[email protected]>--- .../drm/i915/display/intel_display_types.h | 5 +++ drivers/gpu/drm/i915/intel_pm.c | 42 ++++++++++---------
Quoted 7 lines
Still super inconsistent with the rest of the driver. Also there's the fact that
wm_uvdoesn't even exist on icl+ so the Y vs. UV naming isn't even accurate in a bunch of places.IMO just drop this for now. We can argue ab out this sort of stuff later if we figure out a way to make it consistent across the whole driver.
Ok, not saying that this is the best solution, just think that we should not have expressions like "if (color_plane == 1)" like now.
Good article about this:
https://users.ece.cmu.edu/~eno/coding/CCodingStandard.html#nomagic
Stan
Quoted 180 lines
Quoted 180 lines
2 files changed, 27 insertions(+), 20 deletions(-)drivers/gpu/drm/i915/display/intel_display_types.h +5
-0@@ -691,6 +691,11 @@ struct skl_plane_wm {bool is_planar; }; +enum color_plane { +COLOR_PLANE_Y , +COLOR_PLANE_UV +}; +struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ]; };drivers/gpu/drm/i915/intel_pm.c +20
-18@@ -4013,7 +4013,7 @@ static int skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int width, const struct drm_format_info *format, u64 modifier, unsigned int rotation, u32 plane_pixel_rate, struct skl_wm_params *wp, - int color_plane); + enum color_plane); static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, int level, unsigned int latency,@@ -4035,7 +4035,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,drm_format_info (DRM_FORMAT_ARGB8888 ),DRM_FORMAT_MOD_LINEAR ,DRM_MODE_ROTATE_0 , - crtc_state->pixel_rate, &wp, 0); + crtc_state->pixel_rate, &wp, COLOR_PLANE_Y);drm_WARN_ON (&dev_priv->drm, ret);for (level =0 ; level <= max_level; level++) {@@ -4431,7 +4431,7 @@ static u8 skl_compute_dbuf_slices(const struct intel_crtc_state *crtc_state,static u64 skl_plane_relative_data_rate (const struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -int color_plane) +enum color_plane color_plane) {struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane);const struct drm_framebuffer *fb = plane_state->hw.fb;@@ -4446,7 +4446,7 @@ skl_plane_relative_data_rate(const struct intel_crtc_state *crtc_state,if (plane->id ==PLANE_CURSOR )return 0 ; -if (color_plane ==1 && +if (color_plane ==COLOR_PLANE_UV && !intel_format_info_is_yuv_semiplanar (fb->format, fb->modifier))return 0 ;@@ -4459,7 +4459,7 @@ skl_plane_relative_data_rate(const struct intel_crtc_state *crtc_state, height =drm_rect_height (&plane_state->uapi.src) >>16 ;/* UV plane does 1/2 pixel sub-sampling */ -if (color_plane ==1 ) { +if (color_plane ==COLOR_PLANE_UV ) { width /=2 ; height /=2 ; }@@ -4489,12 +4489,12 @@ skl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,u64 rate;/* packed/y */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_Y ); plane_data_rate[plane_id] = rate; total_data_rate += rate;/* uv-plane */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,1 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_UV ); uv_plane_data_rate[plane_id] = rate; total_data_rate += rate; }@@ -4516,7 +4516,7 @@ icl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,u64 rate;if (!plane_state->planar_linked_plane) { - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state,COLOR_PLANE_Y ); plane_data_rate[plane_id] = rate; total_data_rate += rate; }else {@@ -4533,12 +4533,14 @@ icl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,continue ;/* Y plane rate is calculated on the slave */ - rate =skl_plane_relative_data_rate (crtc_state, plane_state,0 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state, +COLOR_PLANE_Y ); y_plane_id = plane_state->planar_linked_plane->id; plane_data_rate[y_plane_id] = rate; total_data_rate += rate; - rate =skl_plane_relative_data_rate (crtc_state, plane_state,1 ); + rate =skl_plane_relative_data_rate (crtc_state, plane_state, +COLOR_PLANE_UV ); plane_data_rate[plane_id] = rate; total_data_rate += rate; }@@ -4854,14 +4856,14 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, int width, const struct drm_format_info *format, u64 modifier, unsigned int rotation, u32 plane_pixel_rate, struct skl_wm_params *wp, - int color_plane) + enum color_plane color_plane) { struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);u32 interm_pbpl;/* only planar format has two planes */ -if (color_plane ==1 && +if (color_plane ==COLOR_PLANE_UV && !intel_format_info_is_yuv_semiplanar (format, modifier)) {drm_dbg_kms (&dev_priv->drm,"Non planar format have single plane\n" );@@ -4878,7 +4880,7 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, wp->is_planar =intel_format_info_is_yuv_semiplanar (format, modifier); wp->width = width; -if (color_plane ==1 && wp->is_planar) +if (color_plane ==COLOR_PLANE_UV && wp->is_planar) wp->width /=2 ; wp->cpp = format->cpp[color_plane];@@ -4945,7 +4947,7 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state,static int skl_compute_plane_wm_params (const struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -struct skl_wm_params *wp,int color_plane) +struct skl_wm_params *wp,enum color_plane color_plane) {const struct drm_framebuffer *fb = plane_state->hw.fb;int width;@@ -5187,7 +5189,7 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *crtc_state,static int skl_build_plane_wm_single (struct intel_crtc_state *crtc_state,const struct intel_plane_state *plane_state, -enum plane_id plane_id,int color_plane) +enum plane_id plane_id,enum color_plane color_plane) {struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane_id];struct skl_wm_params wm_params;@@ -5216,7 +5218,7 @@ static int skl_build_plane_wm_uv(struct intel_crtc_state *crtc_state,/* uv plane watermarks must also be validated for NV12/Planar */ ret =skl_compute_plane_wm_params (crtc_state, plane_state, - &wm_params,1 ); + &wm_params,COLOR_PLANE_UV );if (ret)return ret;@@ -5237,7 +5239,7 @@ static int skl_build_plane_wm(struct intel_crtc_state *crtc_state,return 0 ; ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,0 ); + plane_id,COLOR_PLANE_Y );if (ret)return ret;@@ -5270,17 +5272,17 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state, fb->format->num_planes == 1); ret =skl_build_plane_wm_single (crtc_state, plane_state, - y_plane_id,0 ); + y_plane_id,COLOR_PLANE_Y );if (ret)return ret;
Quoted 18 lines
Quoted 14 lines
drivers/gpu/drm/i915/intel_pm.c +2
-2ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,1 ); + plane_id,COLOR_PLANE_UV );if (ret)return ret; }else if (intel_wm_plane_visible (crtc_state, plane_state)) { ret =skl_build_plane_wm_single (crtc_state, plane_state, - plane_id,0 ); + plane_id,COLOR_PLANE_Y );if (ret)return ret; }Signature · 1 line
2.24.1.485.gad05a3d8e5Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 3/13 drm/i915: Introduce skl_plane_wm_level accessor.
In reply to Stanislav LisovskiyFor future Gen12 SAGV implementation we need to seemlessly alter wm levels calculated, depending on whether we are allowed to enable SAGV or not.
So this accessor will give additional flexibility to do that.
Currently this accessor is still simply working as "pass-through" function. This will be changed in next coming patches from this series.
v2: - plane_id -> plane->id(Ville Syrjälä)
- Moved wm_level var to have more local scope (Ville Syrjälä)
- Renamed yuv to color_plane(Ville Syrjälä) in skl_plane_wm_level
v3: - plane->id -> plane_id(this time for real, Ville Syrjälä)
- Changed colorplane id type from boolean to int as index (Ville Syrjälä)
- Moved crtc_state param so that it is first now (Ville Syrjälä)
- Moved wm_level declaration to tigher scope in skl_write_plane_wm(Ville Syrjälä)
v4: - Started to use enum values for color plane
- Do sizeof for a type what we are memset'ing
- Zero out wm_uv as well(Ville Syrjälä)
--- drivers/gpu/drm/i915/intel_pm.c | 85 ++++++++++++++++++++++++++------- 1 file changed, 67 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +67 -18
@@ -4549,6 +4549,18 @@ icl_get_total_relative_data_rate(struct intel_crtc_state *crtc_state,return total_data_rate; } +static const struct skl_wm_level * +skl_plane_wm_level (const struct intel_crtc_state *crtc_state, +enum plane_id plane_id, +int level, +enum color_plane color_plane) +{ +const struct skl_plane_wm *wm = + &crtc_state->wm.skl.optimal.planes[plane_id]; + +return color_plane ==COLOR_PLANE_Y ? &wm->wm[level] : &wm->uv_wm[level]; +} +static int skl_allocate_pipe_ddb (struct intel_crtc_state *crtc_state) {
@@ -4608,22 +4620,28 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state)*/ for (level =ilk_wm_max_level (dev_priv); level >=0 ; level--) { blocks =0 ; +for_each_plane_id_on_crtc (crtc, plane_id) { -const struct skl_plane_wm *wm = - &crtc_state->wm.skl.optimal.planes[plane_id]; +const struct skl_wm_level *wm_level; +const struct skl_wm_level *wm_uv_level; + + wm_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_Y ); + wm_uv_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_UV );if (plane_id ==PLANE_CURSOR ) { -if (wm->wm[level].min_ddb_alloc > total[PLANE_CURSOR ]) { +if (wm_level->min_ddb_alloc > total[PLANE_CURSOR ]) {drm_WARN_ON (&dev_priv->drm, - wm->wm[level].min_ddb_alloc !=U16_MAX ); + wm_level->min_ddb_alloc !=U16_MAX ); blocks =U32_MAX ;break ; }continue ; } - blocks += wm->wm[level].min_ddb_alloc; - blocks += wm->uv_wm[level].min_ddb_alloc; + blocks += wm_level->min_ddb_alloc; + blocks += wm_uv_level->min_ddb_alloc; }if (blocks <= alloc_size) {
@@ -4646,11 +4664,16 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state)* proportional to its relative data rate. */ for_each_plane_id_on_crtc (crtc, plane_id) { -const struct skl_plane_wm *wm = - &crtc_state->wm.skl.optimal.planes[plane_id]; +const struct skl_wm_level *wm_level; +const struct skl_wm_level *wm_uv_level;u64 rate;u16 extra; + wm_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_Y ); + wm_uv_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_UV ); +if (plane_id ==PLANE_CURSOR )continue ;
@@ -4665,7 +4688,7 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state) extra =min_t (u16, alloc_size,DIV64_U64_ROUND_UP (alloc_size * rate, total_data_rate)); - total[plane_id] = wm->wm[level].min_ddb_alloc + extra; + total[plane_id] = wm_level->min_ddb_alloc + extra; alloc_size -= extra; total_data_rate -= rate;
@@ -4676,7 +4699,7 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state) extra =min_t (u16, alloc_size,DIV64_U64_ROUND_UP (alloc_size * rate, total_data_rate)); - uv_total[plane_id] = wm->uv_wm[level].min_ddb_alloc + extra; + uv_total[plane_id] = wm_uv_level->min_ddb_alloc + extra; alloc_size -= extra; total_data_rate -= rate; }
@@ -4719,9 +4742,16 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state)*/ for (level++; level <=ilk_wm_max_level (dev_priv); level++) {for_each_plane_id_on_crtc (crtc, plane_id) { +const struct skl_wm_level *wm_level; +const struct skl_wm_level *wm_uv_level;struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane_id]; + wm_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_Y ); + wm_uv_level =skl_plane_wm_level (crtc_state, plane_id, + level,COLOR_PLANE_UV ); +/* * We only disable the watermarks for each plane if * they exceed the ddb allocation of said plane. This
@@ -4734,9 +4764,13 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state)* planes must be enabled before the level will be used." * So this is actually safe to do. */ -if (wm->wm[level].min_ddb_alloc > total[plane_id] || - wm->uv_wm[level].min_ddb_alloc > uv_total[plane_id]) -memset (&wm->wm[level],0 ,sizeof (wm->wm[level])); +if (wm_level->min_ddb_alloc > total[plane_id] || + wm_uv_level->min_ddb_alloc > uv_total[plane_id]) { +memset (&wm->wm[level],0 , +sizeof (wm->wm[level])); +memset (&wm->uv_wm[level],0 , +sizeof (wm->uv_wm[level])); + }/* * Wa_1408961008:icl, ehl
@@ -4744,9 +4778,14 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state)*/ if (IS_GEN (dev_priv,11 ) && level ==1 && wm->wm[0 ].plane_en) { - wm->wm[level].plane_res_b = wm->wm[0 ].plane_res_b; - wm->wm[level].plane_res_l = wm->wm[0 ].plane_res_l; - wm->wm[level].ignore_lines = wm->wm[0 ].ignore_lines; + wm_level =skl_plane_wm_level (crtc_state, plane_id, +0 ,COLOR_PLANE_Y ); + wm->wm[level].plane_res_b = + wm_level->plane_res_b; + wm->wm[level].plane_res_l = + wm_level->plane_res_l; + wm->wm[level].ignore_lines = + wm_level->ignore_lines; } } }
@@ -5360,8 +5399,13 @@ void skl_write_plane_wm(struct intel_plane *plane, &crtc_state->wm.skl.plane_ddb_uv[plane_id];for (level =0 ; level <= max_level; level++) { +const struct skl_wm_level *wm_level; +int color_plane =0 ; + + wm_level =skl_plane_wm_level (crtc_state, plane_id, level, color_plane); +skl_write_wm_level (dev_priv,PLANE_WM (pipe, plane_id, level), - &wm->wm[level]); + wm_level); }skl_write_wm_level (dev_priv,PLANE_WM_TRANS (pipe, plane_id), &wm->trans_wm);
@@ -5394,8 +5438,13 @@ void skl_write_cursor_wm(struct intel_plane *plane, &crtc_state->wm.skl.plane_ddb_y[plane_id];for (level =0 ; level <= max_level; level++) { +const struct skl_wm_level *wm_level; +int color_plane =0 ; + + wm_level =skl_plane_wm_level (crtc_state, plane_id, level, color_plane); +skl_write_wm_level (dev_priv,CUR_WM (pipe, level), - &wm->wm[level]); + wm_level); }skl_write_wm_level (dev_priv,CUR_WM_TRANS (pipe), &wm->trans_wm);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 4/13 drm/i915: Add intel_atomic_get_bw_*_state helpers
In reply to Stanislav LisovskiyAdd correspondent helpers to be able to get old/new bandwidth global state object.
v2: - Fixed typo in function call
v3: - Changed new functions naming to use convention proposed
by Jani Nikula, i.e intel_bw_* in intel_bw.c file.
v4: - Change function naming back to intel_atomic* pattern,
was decided to rename in a separate patch series.
v5: - Fix function naming to match existing practices(Ville)
v6: - Removed spurious whitespace
--- drivers/gpu/drm/i915/display/intel_bw.c | 28 ++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bw.h | 9 ++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_bw.c +27 -1
@@ -375,7 +375,33 @@ static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv,return data_rate; } -static struct intel_bw_state * +struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_old_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ; + +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_new_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ; + +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state *intel_atomic_get_bw_state (struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev);
drivers/gpu/drm/i915/display/intel_bw.h +9 -0
@@ -24,6 +24,15 @@ struct intel_bw_state {#define to_intel_bw_state (x) container_of((x), struct intel_bw_state, base) +struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_bw_state (struct intel_atomic_state *state); +void intel_bw_init_hw (struct drm_i915_private *dev_priv);int intel_bw_init (struct drm_i915_private *dev_priv);int intel_bw_atomic_check (struct intel_atomic_state *state);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 04/13] drm/i915: Add intel_atomic_get_bw_*_state helpers
Quoted 25 lines · Stanislav Lisovskiy
Add correspondent helpers to be able to get old/new bandwidth global state object.
v2: - Fixed typo in function call
v3: - Changed new functions naming to use convention proposed
by Jani Nikula, i.e intel_bw_* inintel_bw.cfile.
v4: - Change function naming back to intel_atomic* pattern,
was decided to rename in a separate patch series.
v5: - Fix function naming to match existing practices(Ville)
v6: - Removed spurious whitespaceSigned-off-by Stanislav Lisovskiy <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 28 ++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bw.h | 9 ++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bw.c +0
-0@@ -375,7 +375,33 @@ static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv,return data_rate; }
drivers/gpu/drm/i915/display/intel_bw.c static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bw.c +9
-1-static struct intel_bw_state * +struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_old_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ;
This check isn't actually needed. I think in all the other cases we just get_new_state()
{
return to_foo_state(get_new_state());
}See eg. intel_atomic_get_new_{crtc,plane}_state()
Would be nice to be consistent.
Quoted 43 lines
drivers/gpu/drm/i915/display/intel_bw.c +18
-0+ +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_new_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ; + +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state *intel_atomic_get_bw_state (struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev);drivers/gpu/drm/i915/display/intel_bw.h +9
-0@@ -24,6 +24,15 @@ struct intel_bw_state {#define to_intel_bw_state (x) container_of((x), struct intel_bw_state, base) +struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_bw_state (struct intel_atomic_state *state); +void intel_bw_init_hw (struct drm_i915_private *dev_priv);int intel_bw_init (struct drm_i915_private *dev_priv);int intel_bw_atomic_check (struct intel_atomic_state *state);Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 04/13] drm/i915: Add intel_atomic_get_bw_*_state helpers
Quoted 39 lines · Ville Syrjälä
Quoted 25 lines · Stanislav Lisovskiy
Add correspondent helpers to be able to get old/new bandwidth global state object.
v2: - Fixed typo in function call
v3: - Changed new functions naming to use convention proposed
by Jani Nikula, i.e intel_bw_* inintel_bw.cfile.
v4: - Change function naming back to intel_atomic* pattern,
was decided to rename in a separate patch series.
v5: - Fix function naming to match existing practices(Ville)
v6: - Removed spurious whitespaceSigned-off-by Stanislav Lisovskiy <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 28 ++++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bw.h | 9 ++++++++ 2 files changed, 36 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bw.c +0
-0@@ -375,7 +375,33 @@ static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv,return data_rate; }drivers/gpu/drm/i915/display/intel_bw.c static unsigned int intel_bw_data_rate(struct drm_i915_private *dev_priv, · line 386
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_bw.c +9
-1-static struct intel_bw_state * +struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_old_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ;This check isn't actually needed. I think in all the other cases we just
get_new_state()
Quoted 7 lines
{ return to_foo_state(get_new_state()); }See eg. intel_atomic_get_new_{crtc,plane}_state()
Would be nice to be consistent.
My concern was that will this to_foo_state survive NULL being passed, i.e underlying container_of macro will then do this pointer arithmetics with NULL, i.e:
((type *)(NULL - offsetof(type, member))); })
which doesnt look nice to me, however if you say that this is ok, will change that.
Stan
Quoted 33 lines
Reviewed-by Ville Syrjälä <[email protected]>Quoted 29 lines
drivers/gpu/drm/i915/display/intel_bw.c +18
-0+ +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_global_state *bw_state; + + bw_state =intel_atomic_get_new_global_obj_state (state, &dev_priv->bw_obj); +if (!bw_state) +return NULL ; + +return to_intel_bw_state (bw_state); +} + +struct intel_bw_state *intel_atomic_get_bw_state (struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev);drivers/gpu/drm/i915/display/intel_bw.h +0
-0@@ -24,6 +24,15 @@ struct intel_bw_state {#define to_intel_bw_state (x) container_of((x), struct intel_bw_state, base)
Quoted 18 lines
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_bw.h +9
-0+struct intel_bw_state * +intel_atomic_get_old_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_new_bw_state (struct intel_atomic_state *state); + +struct intel_bw_state * +intel_atomic_get_bw_state (struct intel_atomic_state *state); +void intel_bw_init_hw (struct drm_i915_private *dev_priv);int intel_bw_init (struct drm_i915_private *dev_priv);int intel_bw_atomic_check (struct intel_atomic_state *state);Signature · 1 line
2.24.1.485.gad05a3d8e5Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 5/13 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv
In reply to Stanislav LisovskiyAddressing one of the comments, recommending to extract platform specific code from intel_can_enable_sagv as a preparation, before we are going to add support for tgl+.
--- drivers/gpu/drm/i915/intel_pm.c | 67 +++++++++++++++++++-------------- 1 file changed, 38 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +38 -29
@@ -3757,42 +3757,25 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } -bool intel_can_enable_sagv (struct intel_atomic_state *state) +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) { -struct drm_device *dev = state->base.dev; -struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_crtc *crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev); +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane; -struct intel_crtc_state *crtc_state; -enum pipe pipe; +const struct intel_plane_state *plane_state;int level, latency; -if (!intel_has_sagv (dev_priv)) -return false; - -/* -* If there are no active CRTCs, no additional checks need be performed -*/ -if (hweight8 (state->active_pipes) ==0 ) +if (!crtc_state->hw.active)return true; -/* -* SKL+ workaround: bspec recommends we disable SAGV when we have -* more then one pipe enabled -*/ -if (hweight8 (state->active_pipes) >1 ) -return false; - -/* Since we're now guaranteed to only have one active CRTC... */ - pipe =ffs (state->active_pipes) -1 ; - crtc =intel_get_crtc_for_pipe (dev_priv, pipe); - crtc_state =to_intel_crtc_state (crtc->base.state); - -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) +if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +DRM_DEBUG_KMS ("No SAGV for interlaced mode on pipe %c\n" , +pipe_name (crtc->pipe));return false; + } -for_each_intel_plane_on_crtc (dev, crtc, plane) { -struct skl_plane_wm *wm = +intel_atomic_crtc_state_for_each_plane_state (plane, plane_state, crtc_state) { +const struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane->id];/* Skip this plane if it's not enabled */
@@ -3807,7 +3790,7 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state) latency = dev_priv->wm.skl_latency[level];if (skl_needs_memory_bw_wa (dev_priv) && - plane->base.state->fb->modifier == + plane_state->uapi.fb->modifier ==I915_FORMAT_MOD_X_TILED ) latency +=15 ;
@@ -3823,6 +3806,32 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state)return true; } + +bool intel_can_enable_sagv (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_crtc *crtc; +const struct intel_crtc_state *crtc_state; +enum pipe pipe; + +if (!intel_has_sagv (dev_priv)) +return false; + +/* +* SKL+ workaround: bspec recommends we disable SAGV when we have +* more then one pipe enabled +*/ +if (hweight8 (state->active_pipes) >1 ) +return false; + +/* Since we're now guaranteed to only have one active CRTC... */ + pipe =ffs (state->active_pipes) -1 ; + crtc =intel_get_crtc_for_pipe (dev_priv, pipe); + crtc_state =to_intel_crtc_state (crtc->base.state); + +return intel_crtc_can_enable_sagv (crtc_state); +} +/* * Calculate initial DBuf slice offset, based on slice size * and mask(i.e if slice size is 1024 and second slice is enabled
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v23 5/13 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv
Addressing one of the comments, recommending to extract platform specific code from intel_can_enable_sagv as a preparation, before we are going to add support for tgl+.
v2: - Removed whitespace
--- drivers/gpu/drm/i915/intel_pm.c | 66 ++++++++++++++++++--------------- 1 file changed, 37 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +37 -29
@@ -3757,42 +3757,25 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } -bool intel_can_enable_sagv (struct intel_atomic_state *state) +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) { -struct drm_device *dev = state->base.dev; -struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_crtc *crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev); +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane; -struct intel_crtc_state *crtc_state; -enum pipe pipe; +const struct intel_plane_state *plane_state;int level, latency; -if (!intel_has_sagv (dev_priv)) -return false; - -/* -* If there are no active CRTCs, no additional checks need be performed -*/ -if (hweight8 (state->active_pipes) ==0 ) +if (!crtc_state->hw.active)return true; -/* -* SKL+ workaround: bspec recommends we disable SAGV when we have -* more then one pipe enabled -*/ -if (hweight8 (state->active_pipes) >1 ) -return false; - -/* Since we're now guaranteed to only have one active CRTC... */ - pipe =ffs (state->active_pipes) -1 ; - crtc =intel_get_crtc_for_pipe (dev_priv, pipe); - crtc_state =to_intel_crtc_state (crtc->base.state); - -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) +if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +DRM_DEBUG_KMS ("No SAGV for interlaced mode on pipe %c\n" , +pipe_name (crtc->pipe));return false; + } -for_each_intel_plane_on_crtc (dev, crtc, plane) { -struct skl_plane_wm *wm = +intel_atomic_crtc_state_for_each_plane_state (plane, plane_state, crtc_state) { +const struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane->id];/* Skip this plane if it's not enabled */
@@ -3807,7 +3790,7 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state) latency = dev_priv->wm.skl_latency[level];if (skl_needs_memory_bw_wa (dev_priv) && - plane->base.state->fb->modifier == + plane_state->uapi.fb->modifier ==I915_FORMAT_MOD_X_TILED ) latency +=15 ;
@@ -3823,6 +3806,31 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state)return true; } +bool intel_can_enable_sagv (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_crtc *crtc; +const struct intel_crtc_state *crtc_state; +enum pipe pipe; + +if (!intel_has_sagv (dev_priv)) +return false; + +/* +* SKL+ workaround: bspec recommends we disable SAGV when we have +* more then one pipe enabled +*/ +if (hweight8 (state->active_pipes) >1 ) +return false; + +/* Since we're now guaranteed to only have one active CRTC... */ + pipe =ffs (state->active_pipes) -1 ; + crtc =intel_get_crtc_for_pipe (dev_priv, pipe); + crtc_state =to_intel_crtc_state (crtc->base.state); + +return intel_crtc_can_enable_sagv (crtc_state); +} +/* * Calculate initial DBuf slice offset, based on slice size * and mask(i.e if slice size is 1024 and second slice is enabled
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v23 05/13] drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv
Quoted 49 lines · Stanislav Lisovskiy
Addressing one of the comments, recommending to extract platform specific code from
intel_can_enable_sagvas a preparation, before we are going to add support for tgl+.v2: - Removed whitespace
Signed-off-by Stanislav Lisovskiy <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 66 ++++++++++++++++++--------------- 1 file changed, 37 insertions(+), 29 deletions(-)drivers/gpu/drm/i915/intel_pm.c +5
-19@@ -3757,42 +3757,25 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } -bool intel_can_enable_sagv (struct intel_atomic_state *state) +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) { -struct drm_device *dev = state->base.dev; -struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_crtc *crtc; +struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev); +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane; -struct intel_crtc_state *crtc_state; -enum pipe pipe; +const struct intel_plane_state *plane_state;int level, latency; -if (!intel_has_sagv (dev_priv)) -return false; - -/* -* If there are no active CRTCs, no additional checks need be performed -*/ -if (hweight8 (state->active_pipes) ==0 ) +if (!crtc_state->hw.active)return true; -/* -* SKL+ workaround: bspec recommends we disable SAGV when we have -* more then one pipe enabled -*/ -if (hweight8 (state->active_pipes) >1 ) -return false;
drivers/gpu/drm/i915/intel_pm.c intel_disable_sagv(struct drm_i915_private *dev_priv) · line 3773
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +3
-7- -/* Since we're now guaranteed to only have one active CRTC... */ - pipe =ffs (state->active_pipes) -1 ; - crtc =intel_get_crtc_for_pipe (dev_priv, pipe); - crtc_state =to_intel_crtc_state (crtc->base.state); - -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) +if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) { +DRM_DEBUG_KMS ("No SAGV for interlaced mode on pipe %c\n" , +pipe_name (crtc->pipe));
Why are we adding new debugs in this patch? Please stick to pure refactoring.
drivers/gpu/drm/i915/intel_pm.c intel_disable_sagv(struct drm_i915_private *dev_priv) · line 3777
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +2
-2return false; + } -for_each_intel_plane_on_crtc (dev, crtc, plane) { - struct skl_plane_wm *wm = +intel_atomic_crtc_state_for_each_plane_state (plane, plane_state, crtc_state) {
Too early for this change. Again, pure refactoring please.
Quoted 24 lines
drivers/gpu/drm/i915/intel_pm.c +9
-1+const struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane->id];/* Skip this plane if it's not enabled */ @@ -3807,7 +3790,7 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state) latency = dev_priv->wm.skl_latency[level];if (skl_needs_memory_bw_wa (dev_priv) && - plane->base.state->fb->modifier == + plane_state->uapi.fb->modifier ==I915_FORMAT_MOD_X_TILED ) latency +=15 ;@@ -3823,6 +3806,31 @@ bool intel_can_enable_sagv(struct intel_atomic_state *state)return true; } +bool intel_can_enable_sagv (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +struct intel_crtc *crtc; +const struct intel_crtc_state *crtc_state; +enum pipe pipe; +
drivers/gpu/drm/i915/intel_pm.c bool intel_can_enable_sagv(struct intel_atomic_state *state) · line 3825
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +10
-0+if (!intel_has_sagv (dev_priv)) +return false; + +/* +* SKL+ workaround: bspec recommends we disable SAGV when we have +* more then one pipe enabled +*/ +if (hweight8 (state->active_pipes) >1 ) +return false; +
Lost the active_pipes==0 check here, which means pipe=-1 below.
Quoted 13 lines
drivers/gpu/drm/i915/intel_pm.c +8
-0+/* Since we're now guaranteed to only have one active CRTC... */ + pipe =ffs (state->active_pipes) -1 ; + crtc =intel_get_crtc_for_pipe (dev_priv, pipe); + crtc_state =to_intel_crtc_state (crtc->base.state); + +return intel_crtc_can_enable_sagv (crtc_state); +} +/* * Calculate initial DBuf slice offset, based on slice size * and mask(i.e if slice size is 1024 and second slice is enabled Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 6/13 drm/i915: Add pre/post plane updates for SAGV
In reply to Stanislav LisovskiyLets have a unified way to handle SAGV changes, espoecially considering the upcoming Gen12 changes.
Current "standard" way of doing this in commit_tail is pre/post plane updates, when everything which has to be forbidden and not supported in new config has to be restricted before update and relaxed after plane update.
--- drivers/gpu/drm/i915/display/intel_display.c | 13 ++++--------- drivers/gpu/drm/i915/intel_pm.c | 20 ++++++++++++++++++++ drivers/gpu/drm/i915/intel_pm.h | 2 ++ 3 files changed, 26 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +4 -9
@@ -15349,12 +15349,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_set_cdclk_pre_plane_update (state); -/* -* SKL workaround: bspec recommends we disable the SAGV when we -* have more then one pipe enabled -*/ -if (!intel_can_enable_sagv (state)) -intel_disable_sagv (dev_priv); +intel_sagv_pre_plane_update (state);intel_modeset_verify_disabled (dev_priv, state); }
@@ -15451,11 +15446,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_check_cpu_fifo_underruns (dev_priv);intel_check_pch_fifo_underruns (dev_priv); -if (state->modeset) +if (state->modeset) {intel_verify_planes (state); -if (state->modeset &&intel_can_enable_sagv (state)) -intel_enable_sagv (dev_priv); +intel_sagv_post_plane_update (state); + }drm_atomic_helper_commit_hw_done (&state->base);
drivers/gpu/drm/i915/intel_pm.c +20 -0
@@ -3757,6 +3757,26 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } +void intel_sagv_pre_plane_update (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (!intel_can_enable_sagv (state)) { +intel_disable_sagv (dev_priv); +return ; + } +} + +void intel_sagv_post_plane_update (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (intel_can_enable_sagv (state)) { +intel_enable_sagv (dev_priv); +return ; + } +} +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);
drivers/gpu/drm/i915/intel_pm.h +2 -0
@@ -44,6 +44,8 @@ void vlv_wm_sanitize(struct drm_i915_private *dev_priv);bool intel_can_enable_sagv (struct intel_atomic_state *state);int intel_enable_sagv (struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv); +void intel_sagv_pre_plane_update (struct intel_atomic_state *state); +void intel_sagv_post_plane_update (struct intel_atomic_state *state);bool skl_wm_level_equals (const struct skl_wm_level *l1,const struct skl_wm_level *l2); bool skl_ddb_allocation_overlaps(const struct skl_ddb_entry *ddb,
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 06/13] drm/i915: Add pre/post plane updates for SAGV
Quoted 64 lines · Stanislav Lisovskiy
Lets have a unified way to handle SAGV changes, espoecially considering the upcoming Gen12 changes.
Current "standard" way of doing this in
commit_tailis pre/post plane updates, when everything which has to be forbidden and not supported in new config has to be restricted before update and relaxed after plane update.Signed-off-by Stanislav Lisovskiy <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 13 ++++--------- drivers/gpu/drm/i915/intel_pm.c | 20 ++++++++++++++++++++ drivers/gpu/drm/i915/intel_pm.h | 2 ++ 3 files changed, 26 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/display/intel_display.c +4
-9@@ -15349,12 +15349,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_set_cdclk_pre_plane_update (state); -/* -* SKL workaround: bspec recommends we disable the SAGV when we -* have more then one pipe enabled -*/ -if (!intel_can_enable_sagv (state)) -intel_disable_sagv (dev_priv); +intel_sagv_pre_plane_update (state);intel_modeset_verify_disabled (dev_priv, state); }@@ -15451,11 +15446,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_check_cpu_fifo_underruns (dev_priv);intel_check_pch_fifo_underruns (dev_priv); -if (state->modeset) +if (state->modeset) {intel_verify_planes (state); -if (state->modeset &&intel_can_enable_sagv (state)) -intel_enable_sagv (dev_priv); +intel_sagv_post_plane_update (state); + }drm_atomic_helper_commit_hw_done (&state->base);drivers/gpu/drm/i915/intel_pm.c +7
-0@@ -3757,6 +3757,26 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } +void intel_sagv_pre_plane_update (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (!intel_can_enable_sagv (state)) { +intel_disable_sagv (dev_priv); +return ;
drivers/gpu/drm/i915/intel_pm.c intel_disable_sagv(struct drm_i915_private *dev_priv) · line 3776
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +10
-0+ } +} + +void intel_sagv_post_plane_update (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (intel_can_enable_sagv (state)) { +intel_enable_sagv (dev_priv); +return ;
Pointless returns. With those removed
Quoted 21 lines
drivers/gpu/drm/i915/intel_pm.c +3
-0+ } +} +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);drivers/gpu/drm/i915/intel_pm.h +2
-0@@ -44,6 +44,8 @@ void vlv_wm_sanitize(struct drm_i915_private *dev_priv);bool intel_can_enable_sagv (struct intel_atomic_state *state);int intel_enable_sagv (struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv); +void intel_sagv_pre_plane_update (struct intel_atomic_state *state); +void intel_sagv_post_plane_update (struct intel_atomic_state *state);bool skl_wm_level_equals (const struct skl_wm_level *l1,const struct skl_wm_level *l2); bool skl_ddb_allocation_overlaps(const struct skl_ddb_entry *ddb,Signature · 1 line
2.24.1.485.gad05a3d8e5
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v22 06/13] drm/i915: Add pre/post plane updates for SAGV
Quoted 69 lines · Ville Syrjälä
Quoted 68 lines · Stanislav Lisovskiy
Lets have a unified way to handle SAGV changes, espoecially considering the upcoming Gen12 changes.
Current "standard" way of doing this in
commit_tailis pre/post plane updates, when everything which has to be forbidden and not supported in new config has to be restricted before update and relaxed after plane update.Signed-off-by Stanislav Lisovskiy <[email protected]>--- drivers/gpu/drm/i915/display/intel_display.c | 13 ++++--------- drivers/gpu/drm/i915/intel_pm.c | 20 ++++++++++++++++++++ drivers/gpu/drm/i915/intel_pm.h | 2 ++ 3 files changed, 26 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/display/intel_display.c +4
-9@@ -15349,12 +15349,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_set_cdclk_pre_plane_update (state); -/* -* SKL workaround: bspec recommends we disable the SAGV when we -* have more then one pipe enabled -*/ -if (!intel_can_enable_sagv (state)) -intel_disable_sagv (dev_priv); +intel_sagv_pre_plane_update (state);intel_modeset_verify_disabled (dev_priv, state); }@@ -15451,11 +15446,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)intel_check_cpu_fifo_underruns (dev_priv);intel_check_pch_fifo_underruns (dev_priv); -if (state->modeset) +if (state->modeset) {intel_verify_planes (state); -if (state->modeset &&intel_can_enable_sagv (state)) -intel_enable_sagv (dev_priv); +intel_sagv_post_plane_update (state); + }drm_atomic_helper_commit_hw_done (&state->base);drivers/gpu/drm/i915/intel_pm.c +11
-0@@ -3757,6 +3757,26 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)return 0 ; } +void intel_sagv_pre_plane_update (struct intel_atomic_state *state) +{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (!intel_can_enable_sagv (state)) { +intel_disable_sagv (dev_priv); +return ; + } +} + +void intel_sagv_post_plane_update (struct intel_atomic_state *state)
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c intel_disable_sagv(struct drm_i915_private *dev_priv) · line 3776
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +6
-0+{ +struct drm_i915_private *dev_priv =to_i915 (state->base.dev); + +if (intel_can_enable_sagv (state)) { +intel_enable_sagv (dev_priv); +return ;Pointless returns. With those removed
Agree, my vision was way to blurry after reshuffling.
Quoted 16 lines
Reviewed-by Ville Syrjälä <[email protected]>Quoted 13 lines
drivers/gpu/drm/i915/intel_pm.c +3
-0+ } +} +static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);drivers/gpu/drm/i915/intel_pm.h +0
-0@@ -44,6 +44,8 @@ void vlv_wm_sanitize(struct drm_i915_private *dev_priv);bool intel_can_enable_sagv (struct intel_atomic_state *state);int intel_enable_sagv (struct drm_i915_private *dev_priv);
Quoted 12 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.h +2
-0int intel_disable_sagv (struct drm_i915_private *dev_priv); +void intel_sagv_pre_plane_update (struct intel_atomic_state *state); +void intel_sagv_post_plane_update (struct intel_atomic_state *state);bool skl_wm_level_equals (const struct skl_wm_level *l1,const struct skl_wm_level *l2); bool skl_ddb_allocation_overlaps(const struct skl_ddb_entry *ddb,Signature · 1 line
2.24.1.485.gad05a3d8e5Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 7/13 drm/i915: Use bw state for per crtc SAGV evaluation
In reply to Stanislav LisovskiyFuture platforms require per-crtc SAGV evaluation and serializing global state when those are changed from different commits.
--- drivers/gpu/drm/i915/display/intel_bw.h | 6 +++ drivers/gpu/drm/i915/intel_pm.c | 63 +++++++++++++++++++------ drivers/gpu/drm/i915/intel_pm.h | 4 +- 3 files changed, 58 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.h +6 -0
@@ -18,6 +18,12 @@ struct intel_crtc_state;struct intel_bw_state {struct intel_global_state base; +/* +* Contains a bit mask, used to determine, whether correspondent +* pipe allows SAGV or not. +*/ +u8 pipe_sagv_reject; +unsigned int data_rate[I915_MAX_PIPES ];u8 num_active_planes[I915_MAX_PIPES ]; };
drivers/gpu/drm/i915/intel_pm.c +49 -14
109 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.h +3 -1
@@ -9,6 +9,7 @@#include <linux/types.h> #include "i915_reg.h" +#include "display/intel_bw.h" struct drm_device ;struct drm_i915_private ;
@@ -41,7 +42,8 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc, struct skl_pipe_wm *out);void g4x_wm_sanitize (struct drm_i915_private *dev_priv);void vlv_wm_sanitize (struct drm_i915_private *dev_priv); -bool intel_can_enable_sagv (struct intel_atomic_state *state); +bool intel_has_sagv (struct drm_i915_private *dev_priv); +bool intel_can_enable_sagv (const struct intel_bw_state *bw_state);int intel_enable_sagv (struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv);void intel_sagv_pre_plane_update (struct intel_atomic_state *state);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v23 7/13 drm/i915: Use bw state for per crtc SAGV evaluation
Future platforms require per-crtc SAGV evaluation and serializing global state when those are changed from different commits.
v2: - Add has_sagv check to intel_crtc_can_enable_sagv
so that it sets bit in reject mask.
- Use bw_state in intel_pre/post_plane_enable_sagv instead of atomic state
--- drivers/gpu/drm/i915/display/intel_bw.h | 6 ++ drivers/gpu/drm/i915/intel_pm.c | 98 ++++++++++++++++++++----- drivers/gpu/drm/i915/intel_pm.h | 4 +- 3 files changed, 90 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.h +6 -0
@@ -18,6 +18,12 @@ struct intel_crtc_state;struct intel_bw_state {struct intel_global_state base; +/* +* Contains a bit mask, used to determine, whether correspondent +* pipe allows SAGV or not. +*/ +u8 pipe_sagv_reject; +unsigned int data_rate[I915_MAX_PIPES ];u8 num_active_planes[I915_MAX_PIPES ]; };
drivers/gpu/drm/i915/intel_pm.c +81 -17
160 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.h +3 -1
@@ -9,6 +9,7 @@#include <linux/types.h> #include "i915_reg.h" +#include "display/intel_bw.h" struct drm_device ;struct drm_i915_private ;
@@ -41,7 +42,8 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc, struct skl_pipe_wm *out);void g4x_wm_sanitize (struct drm_i915_private *dev_priv);void vlv_wm_sanitize (struct drm_i915_private *dev_priv); -bool intel_can_enable_sagv (struct intel_atomic_state *state); +bool intel_has_sagv (struct drm_i915_private *dev_priv); +bool intel_can_enable_sagv (const struct intel_bw_state *bw_state);int intel_enable_sagv (struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv);void intel_sagv_pre_plane_update (struct intel_atomic_state *state);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 8/13 drm/i915: Separate icl and skl SAGV checking
In reply to Stanislav LisovskiyIntroduce platform dependent SAGV checking in
combination with bandwidth state pipe SAGV mask.
--- drivers/gpu/drm/i915/intel_pm.c | 71 ++++++++++++++++++++++++++------- 1 file changed, 57 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +57 -14
@@ -3761,8 +3761,23 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)void intel_sagv_pre_plane_update (struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +const struct intel_bw_state *new_bw_state =NULL ; -if (!intel_can_enable_sagv (state)) { +/* +* Just return if we can't control SAGV or don't have it. +* This is different from situation when we have SAGV but just can't +* afford it due to DBuf limitation - in case if SAGV is completely +* disabled in a BIOS, we are not even allowed to send a PCode request, +* as it will throw an error. So have to check it here. +*/ +if (!intel_has_sagv (dev_priv)) +return ; + + new_bw_state =intel_atomic_get_new_bw_state (state); +if (!new_bw_state) +return ; + +if (!intel_can_enable_sagv (new_bw_state)) {intel_disable_sagv (dev_priv);return ; }
@@ -3771,8 +3786,23 @@ void intel_sagv_pre_plane_update(struct intel_atomic_state *state)void intel_sagv_post_plane_update (struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev); +const struct intel_bw_state *new_bw_state =NULL ; -if (intel_can_enable_sagv (state)) { +/* +* Just return if we can't control SAGV or don't have it. +* This is different from situation when we have SAGV but just can't +* afford it due to DBuf limitation - in case if SAGV is completely +* disabled in a BIOS, we are not even allowed to send a PCode request, +* as it will throw an error. So have to check it here. +*/ +if (!intel_has_sagv (dev_priv)) +return ; + + new_bw_state =intel_atomic_get_new_bw_state (state); +if (!new_bw_state) +return ; + +if (intel_can_enable_sagv (new_bw_state)) {intel_enable_sagv (dev_priv);return ; }
@@ -3780,7 +3810,6 @@ void intel_sagv_post_plane_update(struct intel_atomic_state *state)static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) { -struct intel_atomic_state *state =to_intel_atomic_state (crtc_state->uapi.state);struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane;
@@ -3790,13 +3819,6 @@ static bool intel_crtc_can_enable_sagv(const struct intel_crtc_state *crtc_stateif (!crtc_state->hw.active)return true; -/* -* SKL+ workaround: bspec recommends we disable SAGV when we have -* more then one pipe enabled -*/ -if (hweight8 (state->active_pipes) >1 ) -return false; -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) {DRM_DEBUG_KMS ("No SAGV for interlaced mode on pipe %c\n" ,pipe_name (crtc->pipe));
@@ -3835,6 +3857,23 @@ static bool intel_crtc_can_enable_sagv(const struct intel_crtc_state *crtc_statereturn true; } +static bool skl_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) +{ +struct intel_atomic_state *state =to_intel_atomic_state (crtc_state->uapi.state); +/* +* SKL+ workaround: bspec recommends we disable SAGV when we have +* more then one pipe enabled +*/ +if (hweight8 (state->active_pipes) >1 ) +return false; + +return intel_crtc_can_enable_sagv (crtc_state); +} + +static bool icl_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) +{ +return intel_crtc_can_enable_sagv (crtc_state); +}bool intel_can_enable_sagv (const struct intel_bw_state *bw_state) {
@@ -3846,9 +3885,7 @@ static int intel_compute_sagv_mask(struct intel_atomic_state *state)struct drm_i915_private *dev_priv =to_i915 (state->base.dev);int ret;struct intel_crtc *crtc; -const struct intel_crtc_state *crtc_state; -enum pipe pipe; -struct intel_crtc_state *new_crtc_state; +const struct intel_crtc_state *new_crtc_state;struct intel_bw_state *new_bw_state =NULL ;const struct intel_bw_state *old_bw_state =NULL ;int i;
@@ -3858,6 +3895,7 @@ static int intel_compute_sagv_mask(struct intel_atomic_state *state)for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { +bool can_sagv; new_bw_state =intel_atomic_get_bw_state (state);if (IS_ERR (new_bw_state))
@@ -3865,7 +3903,12 @@ static int intel_compute_sagv_mask(struct intel_atomic_state *state) old_bw_state =intel_atomic_get_old_bw_state (state); -if (intel_crtc_can_enable_sagv (new_crtc_state)) +if (INTEL_GEN (dev_priv) >=11 ) + can_sagv =icl_crtc_can_enable_sagv (new_crtc_state); +else + can_sagv =skl_crtc_can_enable_sagv (new_crtc_state); + +if (can_sagv) new_bw_state->pipe_sagv_reject &= ~BIT (crtc->pipe);else new_bw_state->pipe_sagv_reject |=BIT (crtc->pipe);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v23 8/13 drm/i915: Separate icl and skl SAGV checking
Introduce platform dependent SAGV checking in
combination with bandwidth state pipe SAGV mask.
v2: Fix rebase conflict
--- drivers/gpu/drm/i915/intel_pm.c | 39 +++++++++++++++++++++++---------- 1 file changed, 27 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +27 -12
@@ -3810,7 +3810,6 @@ void intel_sagv_post_plane_update(struct intel_atomic_state *state)static bool intel_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) { -struct intel_atomic_state *state =to_intel_atomic_state (crtc_state->uapi.state);struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane;
@@ -3823,13 +3822,6 @@ static bool intel_crtc_can_enable_sagv(const struct intel_crtc_state *crtc_stateif (!crtc_state->hw.active)return true; -/* -* SKL+ workaround: bspec recommends we disable SAGV when we have -* more then one pipe enabled -*/ -if (hweight8 (state->active_pipes) >1 ) -return false; -if (crtc_state->hw.adjusted_mode.flags &DRM_MODE_FLAG_INTERLACE ) {DRM_DEBUG_KMS ("No SAGV for interlaced mode on pipe %c\n" ,pipe_name (crtc->pipe));
@@ -3868,6 +3860,24 @@ static bool intel_crtc_can_enable_sagv(const struct intel_crtc_state *crtc_statereturn true; } +static bool skl_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) +{ +struct intel_atomic_state *state =to_intel_atomic_state (crtc_state->uapi.state); +/* +* SKL+ workaround: bspec recommends we disable SAGV when we have +* more then one pipe enabled +*/ +if (hweight8 (state->active_pipes) >1 ) +return false; + +return intel_crtc_can_enable_sagv (crtc_state); +} + +static bool icl_crtc_can_enable_sagv (const struct intel_crtc_state *crtc_state) +{ +return intel_crtc_can_enable_sagv (crtc_state); +} +bool intel_can_enable_sagv (const struct intel_bw_state *bw_state) {return bw_state->pipe_sagv_reject ==0 ;
@@ -3878,22 +3888,27 @@ static int intel_compute_sagv_mask(struct intel_atomic_state *state)struct drm_i915_private *dev_priv =to_i915 (state->base.dev);int ret;struct intel_crtc *crtc; -const struct intel_crtc_state *crtc_state; -enum pipe pipe; -struct intel_crtc_state *new_crtc_state; +const struct intel_crtc_state *new_crtc_state;struct intel_bw_state *new_bw_state =NULL ;const struct intel_bw_state *old_bw_state =NULL ;int i;for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { +bool can_sagv; + new_bw_state =intel_atomic_get_bw_state (state);if (IS_ERR (new_bw_state))return PTR_ERR (new_bw_state); old_bw_state =intel_atomic_get_old_bw_state (state); -if (intel_crtc_can_enable_sagv (new_crtc_state)) +if (INTEL_GEN (dev_priv) >=11 ) + can_sagv =icl_crtc_can_enable_sagv (new_crtc_state); +else + can_sagv =skl_crtc_can_enable_sagv (new_crtc_state); + +if (can_sagv) new_bw_state->pipe_sagv_reject &= ~BIT (crtc->pipe);else new_bw_state->pipe_sagv_reject |=BIT (crtc->pipe);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 9/13 drm/i915: Add TGL+ SAGV support
In reply to Stanislav LisovskiyStarting from TGL we need to have a separate wm0
values for SAGV and non-SAGV which affects
how calculations are done.
--- drivers/gpu/drm/i915/display/intel_display.c | 8 +- .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/intel_pm.c | 127 +++++++++++++++++- 3 files changed, 129 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +6 -2
@@ -13932,7 +13932,9 @@ static void verify_wm_state(struct intel_crtc *crtc,/* Watermarks */ for (level =0 ; level <= max_level; level++) {if (skl_wm_level_equals (&hw_plane_wm->wm[level], - &sw_plane_wm->wm[level])) + &sw_plane_wm->wm[level]) || + (level ==0 &&skl_wm_level_equals (&hw_plane_wm->wm[level], + &sw_plane_wm->sagv_wm0)))continue ; drm_err(&dev_priv->drm,
@@ -13987,7 +13989,9 @@ static void verify_wm_state(struct intel_crtc *crtc,/* Watermarks */ for (level =0 ; level <= max_level; level++) {if (skl_wm_level_equals (&hw_plane_wm->wm[level], - &sw_plane_wm->wm[level])) + &sw_plane_wm->wm[level]) || + (level ==0 &&skl_wm_level_equals (&hw_plane_wm->wm[level], + &sw_plane_wm->sagv_wm0)))continue ; drm_err(&dev_priv->drm,
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -688,6 +688,8 @@ struct skl_plane_wm {struct skl_wm_level wm[8 ];struct skl_wm_level uv_wm[8 ];struct skl_wm_level trans_wm; +struct skl_wm_level sagv_wm0; +struct skl_wm_level uv_sagv_wm0;bool is_planar; };
@@ -698,6 +700,7 @@ enum color_plane {struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ]; +bool can_sagv; };enum vlv_wm_level {
drivers/gpu/drm/i915/intel_pm.c +120 -7
212 lines not on this page · raw message
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v23 9/13 drm/i915: Add TGL+ SAGV support
Starting from TGL we need to have a separate wm0
values for SAGV and non-SAGV which affects
how calculations are done.
v2: Remove long lines
--- drivers/gpu/drm/i915/display/intel_display.c | 8 +- .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/intel_pm.c | 128 +++++++++++++++++- 3 files changed, 130 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +6 -2
@@ -13932,7 +13932,9 @@ static void verify_wm_state(struct intel_crtc *crtc,/* Watermarks */ for (level =0 ; level <= max_level; level++) {if (skl_wm_level_equals (&hw_plane_wm->wm[level], - &sw_plane_wm->wm[level])) + &sw_plane_wm->wm[level]) || + (level ==0 &&skl_wm_level_equals (&hw_plane_wm->wm[level], + &sw_plane_wm->sagv_wm0)))continue ; drm_err(&dev_priv->drm,
@@ -13987,7 +13989,9 @@ static void verify_wm_state(struct intel_crtc *crtc,/* Watermarks */ for (level =0 ; level <= max_level; level++) {if (skl_wm_level_equals (&hw_plane_wm->wm[level], - &sw_plane_wm->wm[level])) + &sw_plane_wm->wm[level]) || + (level ==0 &&skl_wm_level_equals (&hw_plane_wm->wm[level], + &sw_plane_wm->sagv_wm0)))continue ; drm_err(&dev_priv->drm,
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -688,6 +688,8 @@ struct skl_plane_wm {struct skl_wm_level wm[8 ];struct skl_wm_level uv_wm[8 ];struct skl_wm_level trans_wm; +struct skl_wm_level sagv_wm0; +struct skl_wm_level uv_sagv_wm0;bool is_planar; };
@@ -698,6 +700,7 @@ enum color_plane {struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ]; +bool can_sagv; };enum vlv_wm_level {
drivers/gpu/drm/i915/intel_pm.c +121 -7
213 lines not on this page · raw message
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 10/13 drm/i915: Added required new PCode commands
In reply to Stanislav LisovskiyWe need a new PCode request commands and reply codes to be added as a prepartion patch for QGV points restricting for new SAGV support.
v2: - Extracted those changes into separate patch
(Ville Syrjälä)
v3: - Moved new PCode masks to another place from
PCode commands(Ville)
--- drivers/gpu/drm/i915/i915_reg.h | 5 +++++ drivers/gpu/drm/i915/intel_sideband.c | 2 ++ 2 files changed, 7 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +5 -0
@@ -9085,6 +9085,7 @@ enum {#define GEN7_PCODE_ILLEGAL_DATA 0x3#define GEN11_PCODE_ILLEGAL_SUBCOMMAND 0x4#define GEN11_PCODE_LOCKED 0x6 +#define GEN11_PCODE_REJECTED 0x11#define GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE 0x10#define GEN6_PCODE_WRITE_RC6VIDS 0x4#define GEN6_PCODE_READ_RC6VIDS 0x5
@@ -9106,6 +9107,7 @@ enum {#define ICL_PCODE_MEM_SUBSYSYSTEM_INFO 0xd#define ICL_PCODE_MEM_SS_READ_GLOBAL_INFO (0x0 << 8)#define ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point) (((point) << 16) | (0x1 << 8)) +#define ICL_PCODE_SAGV_DE_MEM_SS_CONFIG 0xe#define GEN6_PCODE_READ_D_COMP 0x10#define GEN6_PCODE_WRITE_D_COMP 0x11#define HSW_PCODE_DE_WRITE_FREQ_REQ 0x17
@@ -9134,6 +9136,9 @@ enum {#define GEN8_GT_SLICE_INFO _MMIO(0x138064)#define GEN8_LSLICESTAT_MASK 0x7 +#define GEN11_PCODE_POINTS_RESTRICTED 0x0 +#define GEN11_PCODE_POINTS_RESTRICTED_MASK 0x1 +#define CHV_POWER_SS0_SIG1 _MMIO(0xa720)#define CHV_POWER_SS1_SIG1 _MMIO(0xa728)#define CHV_SS_PG_ENABLE (1 << 1)
drivers/gpu/drm/i915/intel_sideband.c +2 -0
@@ -370,6 +370,8 @@ static inline int gen7_check_mailbox_status(u32 mbox)return -ENXIO ;case GEN11_PCODE_LOCKED :return -EBUSY ; +case GEN11_PCODE_REJECTED : +return -EACCES ;case GEN7_PCODE_MIN_FREQ_TABLE_GT_RATIO_OUT_OF_RANGE :return -EOVERFLOW ;default :
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 11/13 drm/i915: Rename bw_state to new_bw_state
In reply to Stanislav LisovskiyThat is a preparation patch before next one where we introduce old_bw_state and a bunch of other changes as well.
In a review comment it was suggested to split out at least that renaming into a separate patch, what is done here.
v2: Removed spurious space
--- drivers/gpu/drm/i915/display/intel_bw.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +12 -12
@@ -418,7 +418,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state) {struct drm_i915_private *dev_priv =to_i915 (state->base.dev);struct intel_crtc_state *new_crtc_state, *old_crtc_state; -struct intel_bw_state *bw_state =NULL ; +struct intel_bw_state *new_bw_state =NULL ;unsigned int data_rate, max_data_rate;unsigned int num_active_planes;struct intel_crtc *crtc;
@@ -447,29 +447,29 @@ int intel_bw_atomic_check(struct intel_atomic_state *state) old_active_planes == new_active_planes)continue ; - bw_state =intel_atomic_get_bw_state (state); -if (IS_ERR (bw_state)) -return PTR_ERR (bw_state); + new_bw_state =intel_atomic_get_bw_state (state); +if (IS_ERR (new_bw_state)) +return PTR_ERR (new_bw_state); - bw_state->data_rate[crtc->pipe] = new_data_rate; - bw_state->num_active_planes[crtc->pipe] = new_active_planes; + new_bw_state->data_rate[crtc->pipe] = new_data_rate; + new_bw_state->num_active_planes[crtc->pipe] = new_active_planes;drm_dbg_kms (&dev_priv->drm,"pipe %c data rate %u num active planes %u\n" ,pipe_name (crtc->pipe), - bw_state->data_rate[crtc->pipe], - bw_state->num_active_planes[crtc->pipe]); + new_bw_state->data_rate[crtc->pipe], + new_bw_state->num_active_planes[crtc->pipe]); } -if (!bw_state) +if (!new_bw_state)return 0 ; - ret =intel_atomic_lock_global_state (&bw_state->base); + ret =intel_atomic_lock_global_state (&new_bw_state->base);if (ret)return ret; - data_rate =intel_bw_data_rate (dev_priv, bw_state); - num_active_planes =intel_bw_num_active_planes (dev_priv, bw_state); + data_rate =intel_bw_data_rate (dev_priv, new_bw_state); + num_active_planes =intel_bw_num_active_planes (dev_priv, new_bw_state); max_data_rate =intel_max_data_rate (dev_priv, num_active_planes);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 12/13 drm/i915: Restrict qgv points which don't have enough bandwidth.
In reply to Stanislav LisovskiyAccording to BSpec 53998, we should try to restrict qgv points, which can't provide enough bandwidth for desired display configuration.
Currently we are just comparing against all of
those and take minimum(worst case).
v2: Fixed wrong PCode reply mask, removed hardcoded
values.
v3: Forbid simultaneous legacy SAGV PCode requests and
restricting qgv points. Put the actual restriction to commit function, added serialization(thanks to Ville) to prevent commit being applied out of order in case of nonblocking and/or nomodeset commits.
v4:
- Minor code refactoring, fixed few typos(thanks to James Ausmus)
- Change the naming of qgv point
masking/unmasking functions(James Ausmus).
- Simplify the masking/unmasking operation itself,
as we don't need to mask only single point per request(James Ausmus)
- Reject and stick to highest bandwidth point if SAGV can't be enabled(BSpec)
v5:
- Add new mailbox reply codes, which seems to happen during boot time for TGL and indicate that QGV setting is not yet available.
v6:
- Increase number of supported QGV points to be in sync with BSpec.
v7: - Rebased and resolved conflict to fix build failure.
- Fix NUM_QGV_POINTS to 8 and moved that to header file(James Ausmus)
v8: - Don't report an error if we can't restrict qgv points, as SAGV
can be disabled by BIOS, which is completely legal. So don't make CI panic. Instead if we detect that there is only 1 QGV point accessible just analyze if we can fit the required bandwidth requirements, but no need in restricting.
v9: - Fix wrong QGV transition if we have 0 planes and no SAGV
simultaneously.
v10: - Fix CDCLK corruption, because of global state getting serialized
without modeset, which caused copying of non-calculated cdclk to be copied to dev_priv(thanks to Ville for the hint).
v11: - Remove unneeded headers and spaces(Matthew Roper)
- Remove unneeded intel_qgv_info qi struct from bw check and zero out the needed one(Matthew Roper)
- Changed QGV error message to have more clear meaning(Matthew Roper)
- Use state->modeset_set instead of any_ms(Matthew Roper)
- Moved NUM_SAGV_POINTS from i915_reg.h to i915_drv.h where it's used
- Keep using crtc_state->hw.active instead of .enable(Matthew Roper)
- Moved unrelated changes to other patch(using latency as parameter for plane wm calculation, moved to SAGV refactoring patch)
v12: - Fix rebase conflict with own temporary SAGV/QGV fix.
- Remove unnecessary mask being zero check when unmasking qgv points as this is completely legal(Matt Roper)
- Check if we are setting the same mask as already being set in hardware to prevent error from PCode.
- Fix error message when restricting/unrestricting qgv points to "mask/unmask" which sounds more accurate(Matt Roper)
- Move sagv status setting to icl_get_bw_info from atomic check as this should be calculated only once.(Matt Roper)
- Edited comments for the case when we can't enable SAGV and use only 1 QGV point with highest bandwidth to be more understandable.(Matt Roper)
v13: - Moved max_data_rate in bw check to closer scope(Ville Syrjälä)
- Changed comment for zero new_mask in qgv points masking function to better reflect reality(Ville Syrjälä)
- Simplified bit mask operation in qgv points masking function (Ville Syrjälä)
- Moved intel_qgv_points_mask closer to gen11 SAGV disabling, however this still can't be under modeset condition(Ville Syrjälä)
- Packed qgv_points_mask as u8 and moved closer to pipe_sagv_mask (Ville Syrjälä)
- Extracted PCode changes to separate patch.(Ville Syrjälä)
- Now treat num_planes 0 same as 1 to avoid confusion and returning max_bw as 0, which would prevent choosing QGV point having max bandwidth in case if SAGV is not allowed, as per BSpec(Ville Syrjälä)
- Do the actual qgv_points_mask swap in the same place as all other global state parts like cdclk are swapped. In the next patch, this all will be moved to bw state as global state, once new global state patch series from Ville lands
v14: - Now using global state to serialize access to qgv points
- Added global state locking back, otherwise we seem to read bw state in a wrong way.
v15: - Added TODO comment for near atomic global state locking in
bw code.
v16: - Fixed intel_atomic_bw_* functions to be intel_bw_* as discussed
with Jani Nikula.
- Take bw_state_changed flag into use.
v17: - Moved qgv point related manipulations next to SAGV code, as
those are semantically related(Ville Syrjälä)
- Renamed those into intel_sagv_(pre)|(post)_plane_update (Ville Syrjälä)
v18: - Move sagv related calls from commit tail into
intel_sagv_(pre)|(post)_plane_update(Ville Syrjälä)
v19: - Use intel_atomic_get_bw_(old)|(new)_state which is intended
for commit tail stage.
v20: - Return max bandwidth for 0 planes(Ville)
- Constify old_bw_state in bw_atomic_check(Ville)
- Removed some debugs(Ville)
- Added data rate to debug print when no QGV points(Ville)
- Removed some comments(Ville)
-v21 - Fixed rebase conflict
--- drivers/gpu/drm/i915/display/intel_bw.c | 139 +++++++++++++----- drivers/gpu/drm/i915/display/intel_bw.h | 9 ++ .../drm/i915/display/intel_display_types.h | 3 + drivers/gpu/drm/i915/intel_pm.c | 61 +++++++- drivers/gpu/drm/i915/intel_pm.h | 2 + 5 files changed, 177 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +104 -35
@@ -8,6 +8,9 @@#include "intel_bw.h" #include "intel_display_types.h" #include "intel_sideband.h" +#include "intel_atomic.h" +#include "intel_pm.h" +/* Parameters for Qclk Geyserville (QGV) */ struct intel_qgv_point {
@@ -113,6 +116,26 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv,return 0 ; } +int icl_pcode_restrict_qgv_points (struct drm_i915_private *dev_priv, +u32 points_mask) +{ +int ret; + +/* bspec says to keep retrying for at least 1 ms */ + ret =skl_pcode_request (dev_priv,ICL_PCODE_SAGV_DE_MEM_SS_CONFIG , + points_mask, +GEN11_PCODE_POINTS_RESTRICTED_MASK , +GEN11_PCODE_POINTS_RESTRICTED , +1 ); + +if (ret <0 ) { +DRM_ERROR ("Failed to disable qgv points (%d)\n" , ret); +return ret; + } + +return 0 ; +} +static int icl_get_qgv_points (struct drm_i915_private *dev_priv,struct intel_qgv_info *qi) {
@@ -240,6 +263,16 @@ static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intelbreak ; } +/* +* In case if SAGV is disabled in BIOS, we always get 1 +* SAGV point, but we can't send PCode commands to restrict it +* as it will fail and pointless anyway. +*/ +if (qi.num_points ==1 ) + dev_priv->sagv_status =I915_SAGV_NOT_CONTROLLED ; +else + dev_priv->sagv_status =I915_SAGV_ENABLED ; +return 0 ; }
@@ -248,6 +281,11 @@ static unsigned int icl_max_bw(struct drm_i915_private *dev_priv, {int i; +/* +* Let's return max bw for 0 planes +*/ + num_planes =max (1 , num_planes); +for (i =0 ; i <ARRAY_SIZE (dev_priv->max_bw); i++) {const struct intel_bw_info *bi = &dev_priv->max_bw[i];
@@ -277,34 +315,6 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)icl_get_bw_info (dev_priv, &icl_sa_info); } -static unsigned int intel_max_data_rate (struct drm_i915_private *dev_priv, -int num_planes) -{ -if (INTEL_GEN (dev_priv) >=11 ) { -/* -* Any bw group has same amount of QGV points -*/ -const struct intel_bw_info *bi = - &dev_priv->max_bw[0 ]; -unsigned int min_bw =UINT_MAX ; -int i; - -/* -* FIXME with SAGV disabled maybe we can assume -* point 1 will always be used? Seems to match -* the behaviour observed in the wild. -*/ -for (i =0 ; i < bi->num_qgv_points; i++) { -unsigned int bw =icl_max_bw (dev_priv, num_planes, i); - - min_bw =min (bw, min_bw); - } -return min_bw; - }else { -return UINT_MAX ; - } -} -static unsigned int intel_bw_crtc_num_active_planes (const struct intel_crtc_state *crtc_state) {/*
@@ -419,10 +429,15 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)struct drm_i915_private *dev_priv =to_i915 (state->base.dev);struct intel_crtc_state *new_crtc_state, *old_crtc_state;struct intel_bw_state *new_bw_state =NULL ; -unsigned int data_rate, max_data_rate; +const struct intel_bw_state *old_bw_state =NULL ; +unsigned int data_rate;unsigned int num_active_planes;struct intel_crtc *crtc;int i, ret; +u32 allowed_points =0 ; +unsigned int max_bw_point =0 , max_bw =0 ; +unsigned int num_qgv_points = dev_priv->max_bw[0 ].num_qgv_points; +u32 mask = (1 << num_qgv_points) -1 ;/* FIXME earlier gens need some checks too */ if (INTEL_GEN (dev_priv) <11 )
@@ -469,19 +484,73 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)return ret; data_rate =intel_bw_data_rate (dev_priv, new_bw_state); + data_rate =DIV_ROUND_UP (data_rate,1000 ); + num_active_planes =intel_bw_num_active_planes (dev_priv, new_bw_state); - max_data_rate =intel_max_data_rate (dev_priv, num_active_planes); +for (i =0 ; i < num_qgv_points; i++) { +unsigned int max_data_rate; - data_rate =DIV_ROUND_UP (data_rate,1000 ); + max_data_rate =icl_max_bw (dev_priv, num_active_planes, i); +/* +* We need to know which qgv point gives us +* maximum bandwidth in order to disable SAGV +* if we find that we exceed SAGV block time +* with watermarks. By that moment we already +* have those, as it is calculated earlier in +* intel_atomic_check, +*/ +if (max_data_rate > max_bw) { + max_bw_point = i; + max_bw = max_data_rate; + } +if (max_data_rate >= data_rate) + allowed_points |=BIT (i); +DRM_DEBUG_KMS ("QGV point %d: max bw %d required %d\n" , + i, max_data_rate, data_rate); + } -if (data_rate > max_data_rate) { -drm_dbg_kms (&dev_priv->drm, -"Bandwidth %u MB/s exceeds max available %d MB/s (%d active planes)\n" , - data_rate, max_data_rate, num_active_planes); +/* +* BSpec states that we always should have at least one allowed point +* left, so if we couldn't - simply reject the configuration for obvious +* reasons. +*/ +if (allowed_points ==0 ) { +DRM_DEBUG_KMS ("No QGV points provide sufficient memory" +" bandwidth %d for display configuration.\n" , data_rate);return -EINVAL ; } +/* +* Leave only single point with highest bandwidth, if +* we can't enable SAGV due to the increased memory latency it may +* cause. +*/ +if (!intel_can_enable_sagv (new_bw_state)) { + allowed_points =BIT (max_bw_point); +DRM_DEBUG_KMS ("No SAGV, using single QGV point %d\n" , + max_bw_point); + } +/* +* We store the ones which need to be masked as that is what PCode +* actually accepts as a parameter. +*/ + new_bw_state->qgv_points_mask = (~allowed_points) & mask; + + old_bw_state =intel_atomic_get_old_bw_state (state); +if (!old_bw_state) +return -EINVAL ; + +/* +* If the actual mask had changed we need to make sure that +* the commits are serialized(in case this is a nomodeset, nonblocking) +*/ +if (new_bw_state->qgv_points_mask != old_bw_state->qgv_points_mask) { + ret =intel_atomic_serialize_global_state (&new_bw_state->base); +if (ret) +return ret; + } +return 0 ; }
drivers/gpu/drm/i915/display/intel_bw.h +9 -0
@@ -24,6 +24,13 @@ struct intel_bw_state {*/ u8 pipe_sagv_reject; +/* +* Current QGV points mask, which restricts +* some particular SAGV states, not to confuse +* with pipe_sagv_mask. +*/ +u8 qgv_points_mask; +unsigned int data_rate[I915_MAX_PIPES ];u8 num_active_planes[I915_MAX_PIPES ]; };
@@ -44,5 +51,7 @@ int intel_bw_init(struct drm_i915_private *dev_priv);int intel_bw_atomic_check (struct intel_atomic_state *state);void intel_bw_crtc_update (struct intel_bw_state *bw_state,const struct intel_crtc_state *crtc_state); +int icl_pcode_restrict_qgv_points (struct drm_i915_private *dev_priv, +u32 points_mask);#endif /* __INTEL_BW_H__ */
drivers/gpu/drm/i915/display/intel_display_types.h +3 -0
@@ -698,6 +698,9 @@ enum color_plane {COLOR_PLANE_UV }; +/* BSpec precisely defines this */ +#define NUM_SAGV_POINTS 8 +struct skl_pipe_wm {struct skl_plane_wm planes[I915_MAX_PLANES ];bool can_sagv;
drivers/gpu/drm/i915/intel_pm.c +59 -2
92 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.h +2 -0
@@ -42,6 +42,8 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc, struct skl_pipe_wm *out);void g4x_wm_sanitize (struct drm_i915_private *dev_priv);void vlv_wm_sanitize (struct drm_i915_private *dev_priv); +void intel_sagv_pre_plane_update (struct intel_atomic_state *state); +void intel_sagv_post_plane_update (struct intel_atomic_state *state);bool intel_has_sagv (struct drm_i915_private *dev_priv);bool intel_can_enable_sagv (const struct intel_bw_state *bw_state);int intel_enable_sagv (struct drm_i915_private *dev_priv);
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v22 13/13 drm/i915: Enable SAGV support for Gen12
In reply to Stanislav LisovskiyFlip the switch and enable SAGV support
for Gen12 also.
--- drivers/gpu/drm/i915/intel_pm.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +0 -4
@@ -3638,10 +3638,6 @@ static bool skl_needs_memory_bw_wa(struct drm_i915_private *dev_priv)bool intel_has_sagv (struct drm_i915_private *dev_priv) { -/* HACK! */ -if (IS_GEN (dev_priv,12 )) -return false; -return (IS_GEN9_BC (dev_priv) ||INTEL_GEN (dev_priv) >=10 ) && dev_priv->sagv_status !=I915_SAGV_NOT_CONTROLLED ; }
Signature · 6 lines
2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for SAGV support for Gen12+ (rev14)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev14)
URL : https://patchwork.freedesktop.org/series/75129/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip db3bb77d347e drm/i915: Start passing latency as parameter 39684149a1cb drm/i915: Eliminate magic numbers "0" and "1" from color plane 28f3e791c62a drm/i915: Introduce skl_plane_wm_level accessor. 00989296f52d drm/i915: Add intel_atomic_get_bw_*_state helpers 926c0a7aaf2a drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv -:84: CHECK:LINE_SPACING: Please don't use multiple blank lines #84: FILE: drivers/gpu/drm/i915/intel_pm.c:3809:
+
total: 0 errors, 0 warnings, 1 checks, 93 lines checked f573a32afca5 drm/i915: Add pre/post plane updates for SAGV 7b65af3b3c25 drm/i915: Use bw state for per crtc SAGV evaluation -:111: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #111: FILE: drivers/gpu/drm/i915/intel_pm.c:3861:
+ new_crtc_state, i) {
+
total: 0 errors, 0 warnings, 1 checks, 137 lines checked 7c3a86821437 drm/i915: Separate icl and skl SAGV checking fd7ee6e3d868 drm/i915: Add TGL+ SAGV support
-:217: CHECK:LINE_SPACING: Please don't use multiple blank lines #217: FILE: drivers/gpu/drm/i915/intel_pm.c:5356:
+
+
-:247: WARNING:LONG_LINE: line over 100 characters #247: FILE: drivers/gpu/drm/i915/intel_pm.c:5848:
+ plane->base.base.id, plane->base.name, old_wm->sagv_wm0.plane_res_l,
-:273: WARNING:LONG_LINE: line over 100 characters #273: FILE: drivers/gpu/drm/i915/intel_pm.c:5889:
+ plane->base.base.id, plane->base.name, old_wm->sagv_wm0.min_ddb_alloc,
total: 0 errors, 2 warnings, 1 checks, 247 lines checked 49c46f4edf34 drm/i915: Added required new PCode commands 8324f5130045 drm/i915: Rename bw_state to new_bw_state 9a18dd734b17 drm/i915: Restrict qgv points which don't have enough bandwidth. e967954f905e drm/i915: Enable SAGV support for Gen12
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for SAGV support for Gen12+ (rev14)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev14)
URL : https://patchwork.freedesktop.org/series/75129/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Start passing latency as parameter Okay!
Commit: drm/i915: Eliminate magic numbers "0" and "1" from color plane Okay!
Commit: drm/i915: Introduce skl_plane_wm_level accessor. Okay!
Commit: drm/i915: Add intel_atomic_get_bw_*_state helpers Okay!
Commit: drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv Okay!
Commit: drm/i915: Add pre/post plane updates for SAGV Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for SAGV support for Gen12+ (rev14)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev14)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8285 -> Patchwork_17271
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/index.html
Known issues
------------
Here are the changes found in Patchwork_17271 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][1] -> [FAIL][2] ([i915#262])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/fi-kbl-7500u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-skl-6770hq: [DMESG-WARN][3] ([i915#203]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-skl-6770hq: [SKIP][5] ([fdo#109271]) -> [PASS][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/fi-skl-6770hq/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/fi-skl-6770hq/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-skl-6770hq: [DMESG-WARN][7] ([i915#106]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/fi-skl-6770hq/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/fi-skl-6770hq/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][9] ([i915#62] / [i915#95]) -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/fi-kbl-x1275/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#106]: https://gitlab.freedesktop.org/drm/intel/issues/106
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (51 -> 47)
------------------------------
Additional (1): fi-cml-u2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8285 -> Patchwork_17271
CI-20190529: 20190529
CI_DRM_8285: 12fc367c2557ea74051378b2baadc6116add10ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17271: e967954f905e7e51449b415b65d478a0eb934a99 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e967954f905e drm/i915: Enable SAGV support for Gen129a18dd734b17 drm/i915: Restrict qgv points which don't have enough bandwidth. 8324f5130045 drm/i915: Rename bw_state to new_bw_state49c46f4edf34 drm/i915: Added required new PCode commandsfd7ee6e3d868 drm/i915: Add TGL+ SAGV support7c3a86821437 drm/i915: Separate icl and skl SAGV checking7b65af3b3c25 drm/i915: Use bw state for per crtc SAGV evaluation f573a32afca5 drm/i915: Add pre/post plane updates for SAGV926c0a7aaf2a drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 00989296f52d drm/i915: Add intel_atomic_get_bw_*_state helpers28f3e791c62a drm/i915: Introduce skl_plane_wm_level accessor.39684149a1cb drm/i915: Eliminate magic numbers "0" and "1" from color plane db3bb77d347e drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for SAGV support for Gen12+ (rev14)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev14)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8285_full -> Patchwork_17271_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17271_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17271_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17271_full:
### IGT changes ###
#### Possible regressions ####
* igt@perf_pmu@cpu-hotplug:
- shard-kbl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl7/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17271_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@prime:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([i915#750])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-tglb6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-tglb3/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#54]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl10/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][9] -> [FAIL][10] ([IGT#5])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl10/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl3/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#52] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-glk7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-glk7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#46])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-apl2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-apl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl9/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl9/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#31])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-apl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-apl1/igt@[email protected]
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@vecs0}:
- shard-kbl: [DMESG-WARN][23] ([i915#180]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl3/igt@gem_ctx_isolation@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl3/igt@gem_ctx_isolation@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][25] ([i915#72]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-glk9/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-glk6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [FAIL][27] ([IGT#5] / [i915#697]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl3/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][29] ([i915#1188]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl3/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl3/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][31] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][33] ([fdo#108145] / [i915#265]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-skl10/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-skl8/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-apl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-apl1/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][37] ([i915#454]) -> [SKIP][38] ([i915#468])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-tglb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-tglb2/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [FAIL][39] ([i915#93] / [i915#95]) -> [DMESG-FAIL][40] ([i915#180] / [i915#95])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-kbl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [FAIL][41] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][42] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8285/shard-apl3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/shard-apl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#697]: https://gitlab.freedesktop.org/drm/intel/issues/697
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8285 -> Patchwork_17271
CI-20190529: 20190529
CI_DRM_8285: 12fc367c2557ea74051378b2baadc6116add10ba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17271: e967954f905e7e51449b415b65d478a0eb934a99 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17271/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for SAGV support for Gen12+ (rev18)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Start passing latency as parameter Okay!
Commit: drm/i915: Eliminate magic numbers "0" and "1" from color plane Okay!
Commit: drm/i915: Introduce skl_plane_wm_level accessor. Okay!
Commit: drm/i915: Add intel_atomic_get_bw_*_state helpers Okay!
Commit: drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv Okay!
Commit: drm/i915: Add pre/post plane updates for SAGV Okay!
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17276 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17276, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17276:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen1208b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth. e1d400340158 drm/i915: Rename bw_state to new_bw_stated7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
Seems to be some issue in lmem self tests: :<4> [342.485150] intel_pstate: Turbo disabled by BIOS or unavailable on processor. This is not related to SAGV.
Best Regards,
Lisovskiy Stanislav
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
________________________________________
From: Patchwork <[email protected]>
Sent: Friday, April 10, 2020 4:20:58 PM
To: Lisovskiy, Stanislav
Cc: [email protected]
Subject: ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17276 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17276, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17276:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen1208b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth. e1d400340158 drm/i915: Rename bw_state to new_bw_stated7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17276 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17276, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17276:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] ([i915#1688]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1688]: https://gitlab.freedesktop.org/drm/intel/issues/1688
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen1208b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth. e1d400340158 drm/i915: Rename bw_state to new_bw_stated7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
self_test is broken, not related to SAGV anyhow - do we have a bug?
Best Regards,
Lisovskiy Stanislav
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
________________________________________
From: Patchwork <[email protected]>
Sent: Saturday, April 11, 2020 10:26:05 AM
To: Lisovskiy, Stanislav
Cc: [email protected]
Subject: ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17276 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17276, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17276:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] ([i915#1688]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1688]: https://gitlab.freedesktop.org/drm/intel/issues/1688
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen1208b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth. e1d400340158 drm/i915: Rename bw_state to new_bw_stated7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
Yes, we have a bug. I have re-reported the series. Hopefully this goes successful.
Lakshmi.
-----Original Message-----
From: Lisovskiy, Stanislav <[email protected]>
Sent: Monday, April 13, 2020 10:19 AM
To: [email protected]; Vudum, Lakshminarayana <[email protected]>; Peres, Martin <[email protected]>
Subject: Re: ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
self_test is broken, not related to SAGV anyhow - do we have a bug?
Best Regards,
Lisovskiy Stanislav
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
________________________________________
From: Patchwork <[email protected]>
Sent: Saturday, April 11, 2020 10:26:05 AM
To: Lisovskiy, Stanislav
Cc: [email protected]
Subject: ✗ Fi.CI.BAT: failure for SAGV support for Gen12+ (rev18)
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276 ====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17276 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17276, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17276:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] ([i915#1688]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1688]: https://gitlab.freedesktop.org/drm/intel/issues/1688
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen12 08b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth.e1d400340158 drm/i915: Rename bw_state to new_bw_state d7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking 3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV 340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for SAGV support for Gen12+ (rev18)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8289 -> Patchwork_17276
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
Known issues
------------
Here are the changes found in Patchwork_17276 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] ([i915#1688]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-lmem: [DMESG-WARN][3] ([i915#1688]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][5] ([i915#62] / [i915#95]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1688]: https://gitlab.freedesktop.org/drm/intel/issues/1688
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d05fb4a0457b drm/i915: Enable SAGV support for Gen1208b2bfe6c74c drm/i915: Restrict qgv points which don't have enough bandwidth. e1d400340158 drm/i915: Rename bw_state to new_bw_stated7dfb591ab1a drm/i915: Added required new PCode commands86c74315ca04 drm/i915: Add TGL+ SAGV support1d27dc3371c2 drm/i915: Separate icl and skl SAGV checking3d65a6833e4d drm/i915: Use bw state for per crtc SAGV evaluation b7dc3af9b55a drm/i915: Add pre/post plane updates for SAGV340b37dd96c3 drm/i915: Prepare to extract gen specific functions from intel_can_enable_sagv 5f292c54ef03 drm/i915: Add intel_atomic_get_bw_*_state helpersb247b1150e51 drm/i915: Introduce skl_plane_wm_level accessor.dd9d5971ba9b drm/i915: Eliminate magic numbers "0" and "1" from color plane e1a65ab6533f drm/i915: Start passing latency as parameter
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for SAGV support for Gen12+ (rev18)
In reply to Stanislav Lisovskiy== Series Details ==
== Series Details ==
Series: SAGV support for Gen12+ (rev18)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8289_full -> Patchwork_17276_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17276_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed-process@vecs0:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#1528])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl2/igt@gem_ctx_persistence@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl6/igt@gem_ctx_persistence@[email protected]
* igt@i915_pm_rps@reset:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#39])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-glk8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-glk8/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#54] / [i915#93] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-skl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-skl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][13] -> [FAIL][14] ([IGT#5])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#52] / [i915#54])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-glk2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-glk7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl6/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#1188])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-skl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-skl8/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][23] -> [FAIL][24] ([i915#31])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_persistence@engines-hang@rcs0:
- shard-iclb: [FAIL][25] ([i915#1622]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-iclb6/igt@gem_ctx_persistence@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-iclb5/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_suspend@basic-s3:
- shard-skl: [INCOMPLETE][27] ([i915#69]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-skl10/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-skl9/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [INCOMPLETE][29] ([CI#80] / [i915#155]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- shard-apl: [FAIL][31] ([i915#54] / [i915#95]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-apl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-apl7/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][37] ([fdo#109349]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-iclb6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-iclb2/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-glk: [FAIL][39] ([i915#177] / [i915#52] / [i915#54]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-glk6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-glk9/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][41] ([i915#79]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-glk7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-glk8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][43] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][45] ([fdo#108145] / [i915#265]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-skl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][49] ([i915#31]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-hsw4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-hsw1/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-snb: [INCOMPLETE][51] ([i915#82]) -> [SKIP][52] ([fdo#109271])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-snb4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-snb5/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-FAIL][53] ([i915#180] / [i915#95]) -> [FAIL][54] ([i915#93] / [i915#95])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-kbl2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-kbl3/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [FAIL][55] ([i915#608]) -> [SKIP][56] ([fdo#109642] / [fdo#111068])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8289/shard-iclb2/igt@kms_psr2_su@page_flip.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/shard-iclb1/igt@kms_psr2_su@page_flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1622]: https://gitlab.freedesktop.org/drm/intel/issues/1622
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8289 -> Patchwork_17276
CI-20190529: 20190529
CI_DRM_8289: 81e3d7ff72672b6aeadbf9c0b9cc514cec9c889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5586: 29fad328e6a1b105c8d688cafe19b1b5c19ad0c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17276: d05fb4a0457b591b3f67b57bd9f5786c4efe4add @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17276/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx