drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms
Subsystems (3)
PATCH RESEND 1/1 drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms
Replace the TGL/ICL specific platform checks with a more generic check using INTEL_GEN(). Fixes bug with broken audio after S3 resume on JSL platforms.
An initial version of state save and restore of AUD_FREQ_CNTRL register was added for subset of platforms in commit 87c1694533c9 ("drm/i915: save AUD_FREQ_CNTRL state at audio domain suspend"). The state save has proven to work well and it is needed in newer platforms, so needs to be extended. Although the logic is not in practise needed on GEN9/10 systems, follow the hardware specification and apply state and restore on all gen9+ platforms.
Bspec: 49281
--- drivers/gpu/drm/i915/display/intel_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_audio.c +2 -2
@@ -883,7 +883,7 @@ static unsigned long i915_audio_component_get_power(struct device *kdev) ret =intel_display_power_get (dev_priv,POWER_DOMAIN_AUDIO );if (dev_priv->audio_power_refcount++ ==0 ) { -if (IS_TIGERLAKE (dev_priv) ||IS_ICELAKE (dev_priv)) { +if (INTEL_GEN (dev_priv) >=9 ) {intel_de_write (dev_priv,AUD_FREQ_CNTRL , dev_priv->audio_freq_cntrl); drm_dbg_kms(&dev_priv->drm,
@@ -1165,7 +1165,7 @@ static void i915_audio_component_init(struct drm_i915_private *dev_priv)return ; } -if (IS_TIGERLAKE (dev_priv) ||IS_ICELAKE (dev_priv)) { +if (INTEL_GEN (dev_priv) >=9 ) { dev_priv->audio_freq_cntrl =intel_de_read (dev_priv,AUD_FREQ_CNTRL ); drm_dbg_kms(&dev_priv->drm,
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms (rev2)
URL : https://patchwork.freedesktop.org/series/74664/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8218 -> Patchwork_17136
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/index.html
Known issues
------------
Here are the changes found in Patchwork_17136 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@requests:
- fi-icl-u2: [PASS][1] -> [INCOMPLETE][2] ([i915#1505])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/fi-icl-u2/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/fi-icl-u2/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-rte:
- fi-icl-dsi: [INCOMPLETE][3] ([i915#189]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/fi-icl-dsi/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/fi-icl-dsi/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][5] ([i915#579]) -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/fi-kbl-guc/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/fi-kbl-guc/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1505]: https://gitlab.freedesktop.org/drm/intel/issues/1505
[i915#189]: https://gitlab.freedesktop.org/drm/intel/issues/189
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (46 -> 38)
------------------------------
Additional (6): fi-bdw-5557u fi-bsw-n3050 fi-gdg-551 fi-ivb-3770 fi-bsw-kefka fi-bsw-nick
Missing (14): fi-hsw-4770r fi-ilk-m540 fi-bdw-samus fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-skl-lmem fi-kbl-7560u fi-byt-clapper fi-skl-6600u fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8218 -> Patchwork_17136
CI-20190529: 20190529
CI_DRM_8218: 34c4b933b4daa72079af3d5506113695a6ea10ea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5545: 9e5bfd10d56f81b98e0229c6bb14670221fd0b54 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17136: bf7760c4d68f32856c655df7de7c868cbfd9bd4a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bf7760c4d68f drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms (rev2)
In reply to Kai Vehmanen== Series Details ==
== Series Details ==
Series: drm/i915: do AUD_FREQ_CNTRL state save on all gen9+ platforms (rev2)
URL : https://patchwork.freedesktop.org/series/74664/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8218_full -> Patchwork_17136_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17136_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112146]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb2/igt@[email protected]
* igt@gem_exec_schedule@implicit-both-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#677]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb1/igt@[email protected]
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [i915#677]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +13 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb6/igt@[email protected]
* igt@gem_wait@busy-vcs1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112080]) +6 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb7/igt@[email protected]
* igt@i915_pm_rps@min-max-config-loaded:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#39])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-glk4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-glk9/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-glk1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-glk9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-kbl1/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#221])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-skl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-skl5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-apl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-apl1/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-kbl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-skl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-kbl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl1/igt@gem_ctx_isolation@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-kbl2/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd:
- shard-skl: [FAIL][29] ([i915#1528]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-skl7/igt@gem_ctx_persistence@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-skl4/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [SKIP][31] ([fdo#109276] / [i915#677]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@implicit-read-write-render:
- shard-snb: [INCOMPLETE][33] ([i915#82]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-snb5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-snb6/igt@[email protected]
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [SKIP][35] ([i915#677]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][37] ([fdo#112146]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb7/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-glk: [FAIL][39] ([i915#1527]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-glk2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-glk3/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-skl: [INCOMPLETE][41] ([i915#69]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-skl10/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-skl1/igt@[email protected]
- shard-apl: [DMESG-WARN][43] ([i915#180]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-apl6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-apl4/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
- shard-glk: [FAIL][45] ([i915#52] / [i915#54]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-glk8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-glk2/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-WARN][47] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-kbl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][49] ([i915#61]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-hsw4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-hsw2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][51] ([fdo#108145]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-skl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-skl4/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][53] ([fdo#109642] / [fdo#111068]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb4/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb8/igt@kms_psr@psr2_dpms.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb2/igt@kms_psr@psr2_dpms.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [PASS][58] +8 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb4/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][59] ([fdo#109276]) -> [PASS][60] +16 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-iclb8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-iclb2/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][61] ([i915#454]) -> [SKIP][62] ([i915#468])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-tglb8/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-tglb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][63], [FAIL][64]) ([i915#1423] / [i915#1485] / [i915#92]) -> [FAIL][65] ([i915#1423] / [i915#92])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8218/shard-kbl2/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/shard-kbl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1423]: https://gitlab.freedesktop.org/drm/intel/issues/1423
[i915#1485]: https://gitlab.freedesktop.org/drm/intel/issues/1485
[i915#1527]: https://gitlab.freedesktop.org/drm/intel/issues/1527
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8218 -> Patchwork_17136
CI-20190529: 20190529
CI_DRM_8218: 34c4b933b4daa72079af3d5506113695a6ea10ea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5545: 9e5bfd10d56f81b98e0229c6bb14670221fd0b54 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17136: bf7760c4d68f32856c655df7de7c868cbfd9bd4a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17136/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hey,
Quoted 3 lines · Kai Vehmanen
Replace the TGL/ICL specific platform checks with a more generic check using
INTEL_GEN(). Fixes bug with broken audio after S3 resume on JSL platforms.
I would be (gently) beaten with a stick on alsa-devel for sending this type of content free ping, but I still dare to seek your input on what is the proper way to get attention to a patch that are seemingly forever stuck on the review sideline.
I've sent this on 13.3., resend on 30.3.. Should I just keep on sending resends and let the system work (this is the alsa-devel practise), or should I start to contact potential reviewers with more direct asks?
Tests seem to all pass and this is pretty important for anyone using JSL platforms (you lose HDMI/DP audio after first S3 suspend otherwise):
https://patchwork.freedesktop.org/series/74664/
Br, Kai
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Kai Vehmanen
Hey,
On Mon, 30 Mar 2020, Kai Vehmanen wrote:
Quoted 8 lines
Quoted 3 lines
Replace the TGL/ICL specific platform checks with a more generic check using
INTEL_GEN(). Fixes bug with broken audio after S3 resume on JSL platforms.I would be (gently) beaten with a stick on alsa-devel for sending this type of content free ping, but I still dare to seek your input on what is the proper way to get attention to a patch that are seemingly forever stuck on the review sideline.
And what is this?
https://patchwork.freedesktop.org/patch/347148/?series=71527&rev=1
Quoted 4 lines
I've sent this on 13.3., resend on 30.3.. Should I just keep on sending resends and let the system work (this is the alsa-devel practise), or should I start to contact potential reviewers with more direct asks?
Just ping on original patch or ping someone on irc. Resending the same patch over and over does no good. At least my brain just ignores anything that looks like it's just a resend w/o any clear justification.
Quoted 6 lines
Tests seem to all pass and this is pretty important for anyone using JSL platforms (you lose HDMI/DP audio after first S3 suspend otherwise):
https://patchwork.freedesktop.org/series/74664/Br, Kai
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hey,
Quoted 7 lines · Ville Syrjälä
Quoted 3 lines · Kai Vehmanen
type of content free ping, but I still dare to seek your input on what is the proper way to get attention to a patch that are seemingly forever stuck on the review sideline.
And what is this?
https://patchwork.freedesktop.org/patch/347148/?series=71527&rev=1
that's a lost child I'm afraid. It's essentially the same patch I submitted late last year. It got review ok from Matt, and I thought it was going to be merged and went on to do other things -- i.e. I failed to follow-up on this. Back then I did not know about any actual bugs this would fix -- this was a generic change to align with hw specs.
Fast forward two months. I had forgotten about that previous patch, and I ended up recreating the same patch to fix an actual bug. I.e. the of this thread:
https://patchwork.freedesktop.org/series/74664/
I only very recently noticed the old patch. But alas, the new attempt is probably the one that should be merged as it has more information in the commit message (we now know about actual issues on JSL).
Quoted 4 lines
Just ping on original patch or ping someone on irc. Resending the same patch over and over does no good. At least my brain just ignores anything that looks like it's just a resend w/o any clear justification.
Ack, thanks a lot, this clarifies. In any case, patch author should own the follow-up and I definitely dropped the ball on the older #347148 .
Br, Kai
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Kai Vehmanen
Hey,
Quoted 7 lines · Ville Syrjälä
Quoted 3 lines · Kai Vehmanen
type of content free ping, but I still dare to seek your input on what is the proper way to get attention to a patch that are seemingly forever stuck on the review sideline.
And what is this?
https://patchwork.freedesktop.org/patch/347148/?series=71527&rev=1that's a lost child I'm afraid. It's essentially the same patch I submitted late last year. It got review ok from Matt, and I thought it was going to be merged and went on to do other things -- i.e. I failed to follow-up on this. Back then I did not know about any actual bugs this would fix -- this was a generic change to align with hw specs.
Quoted 4 lines
Fast forward two months. I had forgotten about that previous patch, and I ended up recreating the same patch to fix an actual bug. I.e. the of this thread:
https://patchwork.freedesktop.org/series/74664/
OK. I sucked in the rb from the old patch and pushed the new version. Thanks.
Quoted 14 lines
I only very recently noticed the old patch. But alas, the new attempt is probably the one that should be merged as it has more information in the commit message (we now know about actual issues on JSL).
Quoted 4 lines
Just ping on original patch or ping someone on irc. Resending the same patch over and over does no good. At least my brain just ignores anything that looks like it's just a resend w/o any clear justification.
Ack, thanks a lot, this clarifies. In any case, patch author should own the follow-up and I definitely dropped the ball on the older #347148 .
Br, Kai
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx