tracing: make some symbols static in tracing_map.c
PATCH 1/1 tracing: make some symbols static in tracing_map.c
Fix the following sparse warning:
kernel/trace/tracing_map.c:286:6: warning: symbol 'tracing_map_array_clear' was not declared. Should it be static? kernel/trace/tracing_map.c:297:6: warning: symbol 'tracing_map_array_free' was not declared. Should it be static? kernel/trace/tracing_map.c:319:26: warning: symbol 'tracing_map_array_alloc' was not declared. Should it be static?
--- kernel/trace/tracing_map.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/trace/tracing_map.c +3 -3
@@ -283,7 +283,7 @@ int tracing_map_add_key_field(struct tracing_map *map,return idx; } -void tracing_map_array_clear (struct tracing_map_array *a) +static void tracing_map_array_clear (struct tracing_map_array *a) {unsigned int i;
@@ -294,7 +294,7 @@ void tracing_map_array_clear(struct tracing_map_array *a)memset (a->pages[i],0 ,PAGE_SIZE ); } -void tracing_map_array_free (struct tracing_map_array *a) +static void tracing_map_array_free (struct tracing_map_array *a) {unsigned int i;
@@ -316,7 +316,7 @@ void tracing_map_array_free(struct tracing_map_array *a)kfree (a); } -struct tracing_map_array *tracing_map_array_alloc (unsigned int n_elts, +static struct tracing_map_array *tracing_map_array_alloc (unsigned int n_elts,unsigned int entry_size) {struct tracing_map_array *a;
Signature · 1 line
2.17.2
Steven Rostedt
maintainerTom,
Care to ack this?
-- Steve
Quoted 46 lines · On Fri, 10 Apr 2020 15:33:12 +0800 Jason Yan <[email protected]> wrote:
Fix the following sparse warning:
kernel/trace/tracing_map.c:286:6: warning: symbol 'tracing_map_array_clear' was not declared. Should it be static?kernel/trace/tracing_map.c:297:6: warning: symbol 'tracing_map_array_free' was not declared. Should it be static?kernel/trace/tracing_map.c:319:26: warning: symbol 'tracing_map_array_alloc' was not declared. Should it be static?Reported-by Hulk Robot <[email protected]>Signed-off-by Jason Yan <[email protected]>--- kernel/trace/tracing_map.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/trace/tracing_map.c +3
-3@@ -283,7 +283,7 @@ int tracing_map_add_key_field(struct tracing_map *map,return idx; } -void tracing_map_array_clear (struct tracing_map_array *a) +static void tracing_map_array_clear (struct tracing_map_array *a) {unsigned int i;@@ -294,7 +294,7 @@ void tracing_map_array_clear(struct tracing_map_array *a)memset (a->pages[i],0 ,PAGE_SIZE ); } -void tracing_map_array_free (struct tracing_map_array *a) +static void tracing_map_array_free (struct tracing_map_array *a) {unsigned int i;@@ -316,7 +316,7 @@ void tracing_map_array_free(struct tracing_map_array *a)kfree (a); } -struct tracing_map_array *tracing_map_array_alloc (unsigned int n_elts, +static struct tracing_map_array *tracing_map_array_alloc (unsigned int n_elts,unsigned int entry_size) {struct tracing_map_array *a;
Tom Zanussi
Reviewed-byQuoted 4 lines · Steven Rostedt
Tom,
Care to ack this?
Sure,
Tom
Quoted 61 lines
-- Steve
Quoted 53 lines · On Fri, 10 Apr 2020 15:33:12 +0800 Jason Yan <[email protected]> wrote:
Fix the following sparse warning:
kernel/trace/tracing_map.c:286:6: warning: symbol 'tracing_map_array_clear' was not declared. Should it be static?kernel/trace/tracing_map.c:297:6: warning: symbol 'tracing_map_array_free' was not declared. Should it be static?kernel/trace/tracing_map.c:319:26: warning: symbol 'tracing_map_array_alloc' was not declared. Should it be static?Reported-by Hulk Robot <[email protected]>Signed-off-by Jason Yan <[email protected]>--- kernel/trace/tracing_map.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)kernel/trace/tracing_map.c +3
-3@@ -283,7 +283,7 @@ int tracing_map_add_key_field(structtracing_map *map, return idx; } -void tracing_map_array_clear (struct tracing_map_array *a) +static void tracing_map_array_clear (struct tracing_map_array *a) {unsigned int i;@@ -294,7 +294,7 @@ void tracing_map_array_clear(struct tracing_map_array *a) memset(a->pages[i], 0, PAGE_SIZE); } -void tracing_map_array_free (struct tracing_map_array *a) +static void tracing_map_array_free (struct tracing_map_array *a) {unsigned int i;@@ -316,7 +316,7 @@ void tracing_map_array_free(struct tracing_map_array *a)kfree (a ); } -struct tracing_map_array *tracing_map_array_alloc(unsigned int n_elts, +static struct tracing_map_array *tracing_map_array_alloc(unsigned int n_elts,unsigned int
entry_size)
{
structtracing_map_array*a;