Skip to contentSkip to conversation

iommu: Fix MTK_IOMMU dependencies

PATCH Applied Geert Uytterhoeven 2 participants 2 messages Apr 10, 2020 – Apr 18, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu: Fix MTK_IOMMU dependencies

If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config):

drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap':
dma-iommu.c:(.text+0x836): undefined reference to `dma_pgprot'

IOMMU_DMA must not be selected, unless HAS_DMA=y.

Hence fix this by making MTK_IOMMU depend on HAS_DMA.
While at it, remove the dependency on ARM || ARM64, as that is already implied by the dependency on ARCH_MEDIATEK.

Fixes e93a1695d7fb5513 ("iommu: Enable compile testing for some of drivers")
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/Kconfig +1 -1
index 58b4a4dbfc78b9a5..bead9aaea8429447 100644
@@ -457,7 +457,7 @@ config S390_AP_IOMMU
 
 config MTK_IOMMU
 	bool "MTK IOMMU Support"
-	depends on ARM || ARM64 || COMPILE_TEST
+	depends on HAS_DMA
 	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select ARM_DMA_USE_IOMMU
 	select IOMMU_API
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Geert Uytterhoeven
Fixes e93a1695d7fb5513 ("iommu: Enable compile testing for some of drivers")
---
 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.