Skip to contentSkip to conversation

module: increase dirs array size by one

PATCH Applied Bruce Rogers 2 participants 2 messages Apr 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: increase dirs array size by one

With the module upgrades code change, the statically sized dirs array can now overflow. Increase it's size by one, according to the new maximum possible usage.

Fixes bd83c861c0 ("modules: load modules from versioned /var/run dir")
---
 util/module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
util/module.c +1 -1
index 5f7896870a..e48d9aacc0 100644
@@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
     char *version_dir;
 #endif
     const char *search_dir;
-    char *dirs[4];
+    char *dirs[5];
     char *module_name;
     int i = 0, n_dirs = 0;
     int ret;
Signature · 1 line
2.26.0
#1 lore raw
Quoted 16 lines · Bruce Rogers

With the module upgrades code change, the statically sized dirs array can now overflow. Increase it's size by one, according to the new maximum possible usage.

Fixes bd83c861c0 ("modules: load modules from versioned /var/run dir")
---
 util/module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
util/module.c +0 -0
index 5f7896870a..e48d9aacc0 100644

util/module.c bool module_load_one(const char *prefix, const char *lib_name) · line 183

Quoted 8 lines
util/module.c +1 -1
@@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
     char *version_dir;
 #endif
     const char *search_dir;
-    char *dirs[4];
+    char *dirs[5];
     char *module_name;
     int i = 0, n_dirs = 0;
     int ret;

Queued, thanks.

Paolo