Skip to contentSkip to conversation

KVM: SVM: Fix build error due to missing release_pages() include

PATCH Applied Borislav Petkov 2 participants 2 messages Apr 11, 2020 – Apr 15, 2020

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 1/1 KVM: SVM: Fix build error due to missing release_pages() include

From: Borislav Petkov <[email protected]>

Fix:

arch/x86/kvm/svm/sev.c: In function ‘sev_pin_memory’:
arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ‘release_pages’;\

	  did you mean ‘reclaim_pages’? [-Werror=implicit-function-declaration]
    360 |   release_pages(pages, npinned);
        |   ^~~~~~~~~~~~~
        |   reclaim_pages

because svm.c includes pagemap.h but the carved out sev.c needs it too. Triggered by a randconfig build.

Fixes eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
Signed-off-by Borislav Petkov <[email protected]>
---
 arch/x86/kvm/svm/sev.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/svm/sev.c +1 -0
index 0e3fc311d7da..0208ab2179d5 100644
@@ -12,6 +12,7 @@
 #include <linux/kernel.h>
 #include <linux/highmem.h>
 #include <linux/psp-sev.h>
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 
 #include "x86.h"
Signature · 1 line
2.21.0
maintainer Applied
#1 lore raw
Quoted 26 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

Fix:

arch/x86/kvm/svm/sev.c: In function ‘sev_pin_memory’:
arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ‘release_pages’;\

	  did you mean ‘reclaim_pages’? [-Werror=implicit-function-declaration]
    360 |   release_pages(pages, npinned);
        |   ^~~~~~~~~~~~~
        |   reclaim_pages

because svm.c includes pagemap.h but the carved out sev.c needs it too. Triggered by a randconfig build.

Fixes eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
Signed-off-by Borislav Petkov <[email protected]>
---
 arch/x86/kvm/svm/sev.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kvm/svm/sev.c +0 -0
index 0e3fc311d7da..0208ab2179d5 100644

arch/x86/kvm/svm/sev.c line 18

Quoted 7 lines
arch/x86/kvm/svm/sev.c +1 -0
@@ -12,6 +12,7 @@
 #include <linux/kernel.h>
 #include <linux/highmem.h>
 #include <linux/psp-sev.h>
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 
 #include "x86.h"

Queued, thanks.

Paolo