Staging: kernel: user: fixed some coding style issues
PATCH 1/1 Staging: kernel: user: fixed some coding style issues
From: porfavorde <[email protected]>
Fixed a coding style issue with a for loop and a trailing whitespace in the comments
--- kernel/user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/user.c +2 -2
@@ -6,7 +6,7 @@* * We have a per-user structure to keep track of how many * processes, files etc the user has claimed, in order to be -* able to have per-user limits for system resources. +* able to have per-user limits for system resources. */ #include <linux/init.h>
@@ -216,7 +216,7 @@ static int __init uid_cache_init(void) uid_cachep =kmem_cache_create ("uid_cache" ,sizeof (struct user_struct ),0 ,SLAB_HWCACHE_ALIGN |SLAB_PANIC ,NULL ); -for (n =0 ; n <UIDHASH_SZ ; ++n) +for (n =0 ; n <UIDHASH_SZ ; ++n)INIT_HLIST_HEAD (uidhash_table + n);/* Insert the root user immediately (init already runs as root) */
Signature · 1 line
2.25.1
Quoted 1 line · On Sat, 2020-04-11 at 21:42 +0200, [email protected] wrote:
From: porfavorde <[email protected]>
Hello.
Quoted 4 lines
Fixed a coding style issue with a for loop and a trailing whitespace in the comments
Signed-off-by Carlos Guerrero Álvarez <[email protected]>
A From: line is generally used when sending a patch authored by someone else.
It would be better here not to use a From: line at all as you are both the author and sender.
Also please make your first patch somewhere in drivers/staging and not any other directory until you are familiar with the kernel styles and tools. kernel/ isn't really a good place for a first patch to be accepted, though I don't see anything wrong with this patch other than the From: line.
But whitespace only changes outside of drivers/staging and a few other directories are generally not accepted unless sent as a patch series along with some other change such as refactoring or a logical change for a defect.
cheers, Joe
---
Quoted 25 lines
kernel/user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/user.c +2
-2@@ -6,7 +6,7 @@* * We have a per-user structure to keep track of how many * processes, files etc the user has claimed, in order to be -* able to have per-user limits for system resources. +* able to have per-user limits for system resources. */ #include <linux/init.h> @@ -216,7 +216,7 @@ static int __init uid_cache_init(void) uid_cachep =kmem_cache_create ("uid_cache" ,sizeof (struct user_struct ),0 ,SLAB_HWCACHE_ALIGN |SLAB_PANIC ,NULL ); -for (n =0 ; n <UIDHASH_SZ ; ++n) +for (n =0 ; n <UIDHASH_SZ ; ++n)INIT_HLIST_HEAD (uidhash_table + n);/* Insert the root user immediately (init already runs as root) */