Skip to contentSkip to conversation

netfilter: flowtable: Free block_cb when being deleted

PATCH Applied Roi Dayan 2 participants 2 messages Apr 12, 2020 – Apr 14, 2020

Subsystems (3)
lore
Share & tools
lore

Roi Dayan

author
#0 lore raw

PATCH 1/1 netfilter: flowtable: Free block_cb when being deleted

Free block_cb memory when asked to be deleted.

Fixes 978703f42549 ("netfilter: flowtable: Add API for registering to flow table events")
---
 net/netfilter/nf_flow_table_core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
net/netfilter/nf_flow_table_core.c +4 -2
index c0cb79495c35..4344e572b7f9 100644
@@ -421,10 +421,12 @@ void nf_flow_table_offload_del_cb(struct nf_flowtable *flow_table,
 
 	down_write(&flow_table->flow_block_lock);
 	block_cb = flow_block_cb_lookup(block, cb, cb_priv);
-	if (block_cb)
+	if (block_cb) {
 		list_del(&block_cb->list);
-	else
+		flow_block_cb_free(block_cb);
+	} else {
 		WARN_ON(true);
+	}
 	up_write(&flow_table->flow_block_lock);
 }
 EXPORT_SYMBOL_GPL(nf_flow_table_offload_del_cb);
Signature · 1 line
2.8.4
maintainer Applied
#1 lore raw
Quoted 1 line · Roi Dayan

Free block_cb memory when asked to be deleted.

Applied, thanks.