Skip to contentSkip to conversation

dt-bindings: fix warning in panel/advantech, idk-2121wr

PATCH In review Sam Ravnborg 2 participants 4 messages Apr 12, 2020 – Apr 14, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover dt-bindings: fix warning in panel/advantech, idk-2121wr

The binding for the advantech,idk-2121wr uses an example where a ports {} node is used.

The panel-lvds binding failed to support a ports node, which the following patch fixes.

This fix was part of a longer series, but we need this fix in upstream before -rc2.
So pull this out of the larger series.

Sam
Sam Ravnborg (1):
dt-bindings: display: allow port and ports in panel-lvds

 Documentation/devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
#1 lore raw

PATCH v2 1/1 dt-bindings: display: allow port and ports in panel-lvds

Both port and ports names may be used in a panel-lvds binding
port - for a single port
ports - if there is more than one port in sub-nodes

Fixes the following warning:
advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property

advantech,idk-2121wr.yaml needs several ports, so uses a ports node.

v2:
- Use oneOf - makes the logic more obvious (Rob)
- Added Fixes tag
- Added port: true, ports:true

Cc Rob Herring <[email protected]>
Fixes 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
Cc Fabrizio Castro <[email protected]>
Cc Lad Prabhakar <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
---
 .../devicetree/bindings/display/panel/lvds.yaml        | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/panel/lvds.yaml +9 -1
index d0083301acbe..a5587c4f5ad0 100644
@@ -96,12 +96,20 @@ properties:
       If set, reverse the bit order described in the data mappings below on all
       data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
 
+  port: true
+  ports: true
+
 required:
   - compatible
   - data-mapping
   - width-mm
   - height-mm
   - panel-timing
-  - port
+
+oneOf:
+  - required:
+    - port
+  - required:
+    - ports
 
 ...
Signature · 1 line
2.20.1
maintainer Reviewed-by on v2 1/1
#2 lore raw

Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds

Quoted 22 lines · Sam Ravnborg

Both port and ports names may be used in a panel-lvds binding
port - for a single port
ports - if there is more than one port in sub-nodes

Fixes the following warning:
advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property

advantech,idk-2121wr.yaml needs several ports, so uses a ports node.

v2:
- Use oneOf - makes the logic more obvious (Rob)
- Added Fixes tag
- Added port: true, ports:true

Cc Rob Herring <[email protected]>
Fixes 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding")
Cc Fabrizio Castro <[email protected]>
Cc Lad Prabhakar <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thierry Reding <[email protected]>
Quoted 3 lines
---
 .../devicetree/bindings/display/panel/lvds.yaml        | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

One nit below...

Quoted 15 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +3 -0
index d0083301acbe..a5587c4f5ad0 100644
@@ -96,12 +96,20 @@ properties:
       If set, reverse the bit order described in the data mappings below on all
       data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
 
+  port: true
+  ports: true
+
 required:
   - compatible
   - data-mapping

Documentation/devicetree/bindings/display/panel/lvds.yaml properties: · line 113

Quoted 10 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +6 -1
   - width-mm
   - height-mm
   - panel-timing
-  - port
+
+oneOf:
+  - required:
+    - port
+  - required:
+    - ports

Should be indented 2 more spaces. It only matters for any scripted processing we do on the files.

Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

Re: [PATCH v2 1/1] dt-bindings: display: allow port and ports in panel-lvds

Hi Rob.

Quoted 30 lines
Quoted 5 lines
---
 .../devicetree/bindings/display/panel/lvds.yaml        | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

One nit below...

Quoted 20 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +4 -1
index d0083301acbe..a5587c4f5ad0 100644
@@ -96,12 +96,20 @@ properties:
       If set, reverse the bit order described in the data mappings below on all
       data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6.
 
+  port: true
+  ports: true
+
 required:
   - compatible
   - data-mapping
   - width-mm
   - height-mm
   - panel-timing
-  - port
+
Quoted 8 lines

Documentation/devicetree/bindings/display/panel/lvds.yaml properties: · line 113

Quoted 5 lines
Documentation/devicetree/bindings/display/panel/lvds.yaml +5 -0
+oneOf:
+  - required:
+    - port
+  - required:
+    - ports

Should be indented 2 more spaces. It only matters for any scripted processing we do on the files.

Fixed and pushed to drm-misc-next.
Will cherry-pick to drm-fixes.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel