Skip to contentSkip to conversation

video: vt8500lcdfb: fix fallthrough warning

PATCH In review Sam Ravnborg 2 participants 2 messages Apr 12, 2020 – Apr 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: vt8500lcdfb: fix fallthrough warning

Fix following warning:
vt8500lcdfb.c: In function 'vt8500lcd_blank':
vt8500lcdfb.c:229:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

      if (info->fix.visual = FB_VISUAL_PSEUDOCOLOR ||
         ^
vt8500lcdfb.c:233:2: note: here
     case FB_BLANK_UNBLANK:
     ^~~~

Adding a simple "fallthrough;" fixed the warning.
The fix was build tested.

Fixes e41f1a989408 ("fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb")
Cc Alexey Charkov <[email protected]>
Cc Paul Mundt <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc <[email protected]> # v2.6.38+
---
 drivers/video/fbdev/vt8500lcdfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/vt8500lcdfb.c +1 -0
index f744479dc7df..c61476247ba8 100644
@@ -230,6 +230,7 @@ static int vt8500lcd_blank(int blank, struct fb_info *info)
 		    info->fix.visual = FB_VISUAL_STATIC_PSEUDOCOLOR)
 			for (i = 0; i < 256; i++)
 				vt8500lcd_setcolreg(i, 0, 0, 0, 0, info);
+		fallthrough;
 	case FB_BLANK_UNBLANK:
 		if (info->fix.visual = FB_VISUAL_PSEUDOCOLOR ||
 		    info->fix.visual = FB_VISUAL_STATIC_PSEUDOCOLOR)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 12 lines · Sam Ravnborg

Fix following warning:
vt8500lcdfb.c: In function 'vt8500lcd_blank':
vt8500lcdfb.c:229:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

      if (info->fix.visual = FB_VISUAL_PSEUDOCOLOR ||
         ^
vt8500lcdfb.c:233:2: note: here
     case FB_BLANK_UNBLANK:
     ^~~~

Adding a simple "fallthrough;" fixed the warning.
The fix was build tested.

Quoted 9 lines
Fixes e41f1a989408 ("fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb")
Cc Alexey Charkov <[email protected]>
Cc Paul Mundt <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc <[email protected]> # v2.6.38+

Patch queued for v5.8, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 17 lines
---
 drivers/video/fbdev/vt8500lcdfb.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/vt8500lcdfb.c +1 -0
index f744479dc7df..c61476247ba8 100644
@@ -230,6 +230,7 @@ static int vt8500lcd_blank(int blank, struct fb_info *info)
 		    info->fix.visual = FB_VISUAL_STATIC_PSEUDOCOLOR)
 			for (i = 0; i < 256; i++)
 				vt8500lcd_setcolreg(i, 0, 0, 0, 0, info);
+		fallthrough;
 	case FB_BLANK_UNBLANK:
 		if (info->fix.visual = FB_VISUAL_PSEUDOCOLOR ||
 		    info->fix.visual = FB_VISUAL_STATIC_PSEUDOCOLOR)