Skip to contentSkip to conversation

rockchip: rv1108: use correct API for board callback

PATCH New Kever Yang 2 participants 4 messages Apr 13, 2020

Subsystems (2)
lore
Share & tools
lore

Kever Yang

author
#0 lore raw

PATCH 1/3 rockchip: rv1108: use correct API for board callback

Use board_early_init_f() instead of mach_cpu_init() for board, the board_early_init_f() is used for board init and after dm_initf, while the mach_cpu_init() is used for CPU/SOC and before dm_initf()(not able to use syscon API).

Fixes 9cec336708 ("rockchip: evb-rv1108: Use syscon API to get grf base")
Fixes 4aa33690fc {"rockchip: elgin-rv1108: Use syscon API to get grf base")

---

 board/elgin/elgin_rv1108/elgin_rv1108.c | 2 +-
 board/rockchip/evb_rv1108/evb_rv1108.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
board/elgin/elgin_rv1108/elgin_rv1108.c +1 -1
index c5a1cc95e4..f9100e178c 100644
@@ -14,7 +14,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int mach_cpu_init(void)
+int board_early_init_f(void)
 {
 	struct rv1108_grf *grf;
 	enum {
board/rockchip/evb_rv1108/evb_rv1108.c +1 -1
index 5d622c3737..f34fe4401b 100644
@@ -13,7 +13,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-int mach_cpu_init(void)
+int board_early_init_f(void)
 {
 	struct rv1108_grf *grf;
 	enum {
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/3 rockchip: rv1108: Enable grf as pre-reloc node

The grf node will be used before relocate, enable it in dts.

---

 arch/arm/dts/rv1108-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/rv1108-u-boot.dtsi +4 -0
index 41ac054b81..6a2098b8d4 100644
@@ -4,3 +4,7 @@
  */
 
 #include "rockchip-u-boot.dtsi"
+
+&grf {
+	u-boot,dm-pre-reloc;
+};
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH 3/3 rockchip: evb-rv1108: enable board early init

In reply to Kever Yang

Enable board early init callback to init board specific hardware.

---

 configs/evb-rv1108_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/evb-rv1108_defconfig +1 -0
index ae2c9704ab..3998ba4f2a 100644
@@ -10,6 +10,7 @@ CONFIG_DEBUG_UART=y
 CONFIG_DEFAULT_FDT_FILE="rv1108-evb.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_RANDOM_UUID=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/3 rockchip: evb-rv1108: enable board early init

Quoted 4 lines · Kever Yang

Enable board early init callback to init board specific hardware.

Please send the same patch to elgin-rv1108 config.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750