pinctrl: actions: fix function group name for i2c0_group
Subsystems (3)
PATCH 1/1 pinctrl: actions: fix function group name for i2c0_group
After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix functions groups names for S700 SoC") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC).
[ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
This commit fixes it by using correct name for i2c0_group.
--- drivers/pinctrl/actions/pinctrl-s700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/actions/pinctrl-s700.c +1 -1
@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {static const char *const i2c0_groups[] = {"uart0_rx_mfp" ,"uart0_tx_mfp" , -"i2c0_mfp_mfp" , +"i2c0_mfp" , };static const char *const i2c1_groups[] = {
Signature · 1 line
2.7.4
Quoted 8 lines · Amit Singh Tomar
After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix functions groups names for S700 SoC") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC).
[ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"This commit fixes it by using correct name for
i2c0_group.
Another one ;)
Thanks,
Mani
Quoted 22 lines
Fixes 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")Signed-off-by Amit Singh Tomar <[email protected]>--- drivers/pinctrl/actions/pinctrl-s700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/actions/pinctrl-s700.c +1
-1@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {static const char *const i2c0_groups[] = {"uart0_rx_mfp" ,"uart0_tx_mfp" , -"i2c0_mfp_mfp" , +"i2c0_mfp" , };static const char *const i2c1_groups[] = {Signature · 1 line
2.7.4
Andreas Färber
maintainerHi,
Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
Quoted 9 lines
After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix functions groups names for S700 SoC") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC).
[ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"This commit fixes it by using correct name for
i2c0_group.Fixes 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")
The commit hash should have 12 digits.
Please also check the white spaces: The subject seems to have too many after "actions:", and there's one missing before each parenthesis above.
Regards,
Andreas
Quoted 19 lines
Signed-off-by Amit Singh Tomar <[email protected]>--- drivers/pinctrl/actions/pinctrl-s700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/actions/pinctrl-s700.c +1
-1@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {static const char *const i2c0_groups[] = {"uart0_rx_mfp" ,"uart0_tx_mfp" , -"i2c0_mfp_mfp" , +"i2c0_mfp" , };static const char *const i2c1_groups[] = {
Signature · 4 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
Quoted 9 lines · Andreas Färber
Hi,
Am 12.04.20 um 16:34 schrieb Amit Singh Tomar:
Quoted 6 lines
After commit 6f87359e8bcaf88381b9c9c038929e0e6872d308("pinctrl: actions: Fix functions groups names for S700 SoC") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC).
[ 1.206245] pinctrl-s700 e01b0000.pinctrl: invalid group "i2c0_mfp" for function "i2c0"
Quoted 9 lines
Quoted 3 lines
This commit fixes it by using correct name for
i2c0_group.Fixes 6f87359 ("pinctrl: actions: Fix functions groups names for S700 SoC")The commit hash should have 12 digits.
Please also check the white spaces: The subject seems to have too many after "actions:", and there's one missing before each parenthesis above.
Amit, you can use something like this
git log -1 --abbrev-commit --pretty=format:"Fixes: %h (\"%s\")%n" <commit-hash>
Thanks,
Mani
Quoted 28 lines
Regards,
AndreasQuoted 18 lines
Signed-off-by Amit Singh Tomar <[email protected]>--- drivers/pinctrl/actions/pinctrl-s700.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/actions/pinctrl-s700.c +1
-1@@ -1435,7 +1435,7 @@ static const char * const sd2_groups[] = {static const char *const i2c0_groups[] = {"uart0_rx_mfp" ,"uart0_tx_mfp" , -"i2c0_mfp_mfp" , +"i2c0_mfp" , };static const char *const i2c1_groups[] = {Signature · 4 lines
SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
Hi Mani,
Quoted 3 lines
Amit, you can use something like this
git log -1 --abbrev-commit --pretty=format:"Fixes: %h (\"%s\")%n" <commit-hash>
Yeah, I already had this enabled in my git config:
[pretty]
fixes = Fixes: %h (\"%s\")
picked = Cherry-Picked: %h (\"%s\")and then I generated it using:
git log --pretty=fixes -1 6f87359e8bcaf88381b9c9c038929e0e6872d308
But seems to only generates 7 chars for commit hash
Thanks
Amit