Skip to contentSkip to conversation

fs: only pass valid chmod mode_t bits to security_path_chmod

PATCH New daurnimator 1 participant 1 message Apr 13, 2020 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: only pass valid chmod mode_t bits to security_path_chmod

chmod only pays attention to some of the flags in umode_t, don't pass on irrelevant flags to security_path_chmod.

---
 fs/open.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/open.c +2 -1
index b69d6eed67e6..a2d8bee88a3c 100644
@@ -551,12 +551,13 @@ static int chmod_common(const struct path *path, umode_t mode)
 	error = mnt_want_write(path->mnt);
 	if (error)
 		return error;
+	mode &= S_IALLUGO;
 retry_deleg:
 	inode_lock(inode);
 	error = security_path_chmod(path, mode);
 	if (error)
 		goto out_unlock;
-	newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
+	newattrs.ia_mode = mode | (inode->i_mode & ~S_IALLUGO);
 	newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
 	error = notify_change(path->dentry, &newattrs, &delegated_inode);
 out_unlock:
Signature · 1 line
2.26.0