Skip to contentSkip to conversation

MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS

PATCH Superseded Lukas Bulwahn 1 participant 2 messages Apr 13, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MAINTAINERS: place sifive_l2_cache.c only in SIFIVE DRIVERS

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: drivers/soc/sifive_l2_cache.c

Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part of the SIFIVE DRIVERS.

---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/[email protected]/
- was not picked up.

v1-resend: https://lore.kernel.org/lkml/[email protected]/

v2: reworked based on Boris comment; applies on v5.7-rc1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index e64e5db31497..e28676766b26 100644
@@ -6172,7 +6172,7 @@ M:	Yash Shah <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
+F:	drivers/soc/sifive/sifive_l2_cache.c
 
 EDAC-SKYLAKE
 M:	Tony Luck <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw
Quoted 48 lines · Lukas Bulwahn

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: drivers/soc/sifive_l2_cache.c

Boris suggested that sifive_l2_cache.c is considered part of the SIFIVE DRIVERS, not part of EDAC-SIFIVE. So, we can simply drop this entry, and by the sifive keyword pattern in SIFIVE PATTERNS, it is automatically part of the SIFIVE DRIVERS.

---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/[email protected]/
- was not picked up.

v1-resend: https://lore.kernel.org/lkml/[email protected]/

v2: reworked based on Boris comment; applies on v5.7-rc1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index e64e5db31497..e28676766b26 100644
@@ -6172,7 +6172,7 @@ M:	Yash Shah <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
+F:	drivers/soc/sifive/sifive_l2_cache.c
 
 EDAC-SKYLAKE
 M:	Tony Luck <[email protected]>
Signature · 1 line
2.17.1

Please ignore this patch. I accidently sent this patch out too quickly.

Please consider and pick this PATCH v3 instead:

https://lore.kernel.org/lkml/[email protected]/

Lukas