Skip to contentSkip to conversation

Duplicate versions of libsemanage symbols

PATCH In review Nicolas Iooss 2 participants 14 messages Apr 12, 2020 – Apr 15, 2020 SELinux security module

lore
Share & tools
lore
#0 lore raw

Hello,
Since recent changes in libsemanage.so's linker script, I have been experiencing issues. As I encountered these issues only when I was using a build configuration which is slightly different from what is in the repository, I wanted to spend time to investigate what was going on before eventually submitting a proper bug report. The issue I see is the following: when I compile with the gold linker and a custom set of build options, linking libsemanage.so fails with [1]:

/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_hll_compiler_path' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_set_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
...

Looking back at a normal build of current git master (that succeeded), I indeed have:

$ objdump -T libsemanage/src/libsemanage.so | grep
semanage_get_hll_compiler_path
000000000001b9b0 g    DF .text 000000000000021c  LIBSEMANAGE_1.0
semanage_get_hll_compiler_path

The same command on libsemanage 3.0 (last release) gives:

$ objdump -T /usr/lib/libsemanage.so | grep semanage_get_hll_compiler_path
000000000001a3c0 g    DF .text 0000000000000224  LIBSEMANAGE_1.1
semanage_get_hll_compiler_path

In short, semanage_get_hll_compiler_path is defined twice in libsemanage/src/libsemanage.map [2] and the linker only provides the first one. In fact, libsemanage.so built from git master has currently only 2 functions in LIBSEMANAGE_1.1:

$ objdump -T libsemanage/src/libsemanage.so | grep LIBSEMANAGE_1.1
000000000001e1f0 g    DF .text 000000000000010d  LIBSEMANAGE_1.1
semanage_module_install
000000000001eea0 g    DF .text 000000000000011f  LIBSEMANAGE_1.1
semanage_module_get_enabled

These functions changed their API between versions 1.0 and 1.1, so this is normal (there are .symver macros in the code and they work properly). The issue is that all the other symbols went into LIBSEMANAGE_1.0 instead of LIBSEMANAGE_1.1. Is this a bug or did I misunderstand something? Should the duplicated functions be removed from LIBSEMANAGE_1.0 in libsemanage.map?

Thanks,
Nicolas

[1] https://travis-ci.org/github/fishilico/selinux/jobs/674002033#L2471
[2] https://github.com/SELinuxProject/selinux/blob/aa40067b7b86d5e4c951fccae1aa98baff148613/libsemanage/src/libsemanage.map

#1 lore raw
Quoted 11 lines · Nicolas Iooss

Hello,
Since recent changes in libsemanage.so's linker script, I have been experiencing issues. As I encountered these issues only when I was using a build configuration which is slightly different from what is in the repository, I wanted to spend time to investigate what was going on before eventually submitting a proper bug report. The issue I see is the following: when I compile with the gold linker and a custom set of build options, linking libsemanage.so fails with [1]:

Quoted 10 lines

/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_hll_compiler_path' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_set_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
...

Does it actually fail or just print these warnings? IIRC, @sds replied with some superfluous linking warnings, but we ignored them. I tried looking through my mail
and the archive but I couldn't find it.

Quoted 26 lines

Looking back at a normal build of current git master (that succeeded), I indeed have:

$ objdump -T libsemanage/src/libsemanage.so | grep
semanage_get_hll_compiler_path
000000000001b9b0 g    DF .text 000000000000021c  LIBSEMANAGE_1.0
semanage_get_hll_compiler_path

The same command on libsemanage 3.0 (last release) gives:

$ objdump -T /usr/lib/libsemanage.so | grep semanage_get_hll_compiler_path
000000000001a3c0 g    DF .text 0000000000000224  LIBSEMANAGE_1.1
semanage_get_hll_compiler_path

In short, semanage_get_hll_compiler_path is defined twice in libsemanage/src/libsemanage.map [2] and the linker only provides the first one. In fact, libsemanage.so built from git master has currently only 2 functions in LIBSEMANAGE_1.1:

$ objdump -T libsemanage/src/libsemanage.so | grep LIBSEMANAGE_1.1
000000000001e1f0 g    DF .text 000000000000010d  LIBSEMANAGE_1.1
semanage_module_install
000000000001eea0 g    DF .text 000000000000011f  LIBSEMANAGE_1.1
semanage_module_get_enabled
Quoted 6 lines

These functions changed their API between versions 1.0 and 1.1, so this is normal (there are .symver macros in the code and they work properly). The issue is that all the other symbols went into LIBSEMANAGE_1.0 instead of LIBSEMANAGE_1.1. Is this a bug or did I misunderstand something? Should the duplicated functions be removed from LIBSEMANAGE_1.0 in libsemanage.map?

objdump -T is probably a better way to do this than what I had with readelf, as it shows the version.

Let me roll a patch, I probably have to go through the others as well.

Quoted 7 lines

Thanks,
Nicolas

[1] https://travis-ci.org/github/fishilico/selinux/jobs/674002033#L2471
[2] https://github.com/SELinuxProject/selinux/blob/aa40067b7b86d5e4c951fccae1aa98baff148613/libsemanage/src/libsemanage.map

#2 lore raw

PATCH 1/1 libsemanage: fix linker script symbol versions

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

In previous patched checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 30 +-----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)
libsemanage/src/libsemanage.map +1 -29
index ff5977b9f483..79aa8e693389 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
@@ -366,6 +338,7 @@ LIBSEMANAGE_1.1 {
     semanage_module_info_set_name;
     semanage_module_info_set_lang_ext;
     semanage_module_info_set_enabled;
+    semanage_module_install_info;
     semanage_module_key_create;
     semanage_module_key_destroy;
     semanage_module_key_get_priority;
@@ -376,7 +349,6 @@ LIBSEMANAGE_1.1 {
     semanage_module_list_all;
     semanage_module_get_enabled;
     semanage_module_set_enabled;
-    semanage_module_install_info;
     semanage_module_upgrade_info;
     semanage_module_remove_key;
     semanage_set_store_root;
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH] libsemanage: fix linker script symbol versions

Quoted 9 lines · On Sun, Apr 12, 2020 at 12:07 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

In previous patched checked for correctness by:

in previous patches...

Quoted 105 lines

This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 30 +-----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)
libsemanage/src/libsemanage.map +1 -28
index ff5977b9f483..79aa8e693389 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
@@ -366,6 +338,7 @@ LIBSEMANAGE_1.1 {
     semanage_module_info_set_name;
     semanage_module_info_set_lang_ext;
     semanage_module_info_set_enabled;
+    semanage_module_install_info;
     semanage_module_key_create;
     semanage_module_key_destroy;
     semanage_module_key_get_priority;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.1 { · line 379

Quoted 4 lines
libsemanage/src/libsemanage.map +0 -1
@@ -376,7 +349,6 @@ LIBSEMANAGE_1.1 {
     semanage_module_list_all;
     semanage_module_get_enabled;
     semanage_module_set_enabled;
-    semanage_module_install_info;

We don't need to move this.

Quoted 6 lines
libsemanage/src/libsemanage.map +0 -1
     semanage_module_upgrade_info;
     semanage_module_remove_key;
     semanage_set_store_root;
--

2.17.1

Ill aggregate feedback and send out a V2. This at least gets people up and running.

#4 lore raw

Re: [PATCH] libsemanage: fix linker script symbol versions

Quoted 133 lines · William Roberts
Quoted 9 lines · On Sun, Apr 12, 2020 at 12:07 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

In previous patched checked for correctness by:

in previous patches...

Quoted 105 lines

This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 30 +-----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)
libsemanage/src/libsemanage.map +1 -28
index ff5977b9f483..79aa8e693389 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
@@ -366,6 +338,7 @@ LIBSEMANAGE_1.1 {
     semanage_module_info_set_name;
     semanage_module_info_set_lang_ext;
     semanage_module_info_set_enabled;
+    semanage_module_install_info;
     semanage_module_key_create;
     semanage_module_key_destroy;
     semanage_module_key_get_priority;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.1 { · line 379

Quoted 4 lines
libsemanage/src/libsemanage.map +0 -1
@@ -376,7 +349,6 @@ LIBSEMANAGE_1.1 {
     semanage_module_list_all;
     semanage_module_get_enabled;
     semanage_module_set_enabled;
-    semanage_module_install_info;

We don't need to move this.

Quoted 6 lines
libsemanage/src/libsemanage.map +0 -1
     semanage_module_upgrade_info;
     semanage_module_remove_key;
     semanage_set_store_root;
--

2.17.1

Quoted 2 lines

Ill aggregate feedback and send out a V2. This at least gets people up and running.

Thanks for your patch. I have tested it and it indeed fixed the issues I had. I agree with your comments.

By the way, the .map file contains "semanage_module_upgrade_info" even though there is no symbol with this name in libsemanage. Should this line be removed? (in another patch)

Nicolas

#5 lore raw

Re: [PATCH] libsemanage: fix linker script symbol versions

Quoted 139 lines · Nicolas Iooss
Quoted 133 lines · William Roberts
Quoted 9 lines · On Sun, Apr 12, 2020 at 12:07 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

In previous patched checked for correctness by:

in previous patches...

Quoted 105 lines

This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 30 +-----------------------------
 1 file changed, 1 insertion(+), 29 deletions(-)
libsemanage/src/libsemanage.map +1 -28
index ff5977b9f483..79aa8e693389 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
@@ -366,6 +338,7 @@ LIBSEMANAGE_1.1 {
     semanage_module_info_set_name;
     semanage_module_info_set_lang_ext;
     semanage_module_info_set_enabled;
+    semanage_module_install_info;
     semanage_module_key_create;
     semanage_module_key_destroy;
     semanage_module_key_get_priority;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.1 { · line 379

Quoted 4 lines
libsemanage/src/libsemanage.map +0 -1
@@ -376,7 +349,6 @@ LIBSEMANAGE_1.1 {
     semanage_module_list_all;
     semanage_module_get_enabled;
     semanage_module_set_enabled;
-    semanage_module_install_info;

We don't need to move this.

Quoted 6 lines
libsemanage/src/libsemanage.map +0 -1
     semanage_module_upgrade_info;
     semanage_module_remove_key;
     semanage_set_store_root;
--

2.17.1

Quoted 2 lines

Ill aggregate feedback and send out a V2. This at least gets people up and running.

Quoted 6 lines

Thanks for your patch. I have tested it and it indeed fixed the issues I had. I agree with your comments.

By the way, the .map file contains "semanage_module_upgrade_info" even though there is no symbol with this name in libsemanage. Should this line be removed? (in another patch)

I see that, ill drop it as well.

Quoted 3 lines

Nicolas

#6 lore raw

PATCH 1/2 libsemanage: fix linker script symbol versions

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -28
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
Signature · 1 line
2.17.1
#7 lore raw

Re: [PATCH 1/2] libsemanage: fix linker script symbol versions

Quoted 106 lines · On Mon, Apr 13, 2020 at 8:03 AM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -29
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
--
Quoted 2 lines

2.17.1

Ignore this, it's missing the v2 declaration....

#8 lore raw

PATCH v2 1/2 libsemanage: fix linker script symbol versions

In reply to William Roberts

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -28
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
Signature · 1 line
2.17.1
#9 lore raw

PATCH v2 2/2 libsemanage: rm semanage_module_upgrade_info from map

From: William Roberts <[email protected]>

This routine was never defined, just declared as a prototype. Thus it never really existed, but remained in the map file. Remove it.

---
 libsemanage/src/libsemanage.map | 1 -
 1 file changed, 1 deletion(-)
libsemanage/src/libsemanage.map +0 -1
index 8ba2746deaa2..1375a8ca0ea7 100644
@@ -349,7 +349,6 @@ LIBSEMANAGE_1.1 {
     semanage_module_get_enabled;
     semanage_module_set_enabled;
     semanage_module_install_info;
-    semanage_module_upgrade_info;
     semanage_module_remove_key;
     semanage_set_store_root;
 } LIBSEMANAGE_1.0;
Signature · 1 line
2.17.1
author Acked-by on v2 1/2
#10 lore raw

Re: [PATCH v2 1/2] libsemanage: fix linker script symbol versions

In reply to [email protected]
Quoted 96 lines · On Mon, Apr 13, 2020 at 3:04 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -26
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.0 {

Quoted 10 lines
libsemanage/src/libsemanage.map +0 -3
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
--

I tested this patch, compared the symbols of libsemanage.so and everything looked good.

Thanks,
Nicolas

#11 lore raw

Re: [PATCH v2 1/2] libsemanage: fix linker script symbol versions

Quoted 112 lines · Nicolas Iooss
Quoted 96 lines · On Mon, Apr 13, 2020 at 3:04 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -26
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.0 {

Quoted 10 lines
libsemanage/src/libsemanage.map +0 -3
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
--

I tested this patch, compared the symbols of libsemanage.so and everything looked good.

Quoted 1 line

Staged:
https://github.com/SELinuxProject/selinux/pull/219

#12 lore raw

Re: [PATCH v2 1/2] libsemanage: fix linker script symbol versions

Quoted 114 lines · William Roberts
Quoted 112 lines · Nicolas Iooss
Quoted 96 lines · On Mon, Apr 13, 2020 at 3:04 PM <[email protected]> wrote:

From: William Roberts <[email protected]>

In previous work to cleanup the exports and linker scripts, I introduced a regression causing symbols to be named in both the 1.0 and 1.1 sections. This went un-noticed and was reported by [email protected].

Previous patches checked for correctness by:
This was checked by generating an old export map (from master):
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > old.map

Then creating a new one for this library after this patch is applied:
nm --defined-only -g ./src/libsemanage.so | cut -d' ' -f 3-3 | grep -v '^_' > new.map

And diffing them:
diff old.map new.map

However, this discards the version information. Nicolas points out a better way, by using objdump so we can see the version information. A better sequence of commands for checking is as follows:

git checkout 1967477913f6e
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.old

git checkout origin/master
objdump -T ./src/libsemanage.so | grep LIBSEMANAGE | cut -d' ' -f 8- | sed 's/^ //' > map.new

diff map.old map.new

---
 libsemanage/src/libsemanage.map | 28 ----------------------------
 1 file changed, 28 deletions(-)
libsemanage/src/libsemanage.map +0 -26
index ff5977b9f483..8ba2746deaa2 100644
@@ -76,10 +76,7 @@ LIBSEMANAGE_1.0 {
     semanage_fcontext_set_con;
     semanage_fcontext_set_expr;
     semanage_fcontext_set_type;
-    semanage_get_default_priority;
     semanage_get_disable_dontaudit;
-    semanage_get_hll_compiler_path;
-    semanage_get_ignore_module_cache;
     semanage_get_preserve_tunables;
     semanage_handle_create;
     semanage_handle_destroy;
@@ -170,39 +167,17 @@ LIBSEMANAGE_1.0 {
     semanage_mls_enabled;
     semanage_module_disable;
     semanage_module_enable;
-    semanage_module_extract;
     semanage_module_get_enabled;
-    semanage_module_get_module_info;
     semanage_module_get_name;
     semanage_module_get_version;
-    semanage_module_info_create;
     semanage_module_info_datum_destroy;
-    semanage_module_info_destroy;
-    semanage_module_info_get_enabled;
-    semanage_module_info_get_lang_ext;
-    semanage_module_info_get_name;
-    semanage_module_info_get_priority;
-    semanage_module_info_set_enabled;
-    semanage_module_info_set_lang_ext;
-    semanage_module_info_set_name;
-    semanage_module_info_set_priority;
     semanage_module_install;
     semanage_module_install_base;
     semanage_module_install_base_file;
     semanage_module_install_file;
-    semanage_module_install_info;
-    semanage_module_key_create;
-    semanage_module_key_destroy;
-    semanage_module_key_get_name;
-    semanage_module_key_get_priority;
-    semanage_module_key_set_name;
-    semanage_module_key_set_priority;
     semanage_module_list;
-    semanage_module_list_all;
     semanage_module_list_nth;
     semanage_module_remove;
-    semanage_module_remove_key;
-    semanage_module_set_enabled;
     semanage_module_upgrade;
     semanage_module_upgrade_file;
     semanage_msg_get_channel;
@@ -276,14 +251,11 @@ LIBSEMANAGE_1.0 {
     semanage_select_store;
     semanage_set_check_contexts;
     semanage_set_create_store;
-    semanage_set_default_priority;
     semanage_set_disable_dontaudit;

libsemanage/src/libsemanage.map LIBSEMANAGE_1.0 {

Quoted 10 lines
libsemanage/src/libsemanage.map +0 -3
-    semanage_set_ignore_module_cache;
     semanage_set_preserve_tunables;
     semanage_set_rebuild;
     semanage_set_reload;
     semanage_set_root;
-    semanage_set_store_root;
     semanage_seuser_clone;
     semanage_seuser_compare;
     semanage_seuser_compare2;
--

I tested this patch, compared the symbols of libsemanage.so and everything looked good.

Quoted 4 lines
Quoted 1 line

Staged:
https://github.com/SELinuxProject/selinux/pull/219

Merged:
https://github.com/SELinuxProject/selinux/pull/219

#13 lore raw
In reply to William Roberts
Quoted 62 lines · William Roberts
Quoted 11 lines · Nicolas Iooss

Hello,
Since recent changes in libsemanage.so's linker script, I have been experiencing issues. As I encountered these issues only when I was using a build configuration which is slightly different from what is in the repository, I wanted to spend time to investigate what was going on before eventually submitting a proper bug report. The issue I see is the following: when I compile with the gold linker and a custom set of build options, linking libsemanage.so fails with [1]:

Quoted 10 lines

/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_hll_compiler_path' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_get_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
/usr/bin/ld.gold: warning: using 'LIBSEMANAGE_1.0' as version for 'semanage_set_ignore_module_cache' which is also named in version 'LIBSEMANAGE_1.1' in script
...

Does it actually fail or just print these warnings? IIRC, @sds replied with some superfluous linking warnings, but we ignored them. I tried looking through my mail
and the archive but I couldn't find it.

Quoted 26 lines

Looking back at a normal build of current git master (that succeeded), I indeed have:

$ objdump -T libsemanage/src/libsemanage.so | grep
semanage_get_hll_compiler_path
000000000001b9b0 g    DF .text 000000000000021c  LIBSEMANAGE_1.0
semanage_get_hll_compiler_path

The same command on libsemanage 3.0 (last release) gives:

$ objdump -T /usr/lib/libsemanage.so | grep semanage_get_hll_compiler_path
000000000001a3c0 g    DF .text 0000000000000224  LIBSEMANAGE_1.1
semanage_get_hll_compiler_path

In short, semanage_get_hll_compiler_path is defined twice in libsemanage/src/libsemanage.map [2] and the linker only provides the first one. In fact, libsemanage.so built from git master has currently only 2 functions in LIBSEMANAGE_1.1:

$ objdump -T libsemanage/src/libsemanage.so | grep LIBSEMANAGE_1.1
000000000001e1f0 g    DF .text 000000000000010d  LIBSEMANAGE_1.1
semanage_module_install
000000000001eea0 g    DF .text 000000000000011f  LIBSEMANAGE_1.1
semanage_module_get_enabled
Quoted 6 lines

These functions changed their API between versions 1.0 and 1.1, so this is normal (there are .symver macros in the code and they work properly). The issue is that all the other symbols went into LIBSEMANAGE_1.0 instead of LIBSEMANAGE_1.1. Is this a bug or did I misunderstand something? Should the duplicated functions be removed from LIBSEMANAGE_1.0 in libsemanage.map?

Quoted 12 lines

objdump -T is probably a better way to do this than what I had with readelf, as it shows the version.

Let me roll a patch, I probably have to go through the others as well.

Quoted 7 lines

Thanks,
Nicolas

[1] https://travis-ci.org/github/fishilico/selinux/jobs/674002033#L2471
[2] https://github.com/SELinuxProject/selinux/blob/aa40067b7b86d5e4c951fccae1aa98baff148613/libsemanage/src/libsemanage.map

FYI the other 2 projects I touched with these changes seem to check out:
- libselinux checks out ok (it went from base to LIBSELINUX_1.0)
(a41dfeb55d vs current master)
- libsepol identical (f8c110c8a6 vs current master)