Skip to contentSkip to conversation

address automated build complaints

PATCH In review Shannon Nelson 2 participants 4 messages Apr 13, 2020 – Apr 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover address automated build complaints

Kernel build checks found a couple of things to improve.

Shannon Nelson (2):
ionic: add dynamic_debug header
ionic: fix unused assignment

 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 ionic: add dynamic_debug header

Add the appropriate header for using dynamic_hex_dump(), which seems to be incidentally included in some configurations but not all.

Fixes 7e4d47596b68 ("ionic: replay filters after fw upgrade")
---
 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c +1 -0
index f3c7dd1596ee..27b7eca19784 100644
@@ -2,6 +2,7 @@
 /* Copyright(c) 2017 - 2019 Pensando Systems, Inc */
 
 #include <linux/netdevice.h>
+#include <linux/dynamic_debug.h>
 #include <linux/etherdevice.h>
 
 #include "ionic.h"
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 ionic: fix unused assignment

In reply to Shannon Nelson

Remove an unused initialized value.

Fixes 7e4d47596b68 ("ionic: replay filters after fw upgrade")
---
 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c +1 -1
index 27b7eca19784..80eeb7696e01 100644
@@ -26,7 +26,7 @@ void ionic_rx_filter_replay(struct ionic_lif *lif)
 	struct hlist_head *head;
 	struct hlist_node *tmp;
 	unsigned int i;
-	int err = 0;
+	int err;
 
 	ac = &ctx.cmd.rx_filter_add;
 
Signature · 1 line
2.17.1