Skip to contentSkip to conversation

support/config-fragments/autobuild: add x86_64 glibc debug toolchain

PATCH New James Hilliard 2 participants 2 messages Feb 29, 2020 – Apr 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/config-fragments/autobuild: add x86_64 glibc debug toolchain

This toolchain config helps to catch build issues that are only reproducible when building with a debug optimizations enabled.

---
 .../autobuild/br-x86-64-internal-glibc-debug.config          | 5 +++++
 support/config-fragments/autobuild/toolchain-configs.csv     | 1 +
 2 files changed, 6 insertions(+)
 create mode 100644 support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config
support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config new file +5 -0
new file mode 100644
index 0000000000..7cf6238471
@@ -0,0 +1,5 @@
+BR2_x86_64=y
+BR2_OPTIMIZE_G=y
+BR2_ENABLE_DEBUG=y
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
support/config-fragments/autobuild/toolchain-configs.csv +1 -0
index 9b41e2173b..a2cd4a6768 100644
@@ -57,6 +57,7 @@ support/config-fragments/autobuild/br-riscv64-internal-musl.config,any
 support/config-fragments/autobuild/br-sh4-full.config,x86_64
 support/config-fragments/autobuild/br-sparc-uclibc.config,x86_64
 support/config-fragments/autobuild/br-sparc64-glibc.config,x86_64
+support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config,x86_64
 support/config-fragments/autobuild/br-x86-64-core2-full.config,x86_64
 support/config-fragments/autobuild/br-xtensa-full.config,x86_64
 support/config-fragments/autobuild/br-xtensa-full-internal.config,any
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 support/config-fragments/autobuild: add x86_64 glibc debug toolchain

Hello James,

Quoted 4 lines · On Fri, 28 Feb 2020 17:31:16 -0700 James Hilliard <[email protected]>…

This toolchain config helps to catch build issues that are only reproducible when building with a debug optimizations enabled.

Thanks for this proposal, but what you propose is not how we want to deal with that. See below.

support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config line 2

Quoted 8 lines
support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config new file +2 -0
new file mode 100644
index 0000000000..7cf6238471
@@ -0,0 +1,5 @@
+BR2_x86_64=y
+BR2_OPTIMIZE_G=y

We already have some explicit randomization for BR2_OPTIMIZE_2 in utils/genrandconfig, so we should probably extend that to include the other optimization levels in the randomization, including BR2_OPTIMIZE_G. Patches welcome.

support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config line 3

Quoted 1 line
support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config new file +1 -0
+BR2_ENABLE_DEBUG=y

We already have randomization for this option in utils/genrandconfig.

support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config line 5

Quoted 2 lines
support/config-fragments/autobuild/br-x86-64-internal-glibc-debug.config new file +2 -0
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y

So the question is whether we want to add a x86-64/glibc internal toolchain. We do already have an br-arm-internal-glibc.config, which with the randomization of BR2_ENABLE_DEBUG=y already in place + the randomization of BR2_OPTIMIZE_G=y that can easily be added, would be suitable to test the cases you're pointing to.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com