Skip to contentSkip to conversation

package/python-coherence: select pyasn1 instead of pyasn

PATCH New James Hilliard 2 participants 4 messages Apr 13, 2020 – Apr 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-coherence: select pyasn1 instead of pyasn

The python-pyasn package is an outdated version of python-pyasn1 and should not be used.

We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1 does not depend on it.

---
 package/python-coherence/Config.in | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
package/python-coherence/Config.in +1 -6
index 63427964a7..0f50080e67 100644
@@ -1,15 +1,10 @@
 config BR2_PACKAGE_PYTHON_COHERENCE
 	bool "python-coherence"
 	depends on BR2_PACKAGE_PYTHON
-	depends on BR2_INSTALL_LIBSTDCPP # python-pyasn
 	select BR2_PACKAGE_PYTHON_TWISTED
 	select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE
-	select BR2_PACKAGE_PYTHON_PYASN
+	select BR2_PACKAGE_PYTHON_PYASN1
 	help
 	  A DLNA/UPnP Media Server and Framework for the Digital Living.
 
 	  https://github.com/coherence-project/Coherence
-
-comment "python-coherence needs a toolchain w/ C++"
-	depends on BR2_PACKAGE_PYTHON
-	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/python-coherence: select pyasn1 instead of pyasn

Quoted 10 lines · On Mon, 13 Apr 2020 17:17:04 -0600 James Hilliard <[email protected]>…

The python-pyasn package is an outdated version of python-pyasn1 and should not be used.

We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1 does not depend on it.

---
 package/python-coherence/Config.in | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Applied to master, thanks. I assume your plan is to get rid of python-pyasn and python-pyasn-modules now?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-coherence: select pyasn1 instead of pyasn

Quoted 10 lines · Thomas Petazzoni
Quoted 6 lines · On Mon, 13 Apr 2020 17:17:04 -0600 James Hilliard <[email protected]>…

The python-pyasn package is an outdated version of python-pyasn1 and should not be used.

We no longer need to depend on BR2_INSTALL_LIBSTDCPP as python-pyasn1 does not depend on it.

Quoted 7 lines
Quoted 4 lines
---
 package/python-coherence/Config.in | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Applied to master, thanks. I assume your plan is to get rid of python-pyasn and python-pyasn-modules now?

Yep, was just waiting on these to be merged first.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

PATCH 1/1 package/python-coherence: select pyasn1 instead of pyasn

Quoted 3 lines · On Sun, 19 Apr 2020 02:21:30 -0600 James Hilliard <[email protected]>…
Quoted 2 lines

Applied to master, thanks. I assume your plan is to get rid of python-pyasn and python-pyasn-modules now?

Yep, was just waiting on these to be merged first.

In this sort of situation, you can also send a series of patches. The fact that they are sent as as series makes it clear that they have a dependency.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com