Skip to contentSkip to conversation

Fixes for ASoC DPCM and topology

PATCH In review Gyeongtaek Lee 2 participants 5 messages Apr 14, 2020 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200414014858epcas2p3e9028454a601cd9852ba6444f183d8c9@epcas2p3.samsung.com

#1 lore raw

cover Fixes for ASoC DPCM and topology

Hi,

I'd like to request cherry-picking some fixes for ALSA SoC to stable branch.
Those patches are fix or add couple of functions which are essential when ALSA topology and Compress offload is used with Dynamic PCM.
All fixes are tested on 4.19 and 5.4.

1. Fix overflow of register mask when shift value is set to 32.
2. Default value setting for virtual kcontrol
3. Error on offload playback start or stop after pause
4. Prefix missing when a kcontrol is created with ASoC component with name prefix.

Commit ID:
0ab070917afdc93670c2d0ea02ab6defb6246a7c
3bbbb7728fc853d71dbce4073fef9f281fbfb4dd
21fca8bdbb64df1297e8c65a746c4c9f4a689751
abca9e4a04fbe9c6df4d48ca7517e1611812af25

Kernel version wish it to be applied:
5.4

Subject:
이경택 (4):
ASoC: fix regwmask
ASoC: dapm: connect virtual mux with default value
ASoC: dpcm: allow start or stop during pause for backend
ASoC: topology: use name_prefix for new kcontrol

 sound/soc/soc-dapm.c     | 8 +++++++-
 sound/soc/soc-ops.c      | 4 ++--
 sound/soc/soc-pcm.c      | 6 ++++--
 sound/soc/soc-topology.c | 2 +-
 4 files changed, 14 insertions(+), 6 deletions(-)

base-commit: bc844d58f697dff3ded4b410094ee89f5cedc04c

Signature · 1 line
2.21.0
#2 lore raw
Quoted 12 lines · Gyeongtaek Lee

Hi,

I'd like to request cherry-picking some fixes for ALSA SoC to stable branch.
Those patches are fix or add couple of functions which are essential when ALSA topology and Compress offload is used with Dynamic PCM.
All fixes are tested on 4.19 and 5.4.

1. Fix overflow of register mask when shift value is set to 32.
2. Default value setting for virtual kcontrol
3. Error on offload playback start or stop after pause
4. Prefix missing when a kcontrol is created with ASoC component with name prefix.

Quoted 8 lines

Commit ID:
0ab070917afdc93670c2d0ea02ab6defb6246a7c
3bbbb7728fc853d71dbce4073fef9f281fbfb4dd
21fca8bdbb64df1297e8c65a746c4c9f4a689751
abca9e4a04fbe9c6df4d48ca7517e1611812af25

Kernel version wish it to be applied:
5.4

Given these showed up in 5.7-rc1, they also need to go to 5.5.y and 5.6.y as those trees are currently active. You can not have someone upgrade from one stable release to another one and have a regression.

thanks,

greg k-h

#3 lore raw
In reply to Gyeongtaek Lee
Quoted 12 lines · Gyeongtaek Lee

Hi,

I'd like to request cherry-picking some fixes for ALSA SoC to stable branch.
Those patches are fix or add couple of functions which are essential when ALSA topology and Compress offload is used with Dynamic PCM.
All fixes are tested on 4.19 and 5.4.

1. Fix overflow of register mask when shift value is set to 32.
2. Default value setting for virtual kcontrol
3. Error on offload playback start or stop after pause
4. Prefix missing when a kcontrol is created with ASoC component with name prefix.

Quoted 8 lines

Commit ID:
0ab070917afdc93670c2d0ea02ab6defb6246a7c
3bbbb7728fc853d71dbce4073fef9f281fbfb4dd
21fca8bdbb64df1297e8c65a746c4c9f4a689751
abca9e4a04fbe9c6df4d48ca7517e1611812af25

Kernel version wish it to be applied:
5.4

Wait, you say 5.4, but you tested on 4.19? What about older kernels, some of these seem relevant there too.

greg k-h

#4 lore raw
Quoted 19 lines · Greg KH
Quoted 18 lines · Gyeongtaek Lee

Hi,

I'd like to request cherry-picking some fixes for ALSA SoC to stable branch.
Those patches are fix or add couple of functions which are essential when ALSA topology and Compress offload is used with Dynamic PCM.
All fixes are tested on 4.19 and 5.4.

1. Fix overflow of register mask when shift value is set to 32.
2. Default value setting for virtual kcontrol
3. Error on offload playback start or stop after pause
4. Prefix missing when a kcontrol is created with ASoC component with name prefix.

Commit ID:
0ab070917afdc93670c2d0ea02ab6defb6246a7c
3bbbb7728fc853d71dbce4073fef9f281fbfb4dd
21fca8bdbb64df1297e8c65a746c4c9f4a689751
abca9e4a04fbe9c6df4d48ca7517e1611812af25

Quoted 5 lines
Quoted 2 lines

Kernel version wish it to be applied:
5.4

Wait, you say 5.4, but you tested on 4.19? What about older kernels, some of these seem relevant there too.

Looks like it builds everywhere, so I've now done that. If I should drop this from any specific kernel version, please let me know.

thanks,

greg k-h

#5 lore raw
In reply to Greg KH
Quoted 6 lines · Greg KH
Quoted 5 lines · Greg KH
Quoted 4 lines · Gyeongtaek Lee

Hi,

I'd like to request cherry-picking some fixes for ALSA SoC to stable branch.
Those patches are fix or add couple of functions which are essential when ALSA topology and Compress offload is used with

Dynamic

Quoted 20 lines
Quoted 14 lines
Quoted 14 lines

PCM.
All fixes are tested on 4.19 and 5.4.

1. Fix overflow of register mask when shift value is set to 32.
2. Default value setting for virtual kcontrol
3. Error on offload playback start or stop after pause
4. Prefix missing when a kcontrol is created with ASoC component with name prefix.

Commit ID:
0ab070917afdc93670c2d0ea02ab6defb6246a7c
3bbbb7728fc853d71dbce4073fef9f281fbfb4dd
21fca8bdbb64df1297e8c65a746c4c9f4a689751
abca9e4a04fbe9c6df4d48ca7517e1611812af25

Quoted 5 lines
Quoted 2 lines

Kernel version wish it to be applied:
5.4

Wait, you say 5.4, but you tested on 4.19? What about older kernels, some of these seem relevant there too.

Quoted 7 lines

Looks like it builds everywhere, so I've now done that. If I should drop this from any specific kernel version, please let me know.

thanks,

greg k-h

Thank you so much for your kind work!

Gyeongtaek