Skip to contentSkip to conversation

Staging: fbtft : fbtft-bus: fixed two checkpatch errors

PATCH In review [email protected] 2 participants 2 messages Apr 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: fbtft : fbtft-bus: fixed two checkpatch errors

From: Carlos Guerrero Álvarez <[email protected]>

Fixed two checkpatch space prohibited before that close parenthesis errors.

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
index 63c65dd67b17..cdb451dd3fde 100644
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
2.26.0
maintainer
#1 lore raw
Quoted 14 lines · On Tue, Apr 14, 2020 at 09:30:47AM +0200, [email protected] wrote:

From: Carlos Guerrero Álvarez <[email protected]>

Fixed two checkpatch space prohibited before that close parenthesis errors.

---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index 63c65dd67b17..cdb451dd3fde 100644

drivers/staging/fbtft/fbtft-bus.c out: \ · line 67

Quoted 8 lines
drivers/staging/fbtft/fbtft-bus.c +2 -2
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

If I remember correct, the original code here is required, due to how some older versions of gcc works.

Did you test-build this? Did it work properly?

I would just leave this alone,

greg k-h