Skip to contentSkip to conversation

ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts

PATCH In review Manikanta Pubbisetty 2 participants 3 messages Apr 9, 2020 – Apr 14, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts

Unlike CE interrupts, DP interrupts are not enabled/disabled at source; they are enabled/disabled only at GIC level, therefore it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious interrupts.

---
 drivers/net/wireless/ath/ath11k/ahb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/ahb.c +1 -1
index 59342d2..3b2b76d 100644
@@ -788,7 +788,7 @@ static int ath11k_ahb_ext_irq_config(struct ath11k_base *ab)
 			irq = platform_get_irq_byname(ab->pdev,
 						      irq_name[irq_idx]);
 			ab->irq_num[irq_idx] = irq;
-			irq_set_status_flags(irq, IRQ_NOAUTOEN);
+			irq_set_status_flags(irq, IRQ_NOAUTOEN | IRQ_DISABLE_UNLAZY);
 			ret = request_irq(irq, ath11k_ahb_ext_interrupt_handler,
 					  IRQF_TRIGGER_RISING,
 					  irq_name[irq_idx], irq_grp);
Signature · 6 lines
2.7.4

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 7 lines · Manikanta Pubbisetty

Unlike CE interrupts, DP interrupts are not enabled/disabled at source; they are enabled/disabled only at GIC level, therefore it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious interrupts.

Patch applied to ath-next branch of ath.git, thanks.

05090864fc7e ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts

Signature · 8 lines
https://patchwork.kernel.org/patch/11481417/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
In reply to Manikanta Pubbisetty
Quoted 7 lines · Manikanta Pubbisetty

Unlike CE interrupts, DP interrupts are not enabled/disabled at source; they are enabled/disabled only at GIC level, therefore it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious interrupts.

Patch applied to ath-next branch of ath.git, thanks.

05090864fc7e ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts

Signature · 3 lines
https://patchwork.kernel.org/patch/11481417/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches