qcow2: Add incompatibility note between backing files and raw external data files
PATCH 1/1 qcow2: Add incompatibility note between backing files and raw external data files
Backing files and raw external data files are mutually exclusive. The documentation of the raw external data bit (in autoclear_features) already indicates that, but we should also mention it on the other side.
--- docs/interop/qcow2.txt | 3 +++ 1 file changed, 3 insertions(+)
docs/interop/qcow2.txt +3 -0
@@ -25,6 +25,9 @@ The first cluster of a qcow2 image contains the file header: is stored (NB: The string is not null terminated). 0 if the image doesn't have a backing file. + Note: backing files are incompatible with raw external data + files (auto-clear feature bit 1). + 16 - 19: backing_file_size Length of the backing file name in bytes. Must not be longer than 1023 bytes. Undefined if the image doesn't have
Signature · 1 line
2.20.1
Quoted 17 lines · Alberto Garcia
Backing files and raw external data files are mutually exclusive. The documentation of the raw external data bit (in
autoclear_features) already indicates that, but we should also mention it on the other side.Suggested-by Eric Blake <[email protected]>Signed-off-by Alberto Garcia <[email protected]>--- docs/interop/qcow2.txt | 3 +++ 1 file changed, 3 insertions(+)docs/interop/qcow2.txt +0
-0
docs/interop/qcow2.txt The first cluster of a qcow2 image contains the file header: · line 33
Quoted 9 lines
docs/interop/qcow2.txt +3
-0@@ -25,6 +25,9 @@ The first cluster of a qcow2 image contains the file header: is stored (NB: The string is not null terminated). 0 if the image doesn't have a backing file. + Note: backing files are incompatible with raw external data + files (auto-clear feature bit 1). + 16 - 19: backing_file_size Length of the backing file name in bytes. Must not be longer than 1023 bytes. Undefined if the image doesn't have
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Kevin Wolf
AppliedAm 10.04.2020 um 14:18 hat Alberto Garcia geschrieben:
Quoted 7 lines
Backing files and raw external data files are mutually exclusive. The documentation of the raw external data bit (in
autoclear_features) already indicates that, but we should also mention it on the other side.Suggested-by Eric Blake <[email protected]>Signed-off-by Alberto Garcia <[email protected]>
Thanks, applied to the block branch.
I don't think this is critical for 5.0, so if I make a pull request for other reasons, I'll include it, but if you agree, I won't send one just for this patch.
Kevin
Quoted 3 lines · Kevin Wolf
I don't think this is critical for 5.0, so if I make a pull request for other reasons, I'll include it, but if you agree, I won't send one just for this patch.
Sure, no problem.
Berto