PCI: Don't select Kconfig symbols by default
Subsystems (2)
cover PCI: Don't select Kconfig symbols by default
From: Bjorn Helgaas <[email protected]>
A few Kconfig symbols snuck in with "default y". In general we don't want that because we don't want to bloat the kernel with unnecessary drivers.
Remove the ones that are optional.
There are a few left, but they depend on something else that seems like the real choice, e.g., XEN_PCIDEV_FRONTEND depends on XEN and PCI_XGENE_MSI depends on PCI_XGENE.
Bjorn Helgaas (4):
PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST by default PCI/AER: Don't select CONFIG_PCIEAER by default PCI/ASPM: Don't select CONFIG_PCIEASPM by default
drivers/pci/controller/dwc/Kconfig | 2 -- drivers/pci/pcie/Kconfig | 2 -- 2 files changed, 4 deletions(-)
Signature · 1 line
2.26.0.110.g2183baf09c-goog
PATCH 1/4 PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
From: Bjorn Helgaas <[email protected]>
Drivers should not be selected by default because that bloats the kernel for people who don't need them.
Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
--- drivers/pci/controller/dwc/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +0 -1
@@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST depends on OF && HAS_IOMEM && TI_PIPE3 select PCIE_DW_HOST select PCI_DRA7XX - default y help Enables support for the PCIe controller in the DRA7xx SoC to work in host mode. There are two instances of PCIe controller in DRA7xx.
Signature · 1 line
2.26.0.110.g2183baf09c-goog
Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
Quoted 19 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
Drivers should not be selected by default because that bloats the kernel for people who don't need them.
Remove the "default y" for
CONFIG_PCI_DRA7XX_HOST.Signed-off-by Bjorn Helgaas <[email protected]>Cc Kishon Vijay Abraham I <[email protected]>--- drivers/pci/controller/dwc/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/pci/controller/dwc/Kconfig +0
-0
drivers/pci/controller/dwc/Kconfig config PCI_DRA7XX_HOST · line 29
Quoted 4 lines
drivers/pci/controller/dwc/Kconfig +0
-1@@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST depends on OF && HAS_IOMEM && TI_PIPE3 select PCIE_DW_HOST select PCI_DRA7XX - default y
Perhaps 'default y if SOC_DRA7XX'?
Quoted 6 lines
drivers/pci/controller/dwc/Kconfig +0
-0help Enables support for the PCIe controller in the DRA7xx SoC to work in host mode. There are two instances of PCIe controller in DRA7xx.Signature · 1 line
2.26.0.110.g2183baf09c-goog
Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
Quoted 15 lines · Rob Herring
Quoted 14 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
Drivers should not be selected by default because that bloats the kernel for people who don't need them.
Remove the "default y" for
CONFIG_PCI_DRA7XX_HOST.Signed-off-by Bjorn Helgaas <[email protected]>Cc Kishon Vijay Abraham I <[email protected]>--- drivers/pci/controller/dwc/Kconfig | 1 - 1 file changed, 1 deletion(-)
Quoted 11 lines
drivers/pci/controller/dwc/Kconfig config PCI_DRA7XX_HOST · line 29
Quoted 9 lines
drivers/pci/controller/dwc/Kconfig +0
-1@@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST depends on OF && HAS_IOMEM && TI_PIPE3 select PCIE_DW_HOST select PCI_DRA7XX - default yPerhaps 'default y if
SOC_DRA7XX'?
Good idea, I did that.
PATCH 2/4 PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST by default
In reply to Bjorn HelgaasFrom: Bjorn Helgaas <[email protected]>
Drivers should not be selected by default because that bloats the kernel for people who don't need them.
Remove the "default y" for CONFIG_PCI_KEYSTONE_HOST.
--- drivers/pci/controller/dwc/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/Kconfig +0 -1
@@ -110,7 +110,6 @@ config PCI_KEYSTONE_HOST depends on PCI_MSI_IRQ_DOMAIN select PCIE_DW_HOST select PCI_KEYSTONE - default y help Enables support for the PCIe controller in the Keystone SoC to work in host mode. The PCI controller on Keystone is based on
Signature · 7 lines
2.26.0.110.g2183baf09c-goog _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 3/4 PCI/AER: Don't select CONFIG_PCIEAER by default
In reply to Bjorn HelgaasFrom: Bjorn Helgaas <[email protected]>
PCIe Advanced Error Reporting (AER) is optional and there's no need for it to be selected by default.
Remove the "default y" for CONFIG_PCIEAER.
--- drivers/pci/pcie/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/pci/pcie/Kconfig +0 -1
@@ -25,7 +25,6 @@ config PCIEAER bool "PCI Express Advanced Error Reporting support" depends on PCIEPORTBUS select RAS - default y help This enables PCI Express Root Port Advanced Error Reporting (AER) driver support. Error reporting messages sent to Root
Signature · 1 line
2.26.0.110.g2183baf09c-goog
Re: [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER by default
Hi,
Quoted 6 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
PCIe Advanced Error Reporting (AER) is optional and there's no need for it to be selected by default.
Remove the "default y" for
CONFIG_PCIEAER.
Makes sense.
Quoted 23 lines
Signed-off-by Bjorn Helgaas <[email protected]>Cc Russell Currey <[email protected]>Cc Sam Bobroff <[email protected]>Cc Oliver O'Halloran <[email protected]>Cc Kuppuswamy Sathyanarayanan <[email protected]>--- drivers/pci/pcie/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/pci/pcie/Kconfig +0
-1@@ -25,7 +25,6 @@ config PCIEAER bool "PCI Express Advanced Error Reporting support" depends on PCIEPORTBUS select RAS - default y help This enables PCI Express Root Port Advanced Error Reporting (AER) driver support. Error reporting messages sent to Root
PATCH 4/4 PCI/ASPM: Don't select CONFIG_PCIEASPM by default
In reply to Bjorn HelgaasFrom: Bjorn Helgaas <[email protected]>
PCIe Active State Power Management (ASPM) is optional and there's no need for it to be selected by default.
Remove the "default y" for CONFIG_PCIEASPM.
--- drivers/pci/pcie/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/pci/pcie/Kconfig +0 -1
@@ -62,7 +62,6 @@ config PCIE_ECRC # config PCIEASPM bool "PCI Express ASPM control" if EXPERT - default y help This enables OS control over PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports
Signature · 1 line
2.26.0.110.g2183baf09c-goog
Re: [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM by default
Quoted 9 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
PCIe Active State Power Management (ASPM) is optional and there's no need for it to be selected by default.
Remove the "default y" for
CONFIG_PCIEASPM.Signed-off-by Bjorn Helgaas <[email protected]>Cc Heiner Kallweit <[email protected]>
I dropped this patch for now.
Without CONFIG_PCIEASPM, Linux doesn't request control of *any* features via _OSC (see ACPI_PCIE_REQ_SUPPORT), which means we can't use PCIe PME to resume from runtime suspend.
https://bugzilla.redhat.com/show_bug.cgi?id=638912
https://lore.kernel.org/r/[email protected]
Quoted 19 lines
--- drivers/pci/pcie/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/pci/pcie/Kconfig +0
-1@@ -62,7 +62,6 @@ config PCIE_ECRC # config PCIEASPM bool "PCI Express ASPM control" if EXPERT - default y help This enables OS control over PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supportsSignature · 1 line
2.26.0.110.g2183baf09c-goog
Quoted 17 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
A few
Kconfigsymbols snuck in with "default y". In general we don't want that because we don't want to bloat the kernel with unnecessary drivers.Remove the ones that are optional.
There are a few left, but they depend on something else that seems like the real choice, e.g.,
XEN_PCIDEV_FRONTENDdepends on XEN andPCI_XGENE_MSIdepends onPCI_XGENE.Bjorn Helgaas (4):
PCI: dra7xx: Don't selectCONFIG_PCI_DRA7XX_HOSTby default
PCI: keystone: Don't selectCONFIG_PCI_KEYSTONE_HOSTby default PCI/AER: Don't selectCONFIG_PCIEAERby default PCI/ASPM: Don't selectCONFIG_PCIEASPMby default
Quoted 3 lines
drivers/pci/controller/dwc/Kconfig | 2 -- drivers/pci/pcie/Kconfig | 2 -- 2 files changed, 4 deletions(-)
Applied with Sathy's reviewed-by on the AER patch and the tweak Rob suggested to the dra7xx one to pci/kconfig for v5.8.