dax: Add missing annotation for wait_entry_unlocked()
PATCH v2 1/1 dax: Add missing annotation for wait_entry_unlocked()
Sparse reports a warning at wait_entry_unlocked()
warning: context imbalance in wait_entry_unlocked() - unexpected unlock
The root cause is the missing annotation at wait_entry_unlocked() Add the missing __releases(xas->xa->xa_lock) annotation
Signed-off-by Jules Irenge <[email protected]>
--- fs/dax.c | 1 + 1 file changed, 1 insertion(+)
fs/dax.c +1 -0
@@ -244,6 +244,7 @@ static void *get_unlocked_entry(struct xa_state *xas, unsigned int order)* After we call xas_unlock_irq(), we cannot touch xas->xa. */ static void wait_entry_unlocked (struct xa_state *xas,void *entry) + __releases(xas->xa->xa_lock) {struct wait_exceptional_entry_queue ewait;wait_queue_head_t *wq;
Signature · 6 lines
Change since v2 - gives more accurate lock variable name 2.25.1 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Quoted 8 lines · Jules Irenge
Sparse reports a warning at
wait_entry_unlocked()warning: context imbalance in
wait_entry_unlocked()- unexpected unlockThe root cause is the missing annotation at
wait_entry_unlocked()Add the missing__releases(xas->xa->xa_lock)annotationSigned-off-by Jules Irenge <[email protected]>
The patch looks good to me. You can add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 21 lines
--- fs/dax.c | 1 + 1 file changed, 1 insertion(+)fs/dax.c +1
-0@@ -244,6 +244,7 @@ static void *get_unlocked_entry(struct xa_state *xas, unsigned int order)* After we call xas_unlock_irq(), we cannot touch xas->xa. */ static void wait_entry_unlocked (struct xa_state *xas,void *entry) + __releases(xas->xa->xa_lock) {struct wait_exceptional_entry_queue ewait;wait_queue_head_t *wq;Signature · 3 lines
Change since v2 - gives more accurate lock variable name 2.25.1
Signature · 5 lines
Jan Kara <[email protected]> SUSE Labs, CR _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]