Skip to contentSkip to conversation

dev-manual: remove postinst false statement

PATCH Superseded Maxime Roussin-B?langer 2 participants 3 messages Apr 15, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dev-manual: remove postinst false statement

This outdated section contradicts the real behavior expressed in the next paragraph

---
 documentation/dev-manual/dev-manual-common-tasks.xml | 2 --
 1 file changed, 2 deletions(-)
documentation/dev-manual/dev-manual-common-tasks.xml +0 -2
index 8bb8612e0f..997e4777b0 100644
@@ -3284,8 +3284,6 @@
                 The script defined in the post-installation function is
                 called when the root filesystem is created.
                 If the script succeeds, the package is marked as installed.
-                If the script fails, the package is marked as unpacked and
-                the script is executed when the image boots again.
                 <note>
                     Any RPM post-installation script that runs on the target
                     should return a 0 exit code.
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 tzdata: remove exit 0 from pkg_postinst

Documentation says that if you exit 0 in a pkg_postinst it will marked as installed.
If you exit 0, before running postinst-intercepts defer_to_first_boot, the pkg_postinst_ontarget script will not be present on target.

The "exit 0" in tzdata makes it difficult to have a bbappend with a pkg_postinst_target step when you have INSTALL_TIMEZONE_FILE = 0

---
 meta/recipes-extended/timezone/tzdata.bb | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
meta/recipes-extended/timezone/tzdata.bb +2 -6
index 1e2d9bd1b9..1e2b440fb0 100644
@@ -60,12 +60,8 @@ pkg_postinst_${PN} () {
 	if [ -e ${src} ] ; then
 		tz=$(sed -e 's:#.*::' -e 's:[[:space:]]*::g' -e '/^$/d' "${src}")
 	fi
-	
-	if [ -z "${tz}" ] ; then
-		exit 0
-	fi
-	
-	if [ ! -e "$D${datadir}/zoneinfo/${tz}" ] ; then
+
+	if [ ! -z "${tz}" -a ! -e "$D${datadir}/zoneinfo/${tz}" ] ; then
 		echo "You have an invalid TIMEZONE setting in ${src}"
 		echo "Your ${etc_lt} has been reset to Universal; enjoy!"
 		tz="Universal"
Signature · 1 line
2.20.1
#2 lore raw

✗ patchtest: failure for "dev-manual: remove postinst fa..." and 1 more

In reply to Maxime Roussin-B?langer

== Series Details ==

Series: "dev-manual: remove postinst fa..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/23753/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list]

  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     [email protected] [http://git.yoctoproject.org/cgit/cgit.cgi/yocto-docs/]
  Patch's path:    documentation/dev-manual/dev-manual-common-tasks.xml

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 1795f30d8a)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe