Skip to contentSkip to conversation

signal: Prevent double-free of user struct

PATCH In review Matt Fleming 3 participants 4 messages Apr 7, 2020 – Apr 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 signal: Prevent double-free of user struct

The way user struct reference counting works changed significantly with,

fda31c50292a ("signal: avoid double atomic counter increments for user accounting")

Now user structs are only freed once the last pending signal is dequeued. Make sigqueue_free_current() follow this new convention to avoid freeing the user struct multiple times and triggering this warning:

refcount_t: underflow; use-after-free.

 WARNING: CPU: 0 PID: 6794 at lib/refcount.c:288 refcount_dec_not_one+0x45/0x50
 Call Trace:
  refcount_dec_and_lock_irqsave+0x16/0x60
  free_uid+0x31/0xa0
  ? schedule_hrtimeout_range_clock+0x104/0x110
  __dequeue_signal+0x17c/0x190
  dequeue_signal+0x5a/0x1b0
  do_sigtimedwait+0x208/0x250
  __x64_sys_rt_sigtimedwait+0x6f/0xd0
  do_syscall_64+0x72/0x200
  entry_SYSCALL_64_after_hwframe+0x49/0xbe
---
 kernel/signal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/signal.c +2 -2
index 267fce07df5d..3651483bd4d8 100644
@@ -494,8 +494,8 @@ static void sigqueue_free_current(struct sigqueue *q)
 
 	up = q->user;
 	if (rt_prio(current->normal_prio) && !put_task_cache(current, q)) {
-		atomic_dec(&up->sigpending);
-		free_uid(up);
+		if (atomic_dec_and_test(&up->sigpending))
+			free_uid(up);
 	} else
 		  __sigqueue_free(q);
 }
Signature · 1 line
2.16.4
#1 lore raw
Quoted 10 lines · Matt Fleming

The way user struct reference counting works changed significantly with,

fda31c50292a ("signal: avoid double atomic counter increments for user accounting")

Now user structs are only freed once the last pending signal is dequeued. Make sigqueue_free_current() follow this new convention to avoid freeing the user struct multiple times and triggering this warning:

refcount_t: underflow; use-after-free.

Quoted 11 lines
 WARNING: CPU: 0 PID: 6794 at lib/refcount.c:288 refcount_dec_not_one+0x45/0x50
 Call Trace:
  refcount_dec_and_lock_irqsave+0x16/0x60
  free_uid+0x31/0xa0
  ? schedule_hrtimeout_range_clock+0x104/0x110
  __dequeue_signal+0x17c/0x190
  dequeue_signal+0x5a/0x1b0
  do_sigtimedwait+0x208/0x250
  __x64_sys_rt_sigtimedwait+0x6f/0xd0
  do_syscall_64+0x72/0x200
  entry_SYSCALL_64_after_hwframe+0x49/0xbe

While all this sounds reasonable, may I ask what did you do to trigger this?
This is v5.6 only, correct?

Sebastian

#2 lore raw

Hi Sebastian,

Quoted 23 lines · Sebastian Andrzej Siewior
Quoted 10 lines · Matt Fleming

The way user struct reference counting works changed significantly with,

fda31c50292a ("signal: avoid double atomic counter increments for user accounting")

Now user structs are only freed once the last pending signal is dequeued. Make sigqueue_free_current() follow this new convention to avoid freeing the user struct multiple times and triggering this warning:

refcount_t: underflow; use-after-free.

Quoted 11 lines
  WARNING: CPU: 0 PID: 6794 at lib/refcount.c:288 refcount_dec_not_one+0x45/0x50
  Call Trace:
   refcount_dec_and_lock_irqsave+0x16/0x60
   free_uid+0x31/0xa0
   ? schedule_hrtimeout_range_clock+0x104/0x110
   __dequeue_signal+0x17c/0x190
   dequeue_signal+0x5a/0x1b0
   do_sigtimedwait+0x208/0x250
   __x64_sys_rt_sigtimedwait+0x6f/0xd0
   do_syscall_64+0x72/0x200
   entry_SYSCALL_64_after_hwframe+0x49/0xbe
Quoted 2 lines

While all this sounds reasonable, may I ask what did you do to trigger this?

This can be triggered by running sigwaittest.

 # sigwaittest -t -a -p 98

a few seconds should be enough to get the splat.

Quoted 1 line

This is v5.6 only, correct?

I've seen this also with a frankstein version of 5.2-rt...v5-4-rt :)

Thanks,
Daniel

#3 lore raw
Quoted 1 line · Daniel Wagner

Hi Sebastian,

Hi Daniel,

Quoted 5 lines

This can be triggered by running sigwaittest.

 # sigwaittest -t -a -p 98

a few seconds should be enough to get the splat.

thank you.

Quoted 3 lines
Quoted 1 line

This is v5.6 only, correct?

I've seen this also with a frankstein version of 5.2-rt...v5-4-rt :)

…

Quoted 2 lines

Thanks,
Daniel

Sebastian