Skip to contentSkip to conversation

nodejs: Fix -Wc++11-narrowing on mips

PATCH New Khem Raj 1 participant 1 message Apr 15, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 nodejs: Fix -Wc++11-narrowing on mips

---
 .../nodejs/nodejs/mips-warnings.patch         | 19 +++++++++++++++++++
 .../recipes-devtools/nodejs/nodejs_12.14.1.bb |  1 +
 2 files changed, 20 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/nodejs/nodejs/mips-warnings.patch
meta-oe/recipes-devtools/nodejs/nodejs/mips-warnings.patch new file +19 -0
new file mode 100644
index 0000000000..1a773f23d8
@@ -0,0 +1,19 @@
+Add explicit static cast to fix narrowing warning
+
+Fixes
+deps/v8/src/codegen/mips/assembler-mips.cc:3556:44: error: non-constant-expression cannot be narrowed from type 'int' to 'size_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <[email protected]>
+--- a/deps/v8/src/codegen/mips/assembler-mips.cc
++++ b/deps/v8/src/codegen/mips/assembler-mips.cc
+@@ -3553,7 +3553,7 @@ void Assembler::GrowBuffer() {
+                                reloc_info_writer.last_pc() + pc_delta);
+ 
+   // Relocate runtime entries.
+-  Vector<byte> instructions{buffer_start_, pc_offset()};
++  Vector<byte> instructions{buffer_start_, static_cast<size_t>(pc_offset())};
+   Vector<const byte> reloc_info{reloc_info_writer.pos(), reloc_size};
+   for (RelocIterator it(instructions, reloc_info, 0); !it.done(); it.next()) {
+     RelocInfo::Mode rmode = it.rinfo()->rmode();
meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb +1 -0
index 28b4136a5a..d468fb3ffa 100644
@@ -22,6 +22,7 @@ SRC_URI = "http://nodejs.org/dist/v${PV}/node-v${PV}.tar.xz \
            file://big-endian.patch \
            file://0001-build-allow-passing-multiple-libs-to-pkg_config.patch \
            file://0002-build-allow-use-of-system-installed-brotli.patch \
+           file://mips-warnings.patch \
            "
 SRC_URI_append_class-target = " \
            file://0002-Using-native-binaries.patch \
Signature · 1 line
2.26.1